New issue
Advanced search Search tips

Issue 903582 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 5
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Task



Sign in to add a comment

Global Media Controls: Split KeyboardHook into modifier key and media key implementations

Project Member Reported by steimel@chromium.org, Nov 8

Issue description

Due to the way KeyboardHook works internally, it makes more sense to have split implementations for the existing modifier key hook and the planned media key hook
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c362c846e8f3691a869993c67dae583af16cb78a

commit c362c846e8f3691a869993c67dae583af16cb78a
Author: Tommy Steimel <steimel@chromium.org>
Date: Wed Nov 28 01:44:11 2018

[Global Media Controls] Split KeyboardHook into modifier/media impls

This CL creates a new type of KeyboardHook to listen to media keys.
KeyboardHook::Create is split in two, providing access to each type of
KeyboardHook. This creates the media hook implementation for Windows,
and returns nullptr for other platforms.

Bug:  903582 
Change-Id: I5eb6bbd94ec23dd54867eeb9ced585bc1b726961
Reviewed-on: https://chromium-review.googlesource.com/c/1333118
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611500}
[modify] https://crrev.com/c362c846e8f3691a869993c67dae583af16cb78a/chrome/test/BUILD.gn
[modify] https://crrev.com/c362c846e8f3691a869993c67dae583af16cb78a/ui/aura/window_tree_host_platform.cc
[modify] https://crrev.com/c362c846e8f3691a869993c67dae583af16cb78a/ui/events/BUILD.gn
[modify] https://crrev.com/c362c846e8f3691a869993c67dae583af16cb78a/ui/events/android/keyboard_hook_android.cc
[modify] https://crrev.com/c362c846e8f3691a869993c67dae583af16cb78a/ui/events/keyboard_hook.h
[modify] https://crrev.com/c362c846e8f3691a869993c67dae583af16cb78a/ui/events/keyboard_hook_base.cc
[modify] https://crrev.com/c362c846e8f3691a869993c67dae583af16cb78a/ui/events/keyboard_hook_base.h
[modify] https://crrev.com/c362c846e8f3691a869993c67dae583af16cb78a/ui/events/mac/keyboard_hook_mac.mm
[modify] https://crrev.com/c362c846e8f3691a869993c67dae583af16cb78a/ui/events/ozone/keyboard_hook_ozone.cc
[delete] https://crrev.com/b06aeeafb4536a7fbc49111e62e49d1a45af403e/ui/events/win/keyboard_hook_win.h
[add] https://crrev.com/c362c846e8f3691a869993c67dae583af16cb78a/ui/events/win/keyboard_hook_win_base.cc
[add] https://crrev.com/c362c846e8f3691a869993c67dae583af16cb78a/ui/events/win/keyboard_hook_win_base.h
[add] https://crrev.com/c362c846e8f3691a869993c67dae583af16cb78a/ui/events/win/media_keyboard_hook_win.cc
[add] https://crrev.com/c362c846e8f3691a869993c67dae583af16cb78a/ui/events/win/media_keyboard_hook_win_interactive_test.cc
[add] https://crrev.com/c362c846e8f3691a869993c67dae583af16cb78a/ui/events/win/media_keyboard_hook_win_unittest.cc
[rename] https://crrev.com/c362c846e8f3691a869993c67dae583af16cb78a/ui/events/win/modifier_keyboard_hook_win.cc
[rename] https://crrev.com/c362c846e8f3691a869993c67dae583af16cb78a/ui/events/win/modifier_keyboard_hook_win_unittest.cc
[modify] https://crrev.com/c362c846e8f3691a869993c67dae583af16cb78a/ui/events/x/keyboard_hook_x11.cc
[modify] https://crrev.com/c362c846e8f3691a869993c67dae583af16cb78a/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc
[modify] https://crrev.com/c362c846e8f3691a869993c67dae583af16cb78a/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

Status: Fixed (was: Started)

Sign in to add a comment