Flaky test: PictureInPicturePixelComparisonBrowserTest.VideoPlay Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.mac/Mac10.12%20Tests/16586 Test output log: https://chromium-swarm.appspot.com/task?id=410e3d687e9dac10 Culprit (100.0% confidence): r606552 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy4gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKrAWNocm9taXVtLm1hYy9NYWMxMC4xMiBUZXN0cy8xNjU4Ni9uZXR3b3JrX3NlcnZpY2VfYnJvd3Nlcl90ZXN0cyBvbiBJbnRlbCBHUFUgb24gTWFjIG9uIE1hYy0xMC4xMi42L1VHbGpkSFZ5WlVsdVVHbGpkSFZ5WlZCcGVHVnNRMjl0Y0dGeWFYTnZia0p5YjNkelpYSlVaWE4wTGxacFpHVnZVR3hoZVE9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20PictureInPicturePixelComparisonBrowserTest.VideoPlay&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy4gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKrAWNocm9taXVtLm1hYy9NYWMxMC4xMiBUZXN0cy8xNjU4Ni9uZXR3b3JrX3NlcnZpY2VfYnJvd3Nlcl90ZXN0cyBvbiBJbnRlbCBHUFUgb24gTWFjIG9uIE1hYy0xMC4xMi42L1VHbGpkSFZ5WlVsdVVHbGpkSFZ5WlZCcGVHVnNRMjl0Y0dGeWFYTnZia0p5YjNkelpYSlVaWE4wTGxacFpHVnZVR3hoZVE9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba0d48f8b3e768e554f6b30d7ab04e3f0e907e61 commit ba0d48f8b3e768e554f6b30d7ab04e3f0e907e61 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Thu Nov 08 23:52:22 2018 Revert "[Media UX] Enable the pixel by pixel comparison test for Mac OS." This reverts commit 0cfecb52487066ad0cc55ccf18635e6d28bd9b5d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 606552 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMGNmZWNiNTI0ODcwNjZhZDBjYzU1Y2NmMTg2MzVlNmQyOGJkOWI1ZAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.12%20Tests/16586 Sample Failed Step: network_service_browser_tests on Intel GPU on Mac on Mac-10.12.6 Sample Flaky Test: PictureInPicturePixelComparisonBrowserTest.VideoPlay Original change's description: > [Media UX] Enable the pixel by pixel comparison test for Mac OS. > > 1. Tested on Mac and verify everything works as expected. > 2. Removed the unnecessary call of GetNativeWindow(). > 3. The RGB for GPU enabled and GPU disabled test images is slightly different. Additional check is needed. > > Bug: 898230 > Change-Id: I85bf2450862361572597632159de60db6abf2c22 > Reviewed-on: https://chromium-review.googlesource.com/c/1307062 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606552} Change-Id: I10a133230cad3256bf4e5e0c3c925920484ce6a1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898230, 903580 Reviewed-on: https://chromium-review.googlesource.com/c/1327612 Cr-Commit-Position: refs/heads/master@{#606647} [modify] https://crrev.com/ba0d48f8b3e768e554f6b30d7ab04e3f0e907e61/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
These appear to have gone away; can't see them the past few hours.
Comment 1 by bugdroid1@chromium.org
, Nov 8