Review and update "Setting up new Commit Queue" doc |
||||||||
Issue descriptionEric, Could you please find someone to review https://chrome-internal.googlesource.com/infra/infra_internal/+/master/doc/setting_up_cq.md I see on step 6 it provides a command which specifies a master name, but I thought that there were no masters in LUCI world, which makes me concerned that the doc is out of date.
,
Nov 8
That's more in foundation's wheelhouse. Over to them.
,
Nov 8
,
Nov 9
The doc is indeed in need of an update. I'll update it as I make changes to CQ's config location.
,
Nov 9
,
Nov 12
Could someone please prioritize fixing Step 9 specifically? it references cq_name, but that hasn't existed for months now: https://chrome-internal-review.googlesource.com/c/infra/infra_internal/+/714552 It also mentions the __gerrit__ suffix, but I don't see that anywhere in here https://chrome-internal.googlesource.com/infra/puppet/+/master/puppetm/etc/puppet/hieradata/default.yaml#587 I'm trying to debug issue 826962, but I am a bit stuck because of the out-of-date instructions.
,
Nov 16
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/5e467b916fdacf6ee28d5676c5c0a94e0ce2ce9b commit 5e467b916fdacf6ee28d5676c5c0a94e0ce2ce9b Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Nov 16 00:03:54 2018
,
Nov 16
cq_name fixed.
,
Nov 16
Thanks Andrii! For posterity, note that this text still needs further audits and updates I think.
,
Nov 20
,
Nov 20
,
Dec 14
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by crouleau@chromium.org
, Nov 8