New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 903508 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 775198



Sign in to add a comment

Presubmit failure due to resources not using styles

Project Member Reported by wnwen@chromium.org, Nov 8

Issue description

Android Text Appearance Check failed:
    Your modified files contain Android text attributes defined outside
    text appearance styles, listed below.

    It is recommended to use the pre-defined text appearance styles in
      src/ui/android/java/res/values-v17/styles.xml

    And to use
      android:textAppearance="@style/SomeTextAppearance"
    in the XML layout whenever possible.

    If your text appearance absolutely has to deviate from the existing
    pre-defined text appearance style, you will need UX approval for adding a
    new text appearance style.

    If your approved text appearance style is a common text appreance style,
    please define it in src/ui/android/java/res/values-v17/styles.xml.

    Otherwise, if your approved text appearance is feature-specific, in
    chrome/android/java/res/values*/styles.xml, please define
      <style name="TextAppearance.YourTextAppearanceName>
        <item name="android:textColor">...</item>
        <item name="android:textSize">...</item>
        ...
      </style>

    Please contact hannahs@chromium.org for UX approval, and
    src/chrome/android/java/res/OWNERS for questions.
    See https://crbug.com/775198 for more information.
  
    chrome/android/java/res/layout/autofill_card_unmask_prompt.xml:27 contains attribute android:textColor
    	android:textColor="@color/input_underline_error_color" \
    chrome/android/java/res/layout/autofill_card_unmask_prompt.xml:47 contains attribute android:textColor
    	android:textColor="@color/explanation_text_color" \
    chrome/android/java/res/layout/autofill_card_unmask_prompt.xml:124 contains attribute android:textColor
    	android:textColor="@color/default_text_color_link" \
    chrome/android/java/res/layout/autofill_card_unmask_prompt.xml:137 contains attribute android:textColor
    	android:textColor="@color/input_underline_error_color" \
    chrome/android/java/res/layout/autofill_card_unmask_prompt.xml:168 contains attribute android:textColor
    	android:textColor="@color/explanation_text_color" \
    chrome/android/java/res/layout/autofill_card_unmask_prompt.xml:208 contains attribute android:textColor
    	android:textColor="@color/default_text_color_link" \
    chrome/android/java/res/layout/autofill_card_unmask_prompt.xml:26 contains attribute android:textSize
    	android:textSize="12sp" \
    chrome/android/java/res/layout/autofill_card_unmask_prompt.xml:46 contains attribute android:textSize
    	android:textSize="16sp" \
    chrome/android/java/res/layout/autofill_card_unmask_prompt.xml:136 contains attribute android:textSize
    	android:textSize="12sp" \
    chrome/android/java/res/layout/autofill_card_unmask_prompt.xml:167 contains attribute android:textSize
    	android:textSize="14sp" \
    chrome/android/java/res/layout/autofill_card_unmask_prompt.xml:209 contains attribute android:textSize
    	android:textSize="20sp" />
 
Blocking: 775198
Here are a couple more:

    chrome/android/java/res_autofill_assistant/layout/init_screen.xml:65 contains attribute android:textColor
        android:textColor="@color/default_text_color" \
    chrome/android/java/res_autofill_assistant/layout/init_screen.xml:72 contains attribute android:textColor
        android:textColor="@color/default_text_color" \
    chrome/android/java/res_autofill_assistant/layout/init_screen.xml:128 contains attribute android:textColor
        android:textColor="@color/modern_grey_50"

Please take a look, thanks Ganggui!
Summary: Presubmit failure due to resources not using styles (was: Presubmit failure)
Cc: mcar...@chromium.org
Components: UI>Browser>Autofill
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7130ee8febf169f9a7ef8b25abd5b1b44a00cb7

commit d7130ee8febf169f9a7ef8b25abd5b1b44a00cb7
Author: Mathias Carlen <mcarlen@chromium.org>
Date: Fri Nov 16 17:23:58 2018

[Autofill Assistant] Remove redundant textColor.

Visually this doesn't change anything and makes autofill_assisant Chrome
UI style compliant.

Bug: 903508
Change-Id: I42cd48c8be5994aa2a3da877ba023a9228ad0eec
Reviewed-on: https://chromium-review.googlesource.com/c/1340160
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608828}
[modify] https://crrev.com/d7130ee8febf169f9a7ef8b25abd5b1b44a00cb7/chrome/android/java/res_autofill_assistant/layout/init_screen.xml

Sign in to add a comment