New issue
Advanced search Search tips

Issue 903487 link

Starred by 1 user
Status: Fixed
Owner:
allenwebb@google.com
Closed: Dec 5
Cc:
drinkcat@chromium.org
metzman@chromium.org
igorcov@chromium.org
infe...@chromium.org
allenwebb@google.com
chromeos-continuous-integration-fire-hose@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Build-Toolchain



Sign in to add a comment

amd64-generic-fuzzer fails to build chromeos-ec

Project Member Reported by manojgupta@chromium.org, Nov 8 
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8930415417263230512

chromeos-ec-0.0.1-r5208:   EXE     cr50_fuzz.exe
chromeos-ec-0.0.1-r5208: build/host/cr50_fuzz/libec.a(libec.a.2.o): In function `validate_pcr_value':
chromeos-ec-0.0.1-r5208: /build/amd64-generic/tmp/portage/chromeos-base/chromeos-ec-0.0.1-r5208/work/chromeos-ec-0.0.1/platform/ec/common/pinweaver.c:433: undefined reference to `get_current_pcr_digest'
chromeos-ec-0.0.1-r5208: clang-8: error: linker command failed with exit code 1 (use -v to see invocation)
chromeos-ec-0.0.1-r5208: make[1]: *** [Makefile.rules:438: build/host/cr50_fuzz/cr50_fuzz.exe] Error 1
chromeos-ec-0.0.1-r5208: make: *** [Makefile.rules:344: host-cr50_fuzz] Error 2
chromeos-ec-0.0.1-r5208:  * ERROR: chromeos-base/chromeos-ec-0.0.1-r5208::chromiumos failed (compile phase):
chromeos-ec-0.0.1-r5208:  *   emake failed
chromeos-ec-0.0.1-r5208:  *

Comment 1 by manojgupta@chromium.org, Nov 8 

Allen, I have assigned this to you. Please re-assign as appropriate.

Comment 2 by allenwebb@google.com, Nov 8

Cc: igorcov@chromium.org
+igorcov@chromium.org

Comment 3 by allenwebb@google.com, Nov 8 

Do you think it would be possible to get the fuzz builder added to the CQ / PreCQ?

Comment 4 by manojgupta@chromium.org, Nov 8

Components: Infra>Client>ChromeOS>CI
I think adding to pre-cq or cq should be ok since *fuzzer builders are pretty fast. But we need to ask Infra if they have any objections to adding another builder to CQ/Pre-CQ.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/fa66dd458cfaedda81811f5bfce830bd0f065a31

commit fa66dd458cfaedda81811f5bfce830bd0f065a31
Author: Allen Webb <allenwebb@google.com>
Date: Fri Nov 09 19:20:47 2018

cr50_fuzz: Fix broken compilation

Adds mock implementation of get_current_pcr_digest() for the fuzz
target.

BRANCH=None
BUG= chromium:903487 
TEST=make -j buildfuzztests

Change-Id: I55b7da813d4f17ef7f60e045423a3917a052e41c
Signed-off-by: Allen Webb <allenwebb@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/1327128
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/fa66dd458cfaedda81811f5bfce830bd0f065a31/fuzz/cr50_fuzz.cc

Comment 6 by allenwebb@google.com, Dec 5

Status: Fixed (was: Untriaged)
►

Sign in to add a comment