Stylus/finger input only works for short strokes |
||||||||||
Issue description- Repro: canvas 2d scribbling: https://codepen.io/miguelao/full/OaMWLw paint on it with either finger or stylus (I tried nocturne and nautilus) - Expected/good revision: a line following the input is traced on the canvas - Bad revision: short lines appear upon pressing, but they don't follow the input; if I hover over the mouse pointer (with the trackpad) into the canvas area shortly after these lines are drawn, a long line is traced between the last "drawn" line and the position of the cursor, and follows it afterwards (as if the right-click-down was stuck). * (72.0.3603.0 11242)/486f0a7c2696d5779985a088546352b5e1345714 good * ToT now #606590: bad
,
Nov 8
,
Nov 8
adlr@ can you take a look plz? Thx
,
Nov 9
forwarding to xdai@ as per adlr@ offline conversation +sahel@ cc
,
Nov 9
See pseudo screen recording in https://youtu.be/HkmL_Qm5G4I This is on ToT nautilus on a 11242 OS.
,
Nov 9
Observed in the Ink demo on a Nocturne with fw 11238.0.0 and Chrome version 72.0.3607 built at 9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf aka Cr-Commit-Position: refs/heads/master@{#606832}
,
Nov 9
Bisected to the culprit CL https://chromium-review.googlesource.com/c/1313051 pdr@, please take a look.
,
Nov 9
Confirmed that reverting #7's CL fixes the problem, good job !!
,
Nov 9
It sounds like all touch/stylus input is broken.
,
Nov 9
I'm preparing a patch to disable the feature and hope it will make today's canary.
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57de6d5b80e57280fcbf04ef739fd6a48be1b907 commit 57de6d5b80e57280fcbf04ef739fd6a48be1b907 Author: Philip Rogers <pdr@chromium.org> Date: Fri Nov 09 20:58:13 2018 Mark PaintTouchActionRects as status=test due to stylus/touch regression This patch switches PaintTouchActionRects to status=test while the root-cause of https://crbug.com/903480 is investigated. This will turn the feature off for end-users and performance tests, though it is still on for layout tests and content shell. Bug: 903480 Change-Id: Iff6695cd6140c7caf29819a856a7b894fd4d6733 Reviewed-on: https://chromium-review.googlesource.com/c/1330070 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#606963} [modify] https://crrev.com/57de6d5b80e57280fcbf04ef739fd6a48be1b907/third_party/blink/renderer/platform/runtime_enabled_features.json5
,
Nov 9
ToT works for me now \o/ dev build 606967 input works fine on my nautilus
,
Nov 9
Reopening because we still need to fix this bug and re-enable PaintTouchActionRects.
,
Nov 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5d0ab06c81ed6ec74d73a87c4e0517f3ea1cd32 commit a5d0ab06c81ed6ec74d73a87c4e0517f3ea1cd32 Author: Philip Rogers <pdr@chromium.org> Date: Mon Nov 12 15:41:44 2018 [PaintTouchActionRects] Paint replaced hit test rects without background There was an early-out in ReplacedPainter::Paint that would skip painting touch-action hit test rects if the replaced element did not also paint a background. This patch skips the early-out if there is a hit test rect that should be painted. This does not fully fix https://crbug.com/903480 because accelerated canvases still do not generate the correct touch action rects. Bug: 903480 Change-Id: If6cda7339c5a20a04fe669c4d54fae30e83debf2 Reviewed-on: https://chromium-review.googlesource.com/c/1331033 Reviewed-by: Xianda Sun <sunxd@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#607236} [modify] https://crrev.com/a5d0ab06c81ed6ec74d73a87c4e0517f3ea1cd32/third_party/blink/renderer/core/layout/layout_object.h [modify] https://crrev.com/a5d0ab06c81ed6ec74d73a87c4e0517f3ea1cd32/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc [modify] https://crrev.com/a5d0ab06c81ed6ec74d73a87c4e0517f3ea1cd32/third_party/blink/renderer/core/paint/paint_invalidator.cc [modify] https://crrev.com/a5d0ab06c81ed6ec74d73a87c4e0517f3ea1cd32/third_party/blink/renderer/core/paint/replaced_painter.cc [modify] https://crrev.com/a5d0ab06c81ed6ec74d73a87c4e0517f3ea1cd32/third_party/blink/renderer/core/paint/view_painter.cc
,
Nov 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9a326102d53ea24ce359a3000c845769936fa14 commit b9a326102d53ea24ce359a3000c845769936fa14 Author: Philip Rogers <pdr@chromium.org> Date: Mon Nov 12 15:50:32 2018 [PaintTouchActionRects] Paint hit test rects when acceleration skips bg When a canvas is accelerated, the background is sometimes painted into the content layer (see ContentLayerSupportsDirectBackgroundComposition). When this occurs, we can skip painting the background but still need to paint the hit test rects. Bug: 903480 Change-Id: Iec5d564ffed9611011d78adc381c9d7d7153e960 Reviewed-on: https://chromium-review.googlesource.com/c/1329854 Reviewed-by: Xianda Sun <sunxd@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#607238} [modify] https://crrev.com/b9a326102d53ea24ce359a3000c845769936fa14/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc [modify] https://crrev.com/b9a326102d53ea24ce359a3000c845769936fa14/third_party/blink/renderer/core/paint/replaced_painter.cc
,
Nov 12
This has been fixed. We'll re-enable PaintTouchActionRects once https://crbug.com/903754 is fixed.
,
Nov 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82cc4869d96f7345e42e3114b4bb12e6f5c9a368 commit 82cc4869d96f7345e42e3114b4bb12e6f5c9a368 Author: Philip Rogers <pdr@chromium.org> Date: Wed Nov 14 15:47:56 2018 Re-enable PaintTouchActionRects This patch re-enables PaintTouchActionRects after the following changes: crrev.com/606921 - Ensure PaintChunk::hit_test_data is updated in a cached subsequence crrev.com/607236 - Paint replaced hit test rects without background crrev.com/607238 - Paint hit test rects when acceleration skips bg These fixes address all known issues. Bug: 903480 Change-Id: I8ae56a1b97b5d9345508a8193a55097a9040bd89 Reviewed-on: https://chromium-review.googlesource.com/c/1334330 Reviewed-by: Xida Chen <xidachen@chromium.org> Reviewed-by: Xianda Sun <sunxd@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#607991} [modify] https://crrev.com/82cc4869d96f7345e42e3114b4bb12e6f5c9a368/third_party/blink/renderer/platform/runtime_enabled_features.json5 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 Deleted