New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 903453 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

WebViewAPITest.TestCaptureVisibleRegion failing with OOP-D

Project Member Reported by samans@chromium.org, Nov 8

Issue description

I'm not sure why this is not failing on bots but when I run it locally with --enable-features=VizDisplayCompositor it fails.
 
Cc: fsam...@chromium.org kylec...@chromium.org jonr...@chromium.org
It's just failing because RWHVChildFrame::CopyFromSurface earlies out for reasons that are no longer valid. The fix is easy and I already have a CL sent out.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ac4b5e605f2b3920f38ebbd0c6b9735cbb83e50

commit 8ac4b5e605f2b3920f38ebbd0c6b9735cbb83e50
Author: Saman Sami <samans@chromium.org>
Date: Thu Nov 08 23:02:16 2018

Fix RHWVChildFrame::CopyFromSurface

Currently this method earlies out and returns an empty SkBitmap if
OOP-D is enabled. It should just proceed the same way as the
non-OOP-D case.

Bug:  903453 
Change-Id: I0943279e2d98885682f5b8d4e619413293575b5a
Reviewed-on: https://chromium-review.googlesource.com/c/1327418
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606637}
[modify] https://crrev.com/8ac4b5e605f2b3920f38ebbd0c6b9735cbb83e50/content/browser/renderer_host/render_widget_host_view_child_frame.cc

Labels: -Pri-3 Merge-Request-71 OS-Chrome OS-iOS OS-Linux OS-Mac OS-Windows Pri-1
We need to merge this back to M71. We are planning to ship VizDisplayCompositor in M71 and right now webview.captureVisibleRegion does not work when viz is enabled. The CL is very safe, it just removes a portion of code that we forgot to delete when  https://crbug.com/812059  was fixed.
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 9

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: Less than 21 days to go before AppStore submit on M71
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-71 Merge-Approved-71
Approving merge to M71 branch 3578 based on comment #1. Please merge ASAP. Thank you.
Labels: oopd-stable-blocker
Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 9

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39243aecde5bd420b0982d8ab1abc8731b8c3b9c

commit 39243aecde5bd420b0982d8ab1abc8731b8c3b9c
Author: Saman Sami <samans@chromium.org>
Date: Fri Nov 09 16:14:02 2018

Fix RHWVChildFrame::CopyFromSurface

Currently this method earlies out and returns an empty SkBitmap if
OOP-D is enabled. It should just proceed the same way as the
non-OOP-D case.

Bug:  903453 
Change-Id: I0943279e2d98885682f5b8d4e619413293575b5a
Reviewed-on: https://chromium-review.googlesource.com/c/1327418
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#606637}(cherry picked from commit 8ac4b5e605f2b3920f38ebbd0c6b9735cbb83e50)
Reviewed-on: https://chromium-review.googlesource.com/c/1329445
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#612}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/39243aecde5bd420b0982d8ab1abc8731b8c3b9c/content/browser/renderer_host/render_widget_host_view_child_frame.cc

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/39243aecde5bd420b0982d8ab1abc8731b8c3b9c

Commit: 39243aecde5bd420b0982d8ab1abc8731b8c3b9c
Author: samans@chromium.org
Commiter: samans@chromium.org
Date: 2018-11-09 16:14:02 +0000 UTC

Fix RHWVChildFrame::CopyFromSurface

Currently this method earlies out and returns an empty SkBitmap if
OOP-D is enabled. It should just proceed the same way as the
non-OOP-D case.

Bug:  903453 
Change-Id: I0943279e2d98885682f5b8d4e619413293575b5a
Reviewed-on: https://chromium-review.googlesource.com/c/1327418
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#606637}(cherry picked from commit 8ac4b5e605f2b3920f38ebbd0c6b9735cbb83e50)
Reviewed-on: https://chromium-review.googlesource.com/c/1329445
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#612}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment