New issue
Advanced search Search tips

Issue 903445 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 9
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

blink_perf.bindings/structured-clone-json-deserialize.html and 1 other(s) in performance_test_suite failing on chromium.perf/mac-10_13_laptop_high_end-perf

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Nov 8

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of eyaich@google.com

blink_perf.bindings/structured-clone-json-deserialize.html and 1 other(s) in performance_test_suite failing on chromium.perf/mac-10_13_laptop_high_end-perf

Builders failed on: 
- mac-10_13_laptop_high_end-perf: 
  https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/mac-10_13_laptop_high_end-perf


 
Looks like this might have had a hard start so kicking off a bisect.  

From the screenshot might be another keychain error:
https://00e9e64baccdce209bcd04a75aa42c22d4d434e5af81916711-apidata.googleusercontent.com/download/storage/v1/b/chrome-telemetry-output/o/0e459254-e37a-11e8-8933-787b8ab24218?qk=AD5uMEvIsVRcLRlUtUgPZg8MiANYkR1WesZqKtj8wnHkA1XLPmfG-yEs-CnuQJhHT4rM3lgZoOnWenpBfHL7rf0cBdsOKMrl9zL_JUpQzCCDXWFHK1srk9nmAMh4DU9VFAzYXYttdhx30Pzzn506tLQtv2vfIIFE2QaeShOviZK1Wka7F5lr2GDRpd8hdrxHN2Rsr3IPfPZvp9jHepm1oW_y4S85yuZDRriRJUXnzu9tZPhmzqBWincMcjevAx0msvuNj9qB9PZYHTtewgqZI7VKHNWXUs3XzEiBOq0bCkVxGkGONbHyFGdw5d7eOTmfdLNScA47jJfB7NeSEopARI6EY_ImxEIEn9sxnzEt5NMP7L-EI7Rim0TAl1MjN1Ie1Dni2Rfn8yo8ggNkzj909gby7uwiHQoGHeczLnRow-HMSbjEEeR58XZ4KmfMDH_kuom2T4dxpDFrWdJ2Q2OT_HSGoS8GKhBf9jI1W6Ac9tdot9AbUh_oYIC1uI4AyKCajHcNFrqppTSddSrUhqmL92Y5OnmeENJS__KcgraalF3_UWVLqDfVDw4WUOYoaAO-YGMB5c7T1_C7k8Vahdg5vwCNbM7LSy7xQ8g8p46NbiTLaZ5ZYtdoHzIJOKpkJa9NPajqeodiTfGpaniWwJ1I9avmS7kn5p8znzHDY1WTiAZiLYnYHbt0Aco4Ma1oAIy43u88kV5PKFjWYEHuGsYduHmzshYvN05sLTmlY8aabJbsK_a77oo9pP3vQW4-caFufM4aS9A3uWGisMwzqnA8lw9zZjrMc_JZmM7Pn8lVEwr5S_atZH0TC1oUlO-X0_uPBksDXlJt_d3E


Might be related to issues we are seeing with speedometer: crbug.com/903412


From the logs: 
(ERROR) 2018-11-08 09:10:12,133 story_runner.ProcessError:100  Handleable error
Traceback (most recent call last):
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 126, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 300, in RunStory
    self._current_page.Run(self)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/page/__init__.py", line 96, in Run
    shared_state.page_test.DidNavigateToPage(self, current_tab)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/tools/perf/benchmarks/blink_perf.py", line 247, in DidNavigateToPage
    tab.WaitForJavaScriptCondition('testRunner.isWaitingForTelemetry')
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 245, in WaitForJavaScriptCondition
    return self._inspector_backend.WaitForJavaScriptCondition(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 307, in WaitForJavaScriptCondition
    self.GetCurrentConsoleOutputBuffer())
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 41, in Inner
    inspector_backend._ConvertExceptionFromInspectorWebsocket(e)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 38, in Inner
    return func(inspector_backend, *args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 196, in GetCurrentConsoleOutputBuffer
    return self._console.GetCurrentConsoleOutputBuffer(timeout)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_console.py", line 38, in GetCurrentConsoleOutputBuffer
    self._inspector_websocket.DispatchNotifications(timeout)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 156, in DispatchNotifications
    self._Receive(timeout)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 181, in _Receive
    raise WebSocketException(err)
TimeoutException: Timeout after 60s while waiting for JavaScript:testRunner.isWaitingForTelemetry
Cc: kdillon@chromium.org
Owner: kdillon@chromium.org
Status: Assigned (was: Available)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14bcaf3be40000

Adding more payload for worker perf tests. by kdillon@chromium.org
https://chromium.googlesource.com/chromium/src/+/91d36d3b3ec3a8d25e64f10aa48b4ffd176a6e77
Failure rate: 0 → 1 (+1)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/blink-perf-benchmarks
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf1a66244336aaf8363c5c7ec68a7c8e9299320a

commit bf1a66244336aaf8363c5c7ec68a7c8e9299320a
Author: Katie Dillon <kdillon@chromium.org>
Date: Fri Nov 09 18:46:11 2018

Perf_tests small fix.

Missed changing these two perf tests while making this change:
https://chromium-review.googlesource.com/c/chromium/src/+/1318390

Bug:  903445 
Change-Id: I8d151bfc464aae4cc1d0bd8fa993607cde25d18d
Reviewed-on: https://chromium-review.googlesource.com/c/1327524
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606914}
[modify] https://crrev.com/bf1a66244336aaf8363c5c7ec68a7c8e9299320a/third_party/blink/perf_tests/bindings/structured-clone-json-deserialize.html
[modify] https://crrev.com/bf1a66244336aaf8363c5c7ec68a7c8e9299320a/third_party/blink/perf_tests/bindings/structured-clone-json-serialize.html

Status: Fixed (was: Assigned)

Sign in to add a comment