Active tab has wrong text color |
||||||||
Issue descriptionChrome Version: 72.0.3602.2 OS: Linux What steps will reproduce the problem? (1) Start with a new profile, install this theme: https://chrome.google.com/webstore/detail/material-incognito-dark-t/ahifcnpnjgbadkjdhagpfjfkmlapfoel (2) Open a few tabs. Note the active tab has white text and inactive tabs have gray text. (3) Switch to the second tab from the left. (4) Press ctrl + w to close the second tab. What is the expected result? The new active tab has white text. What happens instead? The new active tab has gray text. Will bisect in a bit...
,
Nov 8
In step (1), one can also just open an incognito window, which is similar to the theme I suggested using.
,
Nov 9
Note that if you hover over the tab, it goes back to the correct color. Related issue: perform the following steps: (1) open two tabs (2) select the first (3) close with ctrl+w (4) hover over the newly active tab (5) then open a new tab At this point, both tabs will have white text.
,
Nov 9
There seems to be another issue (which I assume is similar) where background tabs get given the active tab text color. Sangwoo, can you either revert r604497 or fix?
,
Nov 10
Thank you for letting me know this :) I think reverting would be very paintul. let me try yo fix this.
,
Nov 10
,
Nov 12
Issue 903743 has been merged into this issue.
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75429d4ae805e82e1bf8517246a492af60939c7b commit 75429d4ae805e82e1bf8517246a492af60939c7b Author: sangwoo.ko <sangwoo.ko@navercorp.com> Date: Tue Nov 13 04:25:38 2018 Notify selection changes made by tab removal When selected tabs were removed, we must notify that even selection model is unchanged. This is because the old selection model and new one would be same when the newly activated tab was right after prviously active tab. Bug: 842194 , 903438 Change-Id: I23fd9d8ba9f1ac10b3daf03088a2c2d974f435d8 Reviewed-on: https://chromium-review.googlesource.com/c/1331098 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607485} [modify] https://crrev.com/75429d4ae805e82e1bf8517246a492af60939c7b/chrome/browser/ui/tabs/tab_strip_model.cc [modify] https://crrev.com/75429d4ae805e82e1bf8517246a492af60939c7b/chrome/browser/ui/tabs/tab_strip_model_observer.cc [modify] https://crrev.com/75429d4ae805e82e1bf8517246a492af60939c7b/chrome/browser/ui/tabs/tab_strip_model_observer.h
,
Nov 13
I just landed a fix for this. Thank you all :)
,
Nov 14
Able to reproduce the issue on chrome version 72.0.3602.2 (build without fix) Verified the fix on Windows 10 and Ubuntu 17.10 using Chrome version # 72.0.3610.0. Attaching screencast for reference. Observed that " The new active tab has white text " The fix is working as expected, adding Verified labels Thanks...! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by thestig@chromium.org
, Nov 8