New issue
Advanced search Search tips

Issue 903427 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

MultiUserWindowManagerChromeOSTest.TabletModeInteraction fails

Project Member Reported by sky@chromium.org, Nov 8

Issue description

This test enables tablet mode, but it enables tablet mode in such a way that MultiUserWindowManager doesn't see (and process) the change. When the test is updated to correctly notify MultiUserWindowManager the test then fails. I think this may indicate a regression from recent changes and needs to be investigated.

The change that impacted this is https://chromium-review.googlesource.com/c/chromium/src/+/1229178/.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b1a44bc8e7e6048bd2fb00e18769889684eb9a9

commit 6b1a44bc8e7e6048bd2fb00e18769889684eb9a9
Author: Scott Violet <sky@chromium.org>
Date: Thu Nov 08 19:34:08 2018

chromeos: disables test as it fails

This test enables tablet mode, but it enables tablet mode in such a way
that MultiUserWindowManager doesn't see (and process) the change. When
the test is updated to correctly notify MultiUserWindowManager the test then
fails. I think this may indicate a regression from recent changes and needs
to be investigated.

I came across this while doing some refactoring to MultiUserWindowManager.

I've updated the test to ensure MultiUserWindowManager is called correctly
and disabled it.

BUG= 756085 , 903427 
TEST=none

Change-Id: I7b6ead448ba8d942516e42d9ef5ee745a547cc2c
Reviewed-on: https://chromium-review.googlesource.com/c/1327159
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606567}
[modify] https://crrev.com/6b1a44bc8e7e6048bd2fb00e18769889684eb9a9/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc

Components: -UI>Shell UI>Shell>TabletMode
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab01537c6e9aaf8517e3db38c593afc652cdd5e4

commit ab01537c6e9aaf8517e3db38c593afc652cdd5e4
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Nov 09 22:22:49 2018

cros: Fix and enable failing MultiUserWindowManagerChromeOS.TabletModeInteraction.

Now that tablet mode manager tracks all user windows and not just current
accounts, the window should be non account windows should be maximized
on entering tablet mode, not on user switch.

Test: unit_tests MultiUserWindowManagerChromeOS.TabletModeInteraction
Bug:  903427 
Change-Id: Ib21a7e1d7f1a37f8a571ad16226f11e03f0db960
Reviewed-on: https://chromium-review.googlesource.com/c/1329502
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606998}
[modify] https://crrev.com/ab01537c6e9aaf8517e3db38c593afc652cdd5e4/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment