New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 903398 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 14
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-11-14
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocked on:
issue 864763



Sign in to add a comment

Move doodle styling and logic into dedicated files

Project Member Reported by kmilka@chromium.org, Nov 8

Issue description

The logic and styling for doodles has grown quite large, they should probably be moved into their own doodles.css and doodles.js files.

May need to fix  issue 864763  first.
 
Labels: small KR-NTP-Architecture-Local Target-72 O-Optimal-NTP-Architecture
NextAction: 2018-11-14
Labels: zine-triaged
The NextAction date has arrived: 2018-11-14
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40bbe3ee5fc19df9f86146f5d357aaf198d3dcce

commit 40bbe3ee5fc19df9f86146f5d357aaf198d3dcce
Author: Kyle Milka <kmilka@chromium.org>
Date: Fri Dec 14 23:24:25 2018

[NTP] Move doodle logic and styling

Move css and js for NTP doodles into separate files.

Alphabetize resource lists in various places.

Bug:  903398 
Change-Id: I7994c6785b52b757dd4196f2467e14800e6f385c
Reviewed-on: https://chromium-review.googlesource.com/c/1374835
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616871}
[add] https://crrev.com/40bbe3ee5fc19df9f86146f5d357aaf198d3dcce/chrome/browser/resources/local_ntp/doodles.css
[add] https://crrev.com/40bbe3ee5fc19df9f86146f5d357aaf198d3dcce/chrome/browser/resources/local_ntp/doodles.js
[modify] https://crrev.com/40bbe3ee5fc19df9f86146f5d357aaf198d3dcce/chrome/browser/resources/local_ntp/local_ntp.css
[modify] https://crrev.com/40bbe3ee5fc19df9f86146f5d357aaf198d3dcce/chrome/browser/resources/local_ntp/local_ntp.html
[modify] https://crrev.com/40bbe3ee5fc19df9f86146f5d357aaf198d3dcce/chrome/browser/resources/local_ntp/local_ntp.js
[modify] https://crrev.com/40bbe3ee5fc19df9f86146f5d357aaf198d3dcce/chrome/browser/resources/local_ntp_resources.grd
[modify] https://crrev.com/40bbe3ee5fc19df9f86146f5d357aaf198d3dcce/chrome/browser/search/BUILD.gn
[modify] https://crrev.com/40bbe3ee5fc19df9f86146f5d357aaf198d3dcce/chrome/browser/search/local_ntp_source.cc
[modify] https://crrev.com/40bbe3ee5fc19df9f86146f5d357aaf198d3dcce/chrome/browser/ui/search/local_ntp_doodle_browsertest.cc
[modify] https://crrev.com/40bbe3ee5fc19df9f86146f5d357aaf198d3dcce/chrome/test/data/local_ntp/local_ntp_browsertest.html

Status: Fixed (was: Started)

Sign in to add a comment