New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 19
Cc:
Components:
EstimatedDays: 5
NextAction: ----
OS: Chrome
Pri: 0
Type: Feature

Blocking:
issue 912185
issue 903384
issue 903386


Show other hotlists

Hotlists containing this issue:
CrOSParallelCQ


Sign in to add a comment
link

Issue 903385: Implement a template-based linking spec for Milo

Reported by jclinton@chromium.org, Nov 8 Project Member

Issue description

This tracks adding a feature to Milo that allows build result pages within a project to have an additional set of project-defined links show up on all build results pages. And to have those links include details about the build in their generated URL’s. For example, it should be possible to have a link that is formed that looks like http://foo/?builder=SOME_BUILD&start_time=BUILD_START_TIME . We can use the facility to pre-fill bugs: “https://bugs.chromium.org/p/chromium/issues/entry?summary=Builder: {BUILDER} had a problem&description=At time {BUILD_FINISH_TIME}, ...”.
 

Comment 1 by jclinton@chromium.org, Nov 8

Blocking: 903386

Comment 2 by jclinton@chromium.org, Nov 13

Labels: Disable-Nags

Comment 3 by dburger@google.com, Nov 27

Status: Started (was: Assigned)

Comment 4 by hinoka@chromium.org, Dec 5

Issue 912185 has been merged into this issue.

Comment 5 by dburger@chromium.org, Dec 10

EstimatedDays: 2

Comment 6 by dburger@chromium.org, Dec 14

EstimatedDays: 5
Scope expanded a bit to interpolate from the standard Build proto. Also delayed a bit from a refactoring of the build page as it is reworked in front of the buildbot deprecation and the build sources it handles.

Comment 7 by jyasskin@google.com, Dec 14

Blocking: 912185

Comment 8 by bugdroid1@chromium.org, Dec 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/df33273c1a97445114b0b913252b7b0a9a4cc241

commit df33273c1a97445114b0b913252b7b0a9a4cc241
Author: David Burger <dburger@chromium.org>
Date: Mon Dec 17 21:44:45 2018

Add bug links functionality for build pages

Add the ability to put links on the build pages intended
to allow prefilling of bug entry forms. Configuration protos
are changed to allow the entering of an optional BugTemplate
for a project. The template features summary and description
placeholders that get interpolated by the context of the
build. If all the interpolation placeholders for a particular
template are satisfied that link is rendered on the page.

The template syntax follows that of the built in go
templates. That is {{.placheholder}} style. The placeholders
that are allowed are documented in the proto definition file.
Additional placeholders are added easily if the data needed
can be obtained from either query parameters or the MiloBuild
data instance.

Bug:  903385 
Change-Id: I9f551772d14d0b90f1adcf87bfa1d029446486d3
Reviewed-on: https://chromium-review.googlesource.com/c/1355340
Reviewed-by: David Burger <dburger@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: David Burger <dburger@chromium.org>

[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/api/config/generate.go
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/api/config/project.pb.go
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/api/config/project.proto
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/api/config/proto_gae.gen.go
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/common/config.go
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/appengine/templates/pages/build_legacy.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/buildbot.build-Debug_page-_chromium_presubmit_426944.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/buildbot.build-Debug_page-_gerritCL_1234.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/buildbot.build-Debug_page-_win_chromium_rel_ng_246309.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/swarming.build-Basic_successful_build.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/swarming.build-build-canceled.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/swarming.build-build-exception.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/swarming.build-build-expired.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/swarming.build-build-finished-logdog-expired-stream.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/swarming.build-build-gerrit.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/swarming.build-build-internal.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/swarming.build-build-link.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/swarming.build-build-nested.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/swarming.build-build-patch-failure.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/swarming.build-build-pending-logdog.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/swarming.build-build-pending.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/swarming.build-build-running-logdog-no-annotation-stream.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/swarming.build-build-running-logdog.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/swarming.build-build-running.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/swarming.build-build-timeout.html
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/expectations/swarming.build-build-unicode.html
[add] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/feedback_links.go
[modify] https://crrev.com/df33273c1a97445114b0b913252b7b0a9a4cc241/milo/frontend/view_build_legacy.go

Comment 9 by bugdroid1@chromium.org, Dec 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/ebac1c199ba95f0ee490c25e673a3e5f391ee8a2

commit ebac1c199ba95f0ee490c25e673a3e5f391ee8a2
Author: David Burger <dburger@chromium.org>
Date: Wed Dec 26 21:41:46 2018

Add {{.MiloBuildUrl}} as build page feedback link interpolation placeholder

Add the placeholder {{.MiloBuildUrl}} as a placeholder that can be used in
BugTemplates for formulating the feedback URL. This allows the user to easily
insert a URL back to the build page in the description of the bug created
by the feedback link.

This feature is added to the legacy page - presumably when the new build page
refactoring is more complete and the dust settles there this functionality will
likewise be moved to that page.

Bug:  903385 
Change-Id: I2310608df3cac9755747cb04529021fd5b7be300
Reviewed-on: https://chromium-review.googlesource.com/c/1382612
Commit-Queue: David Burger <dburger@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/ebac1c199ba95f0ee490c25e673a3e5f391ee8a2/milo/api/config/project.proto
[modify] https://crrev.com/ebac1c199ba95f0ee490c25e673a3e5f391ee8a2/milo/frontend/view_build_legacy.go

Comment 10 by bugdroid1@chromium.org, Jan 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/1c076a28342671222591fe6b1079bdf3141a36a6

commit 1c076a28342671222591fe6b1079bdf3141a36a6
Author: David Burger <dburger@chromium.org>
Date: Tue Jan 08 21:36:25 2019

Add {{.MiloBuilderUrl}} as build page bug template placeholder

Add the placeholder {{.MiloBuilderUrl}} as a placeholder that can be used
in BugTemplates for formulating the feedback URL on the build page. This
allows a user to easily insert a URL back to the builder page in the
description of the bug created by the feedback link.

This feature is added to the legacy page - presumably when the new build page
refactoring is more complete and the dust settles there this functionality will
likewise be moved to that page.

Bug:  903385 
Change-Id: Ia29515b7c225acd7a49e92b1176b3c450c453077
Reviewed-on: https://chromium-review.googlesource.com/c/1390979
Commit-Queue: David Burger <dburger@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/1c076a28342671222591fe6b1079bdf3141a36a6/milo/api/config/project.proto
[modify] https://crrev.com/1c076a28342671222591fe6b1079bdf3141a36a6/milo/frontend/view_build_legacy.go

Comment 11 by bugdroid, Feb 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/0e5fe76de1342e24f743a247fd861f74a953b1e2

commit 0e5fe76de1342e24f743a247fd861f74a953b1e2
Author: David Burger <dburger@chromium.org>
Date: Fri Feb 01 23:05:50 2019

Add build page feedback links for LUCI build pages

Add the build page feedback links available in the legacy view build
pages to the LUCI build pages.

Bug:903385
Change-Id: I0ca24331a90f62f30e179be8ebeae0ffba51e673
Reviewed-on: https://chromium-review.googlesource.com/c/1423402
Commit-Queue: David Burger <dburger@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/0e5fe76de1342e24f743a247fd861f74a953b1e2/milo/api/config/project.pb.go
[modify] https://crrev.com/0e5fe76de1342e24f743a247fd861f74a953b1e2/milo/api/config/project.proto
[modify] https://crrev.com/0e5fe76de1342e24f743a247fd861f74a953b1e2/milo/api/proto/pb.discovery.go
[modify] https://crrev.com/0e5fe76de1342e24f743a247fd861f74a953b1e2/milo/buildsource/buildbucket/build.go
[rename] https://crrev.com/0e5fe76de1342e24f743a247fd861f74a953b1e2/milo/buildsource/buildbucket/feedback_links.go
[modify] https://crrev.com/0e5fe76de1342e24f743a247fd861f74a953b1e2/milo/frontend/appengine/templates/pages/build.html
[modify] https://crrev.com/0e5fe76de1342e24f743a247fd861f74a953b1e2/milo/frontend/expectations/buildbucket.build-Test_page-_MacTests.html
[modify] https://crrev.com/0e5fe76de1342e24f743a247fd861f74a953b1e2/milo/frontend/expectations/buildbucket.build-Test_page-_linux-rel.html
[modify] https://crrev.com/0e5fe76de1342e24f743a247fd861f74a953b1e2/milo/frontend/ui/build.go
[modify] https://crrev.com/0e5fe76de1342e24f743a247fd861f74a953b1e2/milo/frontend/view_build.go
[modify] https://crrev.com/0e5fe76de1342e24f743a247fd861f74a953b1e2/milo/frontend/view_build_legacy.go

Comment 12 by hinoka@chromium.org, Feb 12

Components: -Infra>Platform>Milo>LUCI Infra>Platform>Milo
Moving Milo components (Infra>Platform>Milo>LUCI -> Infra>Platform>Milo)

Comment 13 by dburger@chromium.org, Feb 19 (3 days ago)

Status: Verified (was: Started)

Sign in to add a comment