New issue
Advanced search Search tips

Issue 903383 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

[WPT] New failures introduced in external/wpt/css by import https://crrev.com/c/1326422

Issue description

WPT import https://crrev.com/c/1326422 introduced new failures in external/wpt/css:

List of new failures:
external/wpt/css/filter-effects/interfaces.any.html new failing tests: https://crrev.com/c/1326422/4/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/interfaces.any-expected.txt
external/wpt/css/filter-effects/filter-grayscale-003.html [ Failure ]
external/wpt/css/filter-effects/filter-grayscale-002.html [ Failure ]
external/wpt/css/filter-effects/filter-external-002-test.html [ Failure ]
external/wpt/css/filter-effects/filter-cb-abspos-inline-003.html [ Failure ]
external/wpt/css/filter-effects/css-filters-animation-saturate.html [ Failure ]
external/wpt/css/filter-effects/css-filters-animation-hue-rotate.html [ Failure ]
external/wpt/css/filter-effects/css-filters-animation-combined-001.html [ Failure ]
external/wpt/css/filter-effects/filter-external-001-test.html [ Failure ]
external/wpt/css/filter-effects/css-filters-animation-drop-shadow.html [ Failure ]
external/wpt/css/filter-effects/css-filters-animation-blur.html [ Failure ]
external/wpt/css/filter-effects/filters-test-brightness-003.html [ Failure ]
external/wpt/css/filter-effects/filter-contrast-003.html [ Failure ]
external/wpt/css/filter-effects/fecolormatrix-type.html [ Failure ]

This import contains upstream changes from 4477b9d2fadaca4314a9fc7d88ab6db6ad47a321 to 4477b9d2fadaca4314a9fc7d88ab6db6ad47a321:

 
Cc: ericwilligers@chromium.org
This is the new failures after unskipping filter-effects.

Eric, if there's a more specific team/component for this directory, you might want to create an OWNERS file in filters-effects.
Cc: masonfreed@chromium.org
Components: -Blink>CSS Blink>Paint
Excluding the animation tests, these are likely paint related.
Cc: schenney@chromium.org
Status: Available (was: Untriaged)
I'll use this to validate our script for tracking these new test failures.
I remember looking at some of these (the ones that does not pass on any browser per the "Interoperability" view on https://wpt.fyi/results/css/filter-effects). IIRC there was a few test bugs in there, although I can't quite recall the details. Can process these again tomorrow if needed.
I looked at these yesterday. There are some test bugs with the ref having different text. Otherwise many of them were minor color differences (color space issues maybe) and some were possibly bugs.

It's not clear what to do about the color mismatches.
I've made fixes and tweaks to some of the tests (will upload shortly). We'll see how that fares.

Here's a copy of my notes [(*) means I've fixed or tweaked the test]:

filters-test-brightness-003.html (*)

  brightness() - '0' used as default value for when spec says '1'.
  (This test will pass even if a browser does not support "no argument" though)

filter-grayscale-002.html (*)
filter-grayscale-003.html (*)

  Incorrect ref (The ref the additional text "(and not blue)".)

filter-external-002-test.html

  color-interpolation-filters issue

filter-cb-abspos-inline-003.html

  Expects 'perspective' to not establish CB.

css-filters-animation-saturate.html (*)

  Expects interpolation of saturate() argument between 5000% and 0%.
  Initial value for saturate() is '1' (100%) however.

css-filters-animation-hue-rotate.html (*)

  Looks like it intends to sample at 50%, but it samples at 25%.

css-filters-animation-drop-shadow.html (*)

  Gray vs. gray (really: transparent black) on the interpolated drop-shadow.

css-filters-animation-combined-001.html (*)

  Expected initial value (argument) for animation of opacity(...) to be 0.

fecolormatrix-type.html

  Visually non-discernible but non-exact match (off-by-one or so on the ref)

filter-external-001-test.html

  Visually non-discernible but non-exact match (off-by-one or so on the ref)

filter-contrast-003.html

  Visually non-discernible but non-exact match (black vs. not-quite-black?)

css-filters-animation-blur.html

  Visually non-discernible but non-exact match (PASS on wpt.fyi)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23bcf533877570c6ed17bd67ac1634a78959eb72

commit 23bcf533877570c6ed17bd67ac1634a78959eb72
Author: Fredrik Söderquist <fs@opera.com>
Date: Tue Nov 13 17:18:57 2018

Fixes and tweaks to wpt/css/filter-effects/

filter-contrast-003.html

  Adjust the color from #400000 to #3f0000, since (0x40 / 255) is just
  over 0.25 and can after filtering and rounding end up above 0.
  (0x3f / 255) on the other hand is just below 0.25 and the result will
  be clamped to zero.

filter-external-001-test.html
filter-external-002-test.html

  Change the hue-rotate parameter in the external file from 120 to 150.
  Move the file to support/ and remove lint entry.
  Make both filters operate in sRGB to make computing the reference
  easier. Use rgb(...) notation with percentage values in reference.

fecolormatrix-type.html

  Add color-interpolation-filters=sRGB to the filter to make it easier
  to reason about what the result should be. Use rgba(...) notation in
  the ref using percentage notation.

filters-test-brightness-003.html

  Add 'filter: brightness(0)' before 'filter: brightness()' to properly
  test if the "no argument" notation is considered valid by the parser.

filter-grayscale-001.html
filter-grayscale-002.html
filter-grayscale-003.html
filter-grayscale-004.html
filter-grayscale-005.html

  Remove the " (and not blue)" text from the reference and update the
  001,004 and 005 tests accordingly.

css-filters-animation-saturate.html

  Interpolate the argument from 4900% rather than 5000% to end at the
  ref's 2500% (25).

css-filters-animation-hue-rotate.html

  Sample the animation at .5 to match the expectation.

css-filters-animation-drop-shadow.html

  Use explicit rgba(...) in the ref rather than the keyword 'gray'.
  We're interpolating the color of the drop-shadow from 'black'
  (rgba(0, 0, 0, 1)) to 'transparent' (rgba(0, 0, 0, 0)) here, so it's
  better and more accurate to describe the color as "semi-transparent
  black" (rgba(0, 0, 0, 0.5)).

css-filters-animation-combined-001.html

  Initial value for animation for 'opacity(...)' is '1' - not zero.
  Change test to interpolate from 0 -> 1 (rather than 1 -> 1)

Bug: 903383
Change-Id: I4d0113989414616494b98c22fbac817f007cd762
Reviewed-on: https://chromium-review.googlesource.com/c/1333816
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#607628}
[modify] https://crrev.com/23bcf533877570c6ed17bd67ac1634a78959eb72/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/23bcf533877570c6ed17bd67ac1634a78959eb72/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/css-filters-animation-combined-001.html
[modify] https://crrev.com/23bcf533877570c6ed17bd67ac1634a78959eb72/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/css-filters-animation-drop-shadow-ref.html
[modify] https://crrev.com/23bcf533877570c6ed17bd67ac1634a78959eb72/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/css-filters-animation-drop-shadow.html
[modify] https://crrev.com/23bcf533877570c6ed17bd67ac1634a78959eb72/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/css-filters-animation-hue-rotate.html
[modify] https://crrev.com/23bcf533877570c6ed17bd67ac1634a78959eb72/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/css-filters-animation-saturate.html
[modify] https://crrev.com/23bcf533877570c6ed17bd67ac1634a78959eb72/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/fecolormatrix-type-ref.html
[modify] https://crrev.com/23bcf533877570c6ed17bd67ac1634a78959eb72/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/fecolormatrix-type.html
[modify] https://crrev.com/23bcf533877570c6ed17bd67ac1634a78959eb72/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/filter-contrast-003.html
[modify] https://crrev.com/23bcf533877570c6ed17bd67ac1634a78959eb72/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/filter-external-001-ref.html
[modify] https://crrev.com/23bcf533877570c6ed17bd67ac1634a78959eb72/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/filter-external-001-test.html
[delete] https://crrev.com/68c381e398ad53d6c47c9213ff07189b9867f1e3/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/filter-external-002-filter.svg
[modify] https://crrev.com/23bcf533877570c6ed17bd67ac1634a78959eb72/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/filter-external-002-test.html
[modify] https://crrev.com/23bcf533877570c6ed17bd67ac1634a78959eb72/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/filter-grayscale-001.html
[modify] https://crrev.com/23bcf533877570c6ed17bd67ac1634a78959eb72/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/filter-grayscale-004.html
[modify] https://crrev.com/23bcf533877570c6ed17bd67ac1634a78959eb72/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/filter-grayscale-005.html
[modify] https://crrev.com/23bcf533877570c6ed17bd67ac1634a78959eb72/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/filter-grayscale-ref.html
[modify] https://crrev.com/23bcf533877570c6ed17bd67ac1634a78959eb72/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/filters-test-brightness-003.html
[add] https://crrev.com/23bcf533877570c6ed17bd67ac1634a78959eb72/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/support/filter-external-002-filter.svg
[modify] https://crrev.com/23bcf533877570c6ed17bd67ac1634a78959eb72/third_party/WebKit/LayoutTests/external/wpt/lint.whitelist

interfaces.any.html

  SVGFEBlendElement.<various constants> - looks like we're the only ones lacking this, so should probably just add them. Will file a new bug for that.
  SVGFEGaussianBlurElement.prototype.edgeMode - not implemented. Only WebKit expose and implement this. We can ignore this.
  SVGFEImageElement.prototype.crossOrigin - lacking, but also not implemented by anyone else (yet), so can be ignored.

filter-cb-abspos-inline-003.html

  I initially thought this might be caused by the 'perspective' property, but removing it had no effect. Maybe worth looking into.

css-filters-animation-combined-001.html

  Visually indiscernible difference. Maybe caused by the blur(...) - hard to say when there's like 10 filter functions though...

css-filters-animation-blur.html

  Visually indiscernible difference. This is the reason I suspected something with blur(...) in the above. It could be worth noting that this test passes in the runs made by wpt.fyi.

filters-test-brightness-003.html

  Incorrect default value when no arguments are specified. (Is '0' but should be '1'.) Easy fix, but may break content (the "no arguments" counter is at 0.03% and the brightness() counter is at 1.75% - '0' is not the most useful value here though...)
Filed  issue 906612  for SVGFEBlendElement constants.
Labels: Pri-2
Setting defect without priority to default.

Sign in to add a comment