New issue
Advanced search Search tips

Issue 903289 link

Starred by 1 user

Issue metadata

Status: Closed
Owner:
Closed: Nov 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rebaseline degenerate gradient layout test

Project Member Reported by michaelludwig@google.com, Nov 8

Issue description

The following layout test is currently incorrect:

svg/custom/radial-gradient-negative-radius.html

It contains a repeating gradient with a negative radius, which gets clamped to a zero radius. The CSS spec states that repeating gradients should be replaced with the average color in these situations, but the layout test currently displays the last color stop. The Skia CL linked below updates gradient rendering to be correct in this situation.

Skia CL https://skia-review.googlesource.com/c/skia/+/168487 that requires the rebaseline.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad0f5062a489913325c0dd5eaf0ec38c53799d43

commit ad0f5062a489913325c0dd5eaf0ec38c53799d43
Author: Michael Ludwig <michaelludwig@google.com>
Date: Thu Nov 08 19:45:56 2018

Suppress layout test for Skia roll

Bug:  903289 
Change-Id: Ibc84f1083d0cb121435418fcda226b16917d1b87
Reviewed-on: https://chromium-review.googlesource.com/c/1327223
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606571}
[modify] https://crrev.com/ad0f5062a489913325c0dd5eaf0ec38c53799d43/third_party/WebKit/LayoutTests/TestExpectations

Status: Closed (was: Assigned)

Sign in to add a comment