New issue
Advanced search Search tips

Issue 903257 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 19
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Split string in generation infobar

Project Member Reported by ioanap@chromium.org, Nov 8

Issue description

The current text is displayed as the sole message of the infobar. Part of it can be separated and displayed as a title.

 
Screenshot
GenerationInfobarStringSplitCropped.png
48.0 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b10a7b7f341550180c7d7a735e55f8443e6ca348

commit b10a7b7f341550180c7d7a735e55f8443e6ca348
Author: Ioana Pandele <ioanap@chromium.org>
Date: Mon Nov 19 10:03:43 2018

Split string in the generation infobar

This change separates the current text of the infobar into title and
body. The latter contains a link pointing to where the
user can find the saved generated password.

Screenshot on the bug.
Bug:  903257 

Change-Id: Iadbfb68298b338d990c4be0b0ab3d11007b4b125
Reviewed-on: https://chromium-review.googlesource.com/c/1156586
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609223}
[modify] https://crrev.com/b10a7b7f341550180c7d7a735e55f8443e6ca348/chrome/android/java/src/org/chromium/chrome/browser/infobar/GeneratedPasswordSavedInfoBar.java
[modify] https://crrev.com/b10a7b7f341550180c7d7a735e55f8443e6ca348/chrome/android/java/src/org/chromium/chrome/browser/infobar/GeneratedPasswordSavedInfoBarDelegate.java
[modify] https://crrev.com/b10a7b7f341550180c7d7a735e55f8443e6ca348/chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.cc
[modify] https://crrev.com/b10a7b7f341550180c7d7a735e55f8443e6ca348/chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.h
[modify] https://crrev.com/b10a7b7f341550180c7d7a735e55f8443e6ca348/chrome/browser/ui/android/infobars/generated_password_saved_infobar.cc

Status: Fixed (was: Started)

Sign in to add a comment