Non-Regression : Unnecessarily 'Select all' option is seen enabled even after selecting it in Files App |
||||
Issue description
Chrome Version: 71.0.3578.39/ 11151.23.0 beta-channel Daisy,Kip and Reks
OS: Chrome
What steps will reproduce the problem?
(1)Sign into User -> press 'Ctrl+F5(Overview Mode Button)' for screenshot -> go to Files App
(2)Now click on three dot menu('More..') -> select 'Select all' option -> observe screenshot will be selected(we can observe 'Open' & 'Delete' options) but no tick mark is seen
(3)Now again click on three dot menu('More..') -> observe still 'Select all' option is seen enabled
(Please refer Video)
Expected: 'Select all' option should be seen disabled after selecting it
Actual: Instead 'Select all' option is seen enabled
This is Non-Regression Issue seen from M-67
,
Nov 8
,
Nov 20
,
Nov 20
The difference for the 2 scenarios shown is that in the first, we have only a single file, and selecting all does not enter checkselect mode. In the second scenario, we have 2 or more files which enters checkselect mode for 'select all'. I have modified select all to always enter checkselect mode even if only a single file is selected.
,
Nov 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/baeb280208fbe8fca3a36e12522f432a5a410155 commit baeb280208fbe8fca3a36e12522f432a5a410155 Author: Joel Hockey <joelhockey@chromium.org> Date: Tue Nov 20 08:47:30 2018 FilesApp: enter check select mode for select-all files Currently we only enter check select mode if 2 or more files are selected as part of select-all. This is now changed so that we always enter check select mode even if only a single file is selected. Bug: 903253 Change-Id: I15d05ea19570d7c83cfd77f20afa1370301b8b2a Reviewed-on: https://chromium-review.googlesource.com/c/1343586 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#609630} [modify] https://crrev.com/baeb280208fbe8fca3a36e12522f432a5a410155/ui/file_manager/file_manager/foreground/js/file_manager_commands.js [modify] https://crrev.com/baeb280208fbe8fca3a36e12522f432a5a410155/ui/file_manager/file_manager/foreground/js/ui/file_table_list.js [modify] https://crrev.com/baeb280208fbe8fca3a36e12522f432a5a410155/ui/file_manager/file_manager/test/check_select.js
,
Nov 20
|
||||
►
Sign in to add a comment |
||||
Comment 1 by weifangsun@chromium.org
, Nov 8Status: Available (was: Untriaged)