Background Fetches from non-top level frames should start paused |
||||||||
Issue descriptionAfter a discussion with a privacy team, they recommended starting fetches in a paused state if it was initiated from a non top level frame (e.g child frame or service worker).
,
Nov 8
Requesting merge into 71 to include some simple changes the privacy team suggested
,
Nov 8
Pls apply appropriate OSs label.
,
Nov 8
,
Nov 8
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 8
Pls update bug with canary result tomorrow. If change looks good in canary, will approve the merge to M71.
,
Nov 9
The NextAction date has arrived: 2018-11-09
,
Nov 9
Just confirmed this works as expected on canary w/the change
,
Nov 9
Approving merge to M71 branch 3578 based on comment #2 & #8. Please merge ASAP.
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c729f27449d5a8d06a9cd83e4049805a543aab3 commit 9c729f27449d5a8d06a9cd83e4049805a543aab3 Author: Rayan Kanso <rayankans@google.com> Date: Fri Nov 09 17:01:11 2018 [Background Fetch] Background initiations start in a paused state. Fetches started from non top level frames should begin in a paused state, even if the permission is granted. Bug: 903248 Change-Id: Ia8583b23735fa865089979c0159259142225cd30 Reviewed-on: https://chromium-review.googlesource.com/c/1326148 Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#606498}(cherry picked from commit 298645b782fe8d0feef9628a9fc049c31d0e2c39) Reviewed-on: https://chromium-review.googlesource.com/c/1329663 Reviewed-by: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#614} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/9c729f27449d5a8d06a9cd83e4049805a543aab3/chrome/browser/background_fetch/background_fetch_browsertest.cc [modify] https://crrev.com/9c729f27449d5a8d06a9cd83e4049805a543aab3/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c729f27449d5a8d06a9cd83e4049805a543aab3 Commit: 9c729f27449d5a8d06a9cd83e4049805a543aab3 Author: rayankans@google.com Commiter: rayankans@chromium.org Date: 2018-11-09 17:01:11 +0000 UTC [Background Fetch] Background initiations start in a paused state. Fetches started from non top level frames should begin in a paused state, even if the permission is granted. Bug: 903248 Change-Id: Ia8583b23735fa865089979c0159259142225cd30 Reviewed-on: https://chromium-review.googlesource.com/c/1326148 Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#606498}(cherry picked from commit 298645b782fe8d0feef9628a9fc049c31d0e2c39) Reviewed-on: https://chromium-review.googlesource.com/c/1329663 Reviewed-by: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#614} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23f757f3cdd338f7f72b0db74a0a7e308ab36fd9 commit 23f757f3cdd338f7f72b0db74a0a7e308ab36fd9 Author: Mugdha Lakhani <nator@chromium.org> Date: Fri Nov 16 13:49:02 2018 [Background Fetch] Start-then-pause --> Start-paused. Start a background fetch in a paused state whenever appropriate instead of starting and then pausing on the first update. This is now possible after the following change went in: https://chromium-review.googlesource.com/c/chromium/src/+/1265556 Bug: 903248 Change-Id: I55f613de9f7ebf36ec3daa971067e8cd34d44bed Reviewed-on: https://chromium-review.googlesource.com/c/1337627 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#608755} [modify] https://crrev.com/23f757f3cdd338f7f72b0db74a0a7e308ab36fd9/chrome/browser/background_fetch/background_fetch_browsertest.cc [modify] https://crrev.com/23f757f3cdd338f7f72b0db74a0a7e308ab36fd9/chrome/browser/background_fetch/background_fetch_delegate_impl.cc |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Nov 8