Issue metadata
Sign in to add a comment
|
Toolbar not hiding in Full Screen |
||||||||||||||||||||||
Issue descriptionApp Version: 72.0.3605.0 canary iOS Version: 11.4.1, 12.0.1 Devices: iPads only(iPad Air, iPad Pro) Steps to reproduce: 1. Launch iOS Chrome 2. Navigate to any website 3. Wait for the page to finish loading 4. Scroll the page up Observed results: Toolbar not hiding in full screen Note: Issue is reproducible even on enabling #browser-container-fullscreen & #out-of-web-fullscreen from chrome://flags Expected results: Page should enter FS and toolbar should hide Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on the current stable build :M70, No Bug reproducible on the current beta channel build : M71, No Type-bug-regression? Yes Revision Number for 72.0.3603.0 (Good Version) - 5edf276f371d Revision Number for 72.0.3604.0 (Bad Version) - fe3741e1a9b3 Link to Image/Video: https://drive.google.com/file/d/1zlC6qYzI6nPuHlwSO6rD0WPWYJiBigUS/view?usp=sharing
,
Nov 8
This is happening because the header height is incorrect after crrev.com/c/1286651. Working on a fix now. Good news is that this isn't due to iOS12.1, so there's less risk in updating M71 to compile with that SDK.
,
Nov 9
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6a1800461757b65a56c1ad613f11f57506452ff commit d6a1800461757b65a56c1ad613f11f57506452ff Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Tue Nov 13 18:57:37 2018 [iOS] Fix |-expandedTopToolbarHeight|. CGRectGetMaxY() changes as the toolbars are translated, causing issues when it is called from |-updateForFullscreenProgress:|. This CL updates the implementation to be based on the heights, rather than the frames. Bug: 903229 Change-Id: Ice018324f426104467f80c21544435c612b3455f Reviewed-on: https://chromium-review.googlesource.com/c/1328143 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#607681} [modify] https://crrev.com/d6a1800461757b65a56c1ad613f11f57506452ff/ios/chrome/browser/ui/browser_view_controller.mm
,
Nov 13
,
Nov 21
Verified in Build Version: 72.0.3617.0 Canary Devices: iPad 2018(iOS 11.4.1), iPad Pro (iOS 12.0.1) On scrolling up tool bar hides and page goes to fullscreen, looks good. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kkhorimoto@chromium.org
, Nov 8Labels: -Restrict-View-Google ReleaseBlock-Stable M-72
Owner: kkhorimoto@chromium.org
Status: Assigned (was: Untriaged)