Issue metadata
Sign in to add a comment
|
4.5%-7% regression in rasterize_and_record_micro.top_25 at 605315:605345 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Nov 8
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16328293e40000
,
Nov 8
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/16328293e40000 Reland "rebaseline SK_LEGACY_OP_COLOR_AS_BYTES" by mtklein@chromium.org https://chromium.googlesource.com/chromium/src/+/eb4c8c2d76e36f0df5f7e5ad64baeb5656d9198b rasterize_time: 2.345 → 2.502 (+0.1569) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: None
,
Nov 8
The following revision refers to this bug: https://skia.googlesource.com/skia/+/389528d8d8336c174632f24c948459fb1b074a0a commit 389528d8d8336c174632f24c948459fb1b074a0a Author: Mike Klein <mtklein@google.com> Date: Thu Nov 08 18:48:40 2018 streamline memset cases in SkRasterPipelineBlitter The attached Chromium bug got me looking at profiles of .skps that render very quickly, mostly with memset, and I noticed a few little microoptimizations to make. This prebakes a bit more of the blitter memset logic, trimming redundant calls to SkImageInfo::shiftPerPixel(). This also reduces the number of lookups of the various SkOpts::memsetNN function pointers from being once per row to once per rectangle being memset. Bug: chromium:903195 Change-Id: Ifdee266ecd28be6266ea640fec754399035f083e Reviewed-on: https://skia-review.googlesource.com/c/169681 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@google.com> [modify] https://crrev.com/389528d8d8336c174632f24c948459fb1b074a0a/src/core/SkRasterPipelineBlitter.cpp
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b28daf60b606c63e1314bc8425b687d01d7dd0e commit 7b28daf60b606c63e1314bc8425b687d01d7dd0e Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Nov 09 03:21:31 2018 Roll src/third_party/skia 06a477c3300d..df3a6eee1315 (14 commits) https://skia.googlesource.com/skia.git/+log/06a477c3300d..df3a6eee1315 git log 06a477c3300d..df3a6eee1315 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 kjlubick@google.com Add JSFiddle to cloudbuild 2018-11-08 reed@google.com remove obsolete guards for hinting enum 2018-11-08 mtklein@google.com there's no point moving a const sk_sp 2018-11-08 mtklein@google.com disable unit tests in Google3 2018-11-08 jvanverth@google.com Construct mipmaps for internal YUVA planes 2018-11-08 fmalita@chromium.org [skottie] Add skottie_tool srcs/includes to public.bzl 2018-11-08 herb@google.com Move (re)generation of the GrTextBlob from GrTextContext to the blob 2018-11-08 egdaniel@google.com Have a GrBackendFormat be stored on gpu proxies. 2018-11-08 caryclark@skia.org fix bookmaker 2018-11-08 fmalita@chromium.org Fix LinearGradient4fContext::shadeSpanInternal fuzz 2018-11-08 mtklein@google.com streamline memset cases in SkRasterPipelineBlitter 2018-11-08 nigeltao@google.com Have SkWuffsCodec use a SkSwizzler 2018-11-08 nigeltao@google.com Add comment about how to run Decoder benchmarks 2018-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 905ee08219fa..d856ca48f425 (2 commits) Created with: gclient setdep -r src/third_party/skia@df3a6eee1315 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG= chromium:903195 TBR=allanmac@chromium.org Change-Id: Ifa15e1b0dca4a0204e1ec004138516f9240c1823 Reviewed-on: https://chromium-review.googlesource.com/c/1327469 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606721} [modify] https://crrev.com/7b28daf60b606c63e1314bc8425b687d01d7dd0e/DEPS
,
Jan 7
This was an intentional small absolute regression on things that are already fast. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Nov 8