Issue metadata
Sign in to add a comment
|
6%-14% regression in system_health.memory_desktop at 599160:599488 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Nov 8
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12e92f0de40000
,
Nov 8
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/12e92f0de40000 Bind canvas color management to GPU compositing by zakerinasab@chromium.org https://chromium.googlesource.com/chromium/src/+/37aab329373b49a9753c0481e22c192f21861edd memory:chrome:all_processes:reported_by_chrome:gpu:effective_size: 7.896e+07 → 8.001e+07 (+1.043e+06) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: https://bit.ly/system-health-benchmarks
,
Nov 8
I don't think this CL can make any regression in memory usage. It merely puts an unshipped feature behind an extra flag.
,
Nov 9
I agree.
,
Nov 12
No, please don't just close perf regression bugs like this. Lets rerun the bisect and see if what the bots find. Besides changing the pixel format /does/ sounds like a way to affect memory to me.
,
Nov 12
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/128647cfe40000
,
Nov 12
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/128647cfe40000 Bind canvas color management to GPU compositing by zakerinasab@chromium.org https://chromium.googlesource.com/chromium/src/+/37aab329373b49a9753c0481e22c192f21861edd memory:chrome:all_processes:reported_by_chrome:gpu:effective_size: 1.31e+07 → 1.381e+07 (+7.056e+05) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: https://bit.ly/system-health-benchmarks
,
Nov 13
The bots think your patch regressed memory by up to 14% which is quite a bit. Please justify this increase or consider reverting.
,
Nov 14
,
Nov 14
Reverting the original change at: https://chromium-review.googlesource.com/c/chromium/src/+/1336079
,
Nov 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71ad9d982ba44c7bee89f616b481bbda3c47a3bf commit 71ad9d982ba44c7bee89f616b481bbda3c47a3bf Author: Fernando Serboncini <fserb@chromium.org> Date: Wed Nov 14 19:31:12 2018 Remove IsGpuCompositingEnabled from CRC creation TBR=zakerinasab@chromium.org Bug: 903101 ,840371 Change-Id: I855ea360aefab4aae00b991f1000fa55e3f49935 Reviewed-on: https://chromium-review.googlesource.com/c/1336079 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#608080} [modify] https://crrev.com/71ad9d982ba44c7bee89f616b481bbda3c47a3bf/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc
,
Nov 14
Closing this and following up on the original bug. Thanks for playing. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Nov 8