New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 903101 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

6%-14% regression in system_health.memory_desktop at 599160:599488

Project Member Reported by alexclarke@chromium.org, Nov 8

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=903101

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=8a9ac7dd5a1812ed76f7f9148f907c19597bdb9703ec290f841c47dfdec36ffe


Bot(s) for this bug's original alert(s):

Win 7 Nvidia GPU Perf
mac-10_12_laptop_low_end-perf
mac-10_13_laptop_high_end-perf

system_health.memory_desktop - Benchmark documentation link:
  https://bit.ly/system-health-benchmarks
Cc: zakerinasab@chromium.org
Owner: zakerinasab@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12e92f0de40000

Bind canvas color management to GPU compositing by zakerinasab@chromium.org
https://chromium.googlesource.com/chromium/src/+/37aab329373b49a9753c0481e22c192f21861edd
memory:chrome:all_processes:reported_by_chrome:gpu:effective_size: 7.896e+07 → 8.001e+07 (+1.043e+06)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/system-health-benchmarks
Cc: fs...@chromium.org
Owner: ----
Status: Available (was: Assigned)
I don't think this CL can make any regression in memory usage. It merely puts an unshipped feature behind an extra flag.
Status: WontFix (was: Available)
I agree.
Status: Unconfirmed (was: WontFix)
No, please don't just close perf regression bugs like this.  Lets rerun the bisect and see if what the bots find.

Besides changing the pixel format /does/ sounds like a way to affect memory to me.
Owner: zakerinasab@chromium.org
Status: Assigned (was: Unconfirmed)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/128647cfe40000

Bind canvas color management to GPU compositing by zakerinasab@chromium.org
https://chromium.googlesource.com/chromium/src/+/37aab329373b49a9753c0481e22c192f21861edd
memory:chrome:all_processes:reported_by_chrome:gpu:effective_size: 1.31e+07 → 1.381e+07 (+7.056e+05)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/system-health-benchmarks
The bots think your patch regressed memory by up to 14% which is quite a bit.  Please justify this increase or consider reverting.
Components: Blink>Canvas
Owner: fs...@chromium.org
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71ad9d982ba44c7bee89f616b481bbda3c47a3bf

commit 71ad9d982ba44c7bee89f616b481bbda3c47a3bf
Author: Fernando Serboncini <fserb@chromium.org>
Date: Wed Nov 14 19:31:12 2018

Remove IsGpuCompositingEnabled from CRC creation



TBR=zakerinasab@chromium.org

Bug:  903101 ,840371
Change-Id: I855ea360aefab4aae00b991f1000fa55e3f49935
Reviewed-on: https://chromium-review.googlesource.com/c/1336079
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608080}
[modify] https://crrev.com/71ad9d982ba44c7bee89f616b481bbda3c47a3bf/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc

Status: Fixed (was: Assigned)
Closing this and following up on the original bug. Thanks for playing.

Sign in to add a comment