New issue
Advanced search Search tips

Issue 903091 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocked on:
issue 914405



Sign in to add a comment

Regression: 'Sign in' button of 'Google Chrome Help' window doesn't work

Reported by khushal....@etouch.net, Nov 8

Issue description

Chrome Version: 72.0.3605.0 (Official Build) Revision 7a592c61308c0774ad0ccbb799496d2c47020ca9-refs/branch-heads/3605@{#1} (32/64-bit)

OS: Mac (10.13.1, 10.13.6, 10.14.2), Windows (7, 8, 8.1, 10) and Linux (14.04 LTS)

What steps will reproduce the problem?
(1) Launch chrome and click on wrench menu.
(2) Click on 'Help' option and then click 'Report an issue..' (overlay will open).
(3) Type anything in the message box and click 'Send' button ('Google Chrome Help' window will open).
(4) Now click on 'Sign in' button on 'Google Chrome Help' window and Observe.

Actual Result: 'Sign in' button of 'Google Chrome Help' window doesn't work.

Expected Result: 'Sign in' button of 'Google Chrome Help' window should open Sign in page.

This is a Regression issue seen from 'M-72' and will provide the bisect info soon:
Good Build: 72.0.3603.0 (Revision: 605533)
Bad Build:  72.0.3604.0 (Revision: 605912)

Please refer the attached screen-cast.

Thank You..!!
 
Actual Video.mp4
850 KB View Download
Expected Video.mp4
747 KB View Download
Owner: afakhry@chromium.org
Status: Assigned (was: Unconfirmed)
Update:

[Unable to provide bisect using 1) Per-revision script as "RuntimeError: We don't have enough builds to bisect" error message is thrown and
				2) Chromium bisect script as 'Report an issue...' option is not available.
Hence, providing suspect manually.)

CHANGE-LOG URL:

https://chromium.googlesource.com/chromium/src/+log/72.0.3603.0..72.0.3604.0?pretty=fuller&n=10000

Suspecting: r605822 ?

@afakhry: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You..!!
Cc: r...@chromium.org xiy...@chromium.org antrim@chromium.org
+xiyuan@ +rkc@  +antrim@ why sign in doesn't work in an app window here? Is sign in in this landing page important?
Do you get any console error messages?

Not sure what the "Signin" button does, it might try to navigate to Gaia and get blocked inside an app window. I suspect we reach AppWebContentsHelper::OpenURLFromTab [1]. 

It is kind of WAI as we want to limit the ability of feedback app to open a tab. And I don't think this sign-in in help page is important. If we have to support it, we could create a wrapper page in the app window and host the url inside a <webview>, which allows navigation.

[1] https://cs.chromium.org/chromium/src/extensions/browser/app_window/app_web_contents_helper.cc?rcl=7739d6437b6ade5f290cfe3f195e69faccf7d3c6&l=51
The error seen at the console is:

Can't open same-window link to "https://accounts.google.com/ServiceLogin?hl=en&passive=true&continue=http://support.google.com/chromebook/answer/3142217%3Fvisit_id%3D636772957737114635-2404874354%26p%3Dfeedback_confirmation%26rd%3D1"; try target="_blank".


Which matches what AppWebContentsHelper::OpenURLFromTab() gives as you linked above.
Blockedon: 914405
Status: Fixed (was: Assigned)

Sign in to add a comment