Unable to save the edited URL on chrome://extensions
Reported by
aiman.an...@etouch.net,
Nov 8
|
|||||||||||
Issue descriptionChrome Version: 72.0.3605.0 (Official Build)7a592c61308c0774ad0ccbb799496d2c47020ca9-refs/branch-heads/3605@{#1}(32/64 Bit). OS: Win(7,8,8.1,10), Linux(14.04 LTS) and Mac(10.13.1,10.13.6, 10.14.2). Pre-Condition: Install extension from https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacbdfmadadm?hl=en Steps to reproduce: 1. Open chrome, Right click on extension icon in omnibox and select 'Manage Extension' 2. On manage extension page select 'On Specific Site' from drop-down under Permission. 3. Enter a valid URL and Save it. (Eg: www.google.com) 4. Choose Edit option from 3-dot edit icon for the entered URL. 5. Edit the URL to www.yahoo.com and try clicking on Save button. 6. Observe. Actual Result: Unable to save the edited URL. Expected Result: Should be able to save URL after editing. This is Non-regression issue seen from M-72 build #72.0.3601.0, since this new feature was introduced for extensions. Kindly refer the attached screen-cast for reference. Thank You!
,
Nov 8
,
Nov 8
,
Nov 8
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b43be7284f24120c08e5cb0a3eaeacadebbc2bdf commit b43be7284f24120c08e5cb0a3eaeacadebbc2bdf Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Nov 13 02:34:21 2018 [Extensions Click-to-Script] Fix edit host permission bug Fix a bug where clicking "edit" on a host permission directly after switching to "on specific sites" would fail. This was because we weren't clearing the oldHostAccess_ bit in runtime_host_permissions.js, which then transferred through to the runtime_hosts_dialog. When this is set, editing is forbidden. Properly clear the bit on dialog close, and add a test for the same. Bug: 903082 Change-Id: I2c5c610fe9c9819f749cf4bd112266bd537c0f31 Reviewed-on: https://chromium-review.googlesource.com/c/1327467 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607452} [modify] https://crrev.com/b43be7284f24120c08e5cb0a3eaeacadebbc2bdf/chrome/browser/resources/md_extensions/runtime_host_permissions.js [modify] https://crrev.com/b43be7284f24120c08e5cb0a3eaeacadebbc2bdf/chrome/test/data/webui/extensions/runtime_host_permissions_test.js
,
Nov 13
This should be fixed. We'll likely want to merge this to M71, where users in the finch experiment are also affected. I'll request a merge once I've verified the fix on Canary.
,
Nov 15
The NextAction date has arrived: 2018-11-15
,
Nov 16
No issues seen on the latest canary, and verified that it's WAI there. The change is very small (one line to non-test code), and should be very safe to merge. Requesting merge to M71.
,
Nov 16
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 16
Approving merge to M71 branch 3578 based on comment #8. Please merge ASAP. Thank you.
,
Nov 16
Thanks! Will merge tomorrow AM.
,
Nov 16
The NextAction date has arrived: 2018-11-16
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fae9b8df46a4307b478e69355b5d626c90beebba commit fae9b8df46a4307b478e69355b5d626c90beebba Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Nov 16 19:32:22 2018 [Merge M71][Extensions Click-to-Script] Fix edit host permission bug Fix a bug where clicking "edit" on a host permission directly after switching to "on specific sites" would fail. This was because we weren't clearing the oldHostAccess_ bit in runtime_host_permissions.js, which then transferred through to the runtime_hosts_dialog. When this is set, editing is forbidden. Properly clear the bit on dialog close, and add a test for the same. Bug: 903082 TBR=rdevlin.cronin@chromium.org (cherry picked from commit b43be7284f24120c08e5cb0a3eaeacadebbc2bdf) Change-Id: I2c5c610fe9c9819f749cf4bd112266bd537c0f31 Reviewed-on: https://chromium-review.googlesource.com/c/1327467 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#607452} Reviewed-on: https://chromium-review.googlesource.com/c/1340861 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#735} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/fae9b8df46a4307b478e69355b5d626c90beebba/chrome/browser/resources/md_extensions/runtime_host_permissions.js [modify] https://crrev.com/fae9b8df46a4307b478e69355b5d626c90beebba/chrome/test/data/webui/extensions/runtime_host_permissions_test.js
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fae9b8df46a4307b478e69355b5d626c90beebba Commit: fae9b8df46a4307b478e69355b5d626c90beebba Author: rdevlin.cronin@chromium.org Commiter: rdevlin.cronin@chromium.org Date: 2018-11-16 19:32:22 +0000 UTC [Merge M71][Extensions Click-to-Script] Fix edit host permission bug Fix a bug where clicking "edit" on a host permission directly after switching to "on specific sites" would fail. This was because we weren't clearing the oldHostAccess_ bit in runtime_host_permissions.js, which then transferred through to the runtime_hosts_dialog. When this is set, editing is forbidden. Properly clear the bit on dialog close, and add a test for the same. Bug: 903082 TBR=rdevlin.cronin@chromium.org (cherry picked from commit b43be7284f24120c08e5cb0a3eaeacadebbc2bdf) Change-Id: I2c5c610fe9c9819f749cf4bd112266bd537c0f31 Reviewed-on: https://chromium-review.googlesource.com/c/1327467 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#607452} Reviewed-on: https://chromium-review.googlesource.com/c/1340861 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#735} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by nyerramilli@chromium.org
, Nov 8