[soundwave] Switch to luci-auth for authentication of requests |
||
Issue descriptionIt appears that luci-auth is the infra supported way to get access tokens to authenticate requests, and available for all developers via devtools. In particular, switching to it will allow us to drop the dependency to oauth2client.tools, which currently users need to install themselves in order to use soundwave or pinpoint_cli. Also it avoids caching user credentials in yet another place which may not be entirely transparent to the user.
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/0c33d62e0821dd7dad5e17861931fbed4658d341 commit 0c33d62e0821dd7dad5e17861931fbed4658d341 Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Fri Nov 16 09:32:17 2018 [soundwave] Switch pinpoint_service to luci-auth for authentication Add a services.luci_auth module to get access tokens and information about the logged in user. Also start migrating pinpoint_service to use this new module, other services will also come in follow up CLs. Bug: chromium:903026 Change-Id: Iee4b108123959c01df9ea2fec3d3ec0aa06b504c Reviewed-on: https://chromium-review.googlesource.com/c/1324674 Reviewed-by: Ben Hayden <benjhayden@chromium.org> Reviewed-by: Dave Tu <dtu@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/0c33d62e0821dd7dad5e17861931fbed4658d341/experimental/soundwave/services/pinpoint_service_test.py [modify] https://crrev.com/0c33d62e0821dd7dad5e17861931fbed4658d341/experimental/soundwave/pinpoint_cli/commands.py [add] https://crrev.com/0c33d62e0821dd7dad5e17861931fbed4658d341/experimental/soundwave/services/luci_auth.py [modify] https://crrev.com/0c33d62e0821dd7dad5e17861931fbed4658d341/experimental/soundwave/services/pinpoint_service.py [modify] https://crrev.com/0c33d62e0821dd7dad5e17861931fbed4658d341/experimental/soundwave/bin/pinpoint_cli [modify] https://crrev.com/0c33d62e0821dd7dad5e17861931fbed4658d341/experimental/soundwave/services/user_services.py [modify] https://crrev.com/0c33d62e0821dd7dad5e17861931fbed4658d341/experimental/soundwave/services/request.py [add] https://crrev.com/0c33d62e0821dd7dad5e17861931fbed4658d341/experimental/soundwave/services/luci_auth_test.py [modify] https://crrev.com/0c33d62e0821dd7dad5e17861931fbed4658d341/experimental/soundwave/services/request_test.py
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/a74114b3643c4f12f6258856db99f5c5edb448d6 commit a74114b3643c4f12f6258856db99f5c5edb448d6 Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Fri Nov 16 10:02:53 2018 [soundwave] Migrate dashboard_services to luci_auth Migrate authorization backend for dashboard requests to luci_auth, this allows to break away from the dependency of oauth2client.tools, relying instead of luci_auth already available to all developers via depot tools. Bug: chromium:903026 Change-Id: Id23ceb7852b239002d09b217ff36d5ba8145c5d8 Reviewed-on: https://chromium-review.googlesource.com/c/1331428 Reviewed-by: Ben Hayden <benjhayden@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/a74114b3643c4f12f6258856db99f5c5edb448d6/experimental/soundwave/services/dashboard_service.py [modify] https://crrev.com/a74114b3643c4f12f6258856db99f5c5edb448d6/experimental/soundwave/soundwave/studies/health_study.py [modify] https://crrev.com/a74114b3643c4f12f6258856db99f5c5edb448d6/experimental/soundwave/services/dashboard_service_test.py [modify] https://crrev.com/a74114b3643c4f12f6258856db99f5c5edb448d6/experimental/soundwave/soundwave/studies/v8_study.py [modify] https://crrev.com/a74114b3643c4f12f6258856db99f5c5edb448d6/experimental/soundwave/bin/soundwave [modify] https://crrev.com/a74114b3643c4f12f6258856db99f5c5edb448d6/experimental/soundwave/services/user_services.py [modify] https://crrev.com/a74114b3643c4f12f6258856db99f5c5edb448d6/experimental/soundwave/soundwave/commands.py [modify] https://crrev.com/a74114b3643c4f12f6258856db99f5c5edb448d6/experimental/soundwave/soundwave/dashboard_api.py [modify] https://crrev.com/a74114b3643c4f12f6258856db99f5c5edb448d6/experimental/soundwave/soundwave/dashboard_api_test.py
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/287859cde3daa6b3af692d2026d989a8bf0d87f8 commit 287859cde3daa6b3af692d2026d989a8bf0d87f8 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Nov 16 11:20:46 2018 Roll src/third_party/catapult 95ac6f04a8f7..0c33d62e0821 (1 commits) https://chromium.googlesource.com/catapult.git/+log/95ac6f04a8f7..0c33d62e0821 git log 95ac6f04a8f7..0c33d62e0821 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 perezju@chromium.org [soundwave] Switch pinpoint_service to luci-auth for authentication Created with: gclient setdep -r src/third_party/catapult@0c33d62e0821 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:903026 TBR=sullivan@chromium.org Change-Id: I131beb502b98d49048c9a7ac5ffbf17736513429 Reviewed-on: https://chromium-review.googlesource.com/c/1339482 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608727} [modify] https://crrev.com/287859cde3daa6b3af692d2026d989a8bf0d87f8/DEPS
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/899d2670e18b84787ac72a563f9b4c60c7b32e47 commit 899d2670e18b84787ac72a563f9b4c60c7b32e47 Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Fri Nov 16 11:25:48 2018 [soundwave] Migrate isolate_service to luci-auth Migrate isolate_service, the last remaining module, to use luci-auth. This also allows to break the dependency from oauth2client.tools and remove the now deprecated services.chrome_perf_auth module Bug: chromium:903026 Change-Id: I5f757a5e272170b196c37e06f26874654fa957f1 Reviewed-on: https://chromium-review.googlesource.com/c/1331429 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Ben Hayden <benjhayden@chromium.org> Reviewed-by: Dave Tu <dtu@chromium.org> [modify] https://crrev.com/899d2670e18b84787ac72a563f9b4c60c7b32e47/experimental/soundwave/pinpoint_cli/commands.py [modify] https://crrev.com/899d2670e18b84787ac72a563f9b4c60c7b32e47/experimental/soundwave/bin/pinpoint_cli [modify] https://crrev.com/899d2670e18b84787ac72a563f9b4c60c7b32e47/experimental/soundwave/services/isolate_service.py [modify] https://crrev.com/899d2670e18b84787ac72a563f9b4c60c7b32e47/experimental/soundwave/services/isolate_service_test.py [delete] https://crrev.com/b053faa13970ed6117c37fe02232026c72a07db7/experimental/soundwave/services/user_services.py [modify] https://crrev.com/899d2670e18b84787ac72a563f9b4c60c7b32e47/experimental/soundwave/services/__init__.py [modify] https://crrev.com/899d2670e18b84787ac72a563f9b4c60c7b32e47/experimental/soundwave/services/request.py [delete] https://crrev.com/b053faa13970ed6117c37fe02232026c72a07db7/experimental/soundwave/services/chrome_perf_auth.py
,
Nov 16
Done.
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee1eb7d38fd6d91239e5b5c8acd746add5100955 commit ee1eb7d38fd6d91239e5b5c8acd746add5100955 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Nov 16 12:55:19 2018 Roll src/third_party/catapult 0c33d62e0821..b053faa13970 (3 commits) https://chromium.googlesource.com/catapult.git/+log/0c33d62e0821..b053faa13970 git log 0c33d62e0821..b053faa13970 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 dtu@chromium.org [pinpoint] Show chart even if the job failed. 2018-11-16 dtu@chromium.org [pinpoint] Fix CIPD / vpython arguments to Swarming. 2018-11-16 perezju@chromium.org [soundwave] Migrate dashboard_services to luci_auth Created with: gclient setdep -r src/third_party/catapult@b053faa13970 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:901630 ,chromium:905807, chromium:903026 TBR=sullivan@chromium.org Change-Id: I9aa456cfa9804629f7bc66b15091f6825fca4af7 Reviewed-on: https://chromium-review.googlesource.com/c/1340140 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608747} [modify] https://crrev.com/ee1eb7d38fd6d91239e5b5c8acd746add5100955/DEPS
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95012fbd344c3c333fc38f6338293b873150e77c commit 95012fbd344c3c333fc38f6338293b873150e77c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Nov 16 14:02:11 2018 Roll src/third_party/catapult b053faa13970..b81a9c76c982 (2 commits) https://chromium.googlesource.com/catapult.git/+log/b053faa13970..b81a9c76c982 git log b053faa13970..b81a9c76c982 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 perezju@chromium.org [soundwave] Run soundwave scripts using vpython 2018-11-16 perezju@chromium.org [soundwave] Migrate isolate_service to luci-auth Created with: gclient setdep -r src/third_party/catapult@b81a9c76c982 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:904441 , chromium:903026 TBR=sullivan@chromium.org Change-Id: I348fa92c0279d3a9eb309b221a3359b7f9bd991e Reviewed-on: https://chromium-review.googlesource.com/c/1340146 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608757} [modify] https://crrev.com/95012fbd344c3c333fc38f6338293b873150e77c/DEPS
,
Nov 23
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/17079a5cc1f27a2dc57558a0897666cac4a5bc64 commit 17079a5cc1f27a2dc57558a0897666cac4a5bc64 Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Fri Nov 23 17:43:56 2018 [soundwave] Cleanup .gitignore Soundwave no longer stores its own credentials. This file should not exist any more. TBR=benjhayden@chromium.org Bug: chromium:903026 Change-Id: I5af910f99ef157440149508879cecc103930f167 Reviewed-on: https://chromium-review.googlesource.com/c/1349362 Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/17079a5cc1f27a2dc57558a0897666cac4a5bc64/experimental/soundwave/.gitignore
,
Nov 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff2d93dd1d656a0c56b989a17ed6b122d40e2e89 commit ff2d93dd1d656a0c56b989a17ed6b122d40e2e89 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Nov 23 20:34:07 2018 Roll src/third_party/catapult 43e8ebcaf284..17079a5cc1f2 (1 commits) https://chromium.googlesource.com/catapult.git/+log/43e8ebcaf284..17079a5cc1f2 git log 43e8ebcaf284..17079a5cc1f2 --date=short --no-merges --format='%ad %ae %s' 2018-11-23 perezju@chromium.org [soundwave] Cleanup .gitignore Created with: gclient setdep -r src/third_party/catapult@17079a5cc1f2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:903026 TBR=sullivan@chromium.org Change-Id: I3c4ceeafde37f60af2a24df14e5ff926eeaa932f Reviewed-on: https://chromium-review.googlesource.com/c/1349440 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610664} [modify] https://crrev.com/ff2d93dd1d656a0c56b989a17ed6b122d40e2e89/DEPS |
||
►
Sign in to add a comment |
||
Comment 1 by perezju@chromium.org
, Nov 12