New issue
Advanced search Search tips

Issue 903025 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Add proxy-related tests for DeviceManagementService

Project Member Reported by emaxx@chromium.org, Nov 8

Issue description

Existing tests don't exercise non-trivial scenarios for the DeviceManagementService::OnURLLoaderComplete() method, which pulls data from SimpleURLLoader. Only OnURLLoaderCompleteInternal(), which is called from that method, is covered by a wider range of tests that includes proxy-related tests.

Perhaps the new test(s) could be added into device_management_service_browsertest.cc.
 
Feel free to rope me in if you need any advice on setting things up, from the network side of things.  chrome/browser/net/network_context_configuration_browsertest does have a couple proxy tests that work both with and without the network service, which may be useful.

Sign in to add a comment