Issue metadata
Sign in to add a comment
|
DialogClientViewTest.ButtonPosition is flaky |
||||||||||||||||||||||||
Issue descriptionDialogClientViewTest.ButtonPosition is flaky. Findit has detected 3 flake occurrences of this test within the past 24 hours. List of all flake occurrences can be found at: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyRwsSBUZsYWtlIjxjaHJvbWl1bUB2aWV3c191bml0dGVzdHNARGlhbG9nQ2xpZW50Vmlld1Rlc3QuQnV0dG9uUG9zaXRpb24M. Unless the culprit CL is found and reverted, please disable this test first within 30 minutes then find an appropriate owner. If the result above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%20for%20DialogClientViewTest.ButtonPosition&comment=Link%20to%20flake%20occurrences%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyRwsSBUZsYWtlIjxjaHJvbWl1bUB2aWV3c191bml0dGVzdHNARGlhbG9nQ2xpZW50Vmlld1Rlc3QuQnV0dG9uUG9zaXRpb24M Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77e3d644d7ba91fb1f6ade3358ac7f7b3d4f9455 commit 77e3d644d7ba91fb1f6ade3358ac7f7b3d4f9455 Author: Yoshifumi Inoue <yosin@chromium.org> Date: Thu Nov 08 04:21:11 2018 Mark DialogClientViewTest.ButtonPosition flaky on Mac This patch marks DialogClientViewTest.ButtonPosition flaky on Mac. TBR=bsep@chromium.org Bug: 903000 Change-Id: I7d533956e437c143e4d4030dd357553fd4caabf1 Reviewed-on: https://chromium-review.googlesource.com/c/1325592 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#606338} [modify] https://crrev.com/77e3d644d7ba91fb1f6ade3358ac7f7b3d4f9455/ui/views/window/dialog_client_view_unittest.cc
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/058dced8e702b63bf7698833aa07c30c4f80c58a commit 058dced8e702b63bf7698833aa07c30c4f80c58a Author: Yoshifumi Inoue <yosin@chromium.org> Date: Thu Nov 08 04:36:21 2018 Revert "Mark DialogClientViewTest.ButtonPosition flaky on Mac" This reverts commit 77e3d644d7ba91fb1f6ade3358ac7f7b3d4f9455. Reason for revert: he test flakiness is caused by bot flakiness. Original change's description: > Mark DialogClientViewTest.ButtonPosition flaky on Mac > > This patch marks DialogClientViewTest.ButtonPosition flaky on Mac. > > TBR=bsep@chromium.org > > Bug: 903000 > Change-Id: I7d533956e437c143e4d4030dd357553fd4caabf1 > Reviewed-on: https://chromium-review.googlesource.com/c/1325592 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606338} TBR=yosin@chromium.org Change-Id: Ib253d9870dcbae3ca12ccba6b7db76d0c34afd7e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 903000 Reviewed-on: https://chromium-review.googlesource.com/c/1325279 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#606345} [modify] https://crrev.com/058dced8e702b63bf7698833aa07c30c4f80c58a/ui/views/window/dialog_client_view_unittest.cc
,
Nov 8
Mark WontFix since test flakiness is caused by bot flakiness.
,
Nov 9
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12b69040140000
,
Nov 9
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/12b69040140000 AW: test cleartext setting by ntfschr@chromium.org https://chromium.googlesource.com/chromium/src/+/f32d36d240b226357752b06a7653a385c6b827c7 tasks_per_frame_total_all: 62.72 → 58.75 (-3.971) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: https://bit.ly/rendering-benchmarks |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by yosin@chromium.org
, Nov 8Labels: -Sheriff-Chromium
Owner: bsep@chromium.org
Status: Assigned (was: Untriaged)