New issue
Advanced search Search tips

Issue 902978 link

Starred by 3 users
Status: Fixed
Owner:
khmel@chromium.org
Closed: Jan 14
Cc:
maroun@chromium.org
khmel@chromium.org
sdantul...@chromium.org
mkarkada@chromium.org
menegola@chromium.org
dhadd...@chromium.org
zalcorn@chromium.org
michae...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

default YouTube TV app is available on child account

Project Member Reported by abod...@chromium.org, Nov 8 
Chrome OS 11151.23.0, 71.0.3578.39 Nocturne

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
(1)Login to unicorn account 
(2)Verify default apps list.
(3)

Expected Result:
Default apps list:

Calendar
Docs
Drive
GMail
Keep
Maps
Photos
Sheets
Slides

Actual Result:
Seen YouTube TV app by default on child account.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)

What is the impact to the user, and is there a workaround? If so, what is
it?

Please provide any additional information below. Attach a screen shot or
log if possible.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by abod...@chromium.org, Nov 8

Cc: khmel@chromium.org

Comment 2 by zalcorn@chromium.org, Nov 8 

Believe this is nocturne only as it's the only device with YTTV web app preloaded.
Yury, could you remove it as a default for child accounts?

Comment 3 by menegola@google.com, Nov 22

Owner: khmel@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by khmel@chromium.org, Nov 30 

Hmm, this might be not easy to do.
We can relatively easy remove this from client.
But this will silently installed by PAI.
We have some options to pass to PAI. Need investigate the possibility to exclude particular app.

Comment 5 by khmel@chromium.org, Nov 30

Labels: -M-71 M-72

Comment 6 by khmel@chromium.org, Dec 27

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb20c705394752beaa11cbe5d83a4ea1b761f8c6

commit bb20c705394752beaa11cbe5d83a4ea1b761f8c6
Author: khmel@chromium.org <khmel@chromium.org>
Date: Thu Jan 03 03:27:44 2019

Add default app separation based on user type.

This allows making default app customization based on user type. For
example make Youtube TV as default app on nocturne users only for
unmanaged apps.

This is implemeted similar to crrev.com/c/851338 that introduced the
same concept for crx default apps.

TEST=Locally (together with crrev.com/i/755690) + unit tests
BUG= 902978 

Change-Id: I78d5e3da4150d6d0e1f374261113d9cdfb80260a
Reviewed-on: https://chromium-review.googlesource.com/c/1391870
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619575}
[modify] https://crrev.com/bb20c705394752beaa11cbe5d83a4ea1b761f8c6/chrome/browser/web_applications/bookmark_apps/external_web_apps_unittest.cc
[modify] https://crrev.com/bb20c705394752beaa11cbe5d83a4ea1b761f8c6/chrome/browser/web_applications/external_web_apps.cc
[modify] https://crrev.com/bb20c705394752beaa11cbe5d83a4ea1b761f8c6/chrome/browser/web_applications/external_web_apps.h
[add] https://crrev.com/bb20c705394752beaa11cbe5d83a4ea1b761f8c6/chrome/test/data/web_app_default_apps/user_types/web_apps/app_unmanaged.json
[add] https://crrev.com/bb20c705394752beaa11cbe5d83a4ea1b761f8c6/chrome/test/data/web_app_default_apps/user_types/web_apps/child_users/app_child.json
[add] https://crrev.com/bb20c705394752beaa11cbe5d83a4ea1b761f8c6/chrome/test/data/web_app_default_apps/user_types/web_apps/managed_users/app_managed.json

Comment 9 by mwharris@google.com, Jan 7 

Please also remove the Showtime app, and make sure both are not installed on an enterprise device.

Comment 11 by khmel@chromium.org, Jan 8 

Issue 917208 has been merged into this issue.
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78ea7701ac7124543206708c6cf50f1eb4692ad4

commit 78ea7701ac7124543206708c6cf50f1eb4692ad4
Author: khmel@chromium.org <khmel@chromium.org>
Date: Tue Jan 08 17:24:31 2019

Default web apps, fix confusion supervised vs managed users.

This is follow-up of crrev.com/c/1391870. Managed and supervised are
different type of users. For this task we need managed users separation,
not supervised.

TEST=Locally + unit tests
BUG= 902978 

Change-Id: I310f02703c7507f4a6e992ca9088194a7b144cbc
Reviewed-on: https://chromium-review.googlesource.com/c/1400056
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620775}
[modify] https://crrev.com/78ea7701ac7124543206708c6cf50f1eb4692ad4/chrome/browser/web_applications/bookmark_apps/external_web_apps_unittest.cc
[modify] https://crrev.com/78ea7701ac7124543206708c6cf50f1eb4692ad4/chrome/browser/web_applications/external_web_apps.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db29a96e938ab285182c7da5c8b4bd4a9b3c3934

commit db29a96e938ab285182c7da5c8b4bd4a9b3c3934
Author: khmel@chromium.org <khmel@chromium.org>
Date: Wed Jan 09 18:15:38 2019

web_apps: Add json user type filter.

This is more robust solution than previous one, based one folder
separation. DD: https://goto.google.com/web_app_default.

TEST=Unit test + nocturne build and various user types.
BUG= 902978 

Change-Id: I2f7e17a22b724254400eec7deae75a9cc606e3f7
Reviewed-on: https://chromium-review.googlesource.com/c/1401508
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621223}
[modify] https://crrev.com/db29a96e938ab285182c7da5c8b4bd4a9b3c3934/chrome/browser/web_applications/bookmark_apps/external_web_apps_unittest.cc
[modify] https://crrev.com/db29a96e938ab285182c7da5c8b4bd4a9b3c3934/chrome/browser/web_applications/external_web_apps.cc
[modify] https://crrev.com/db29a96e938ab285182c7da5c8b4bd4a9b3c3934/chrome/test/data/web_app_default_apps/empty_app_url/chrome_platform_status.json
[modify] https://crrev.com/db29a96e938ab285182c7da5c8b4bd4a9b3c3934/chrome/test/data/web_app_default_apps/enabled_by_finch/chrome_platform_status.json
[modify] https://crrev.com/db29a96e938ab285182c7da5c8b4bd4a9b3c3934/chrome/test/data/web_app_default_apps/enabled_by_finch/google_search.json
[modify] https://crrev.com/db29a96e938ab285182c7da5c8b4bd4a9b3c3934/chrome/test/data/web_app_default_apps/good_json/chrome_platform_status.json
[modify] https://crrev.com/db29a96e938ab285182c7da5c8b4bd4a9b3c3934/chrome/test/data/web_app_default_apps/good_json/google_io_2016.json
[modify] https://crrev.com/db29a96e938ab285182c7da5c8b4bd4a9b3c3934/chrome/test/data/web_app_default_apps/invalid_launch_container/chrome_platform_status.json
[modify] https://crrev.com/db29a96e938ab285182c7da5c8b4bd4a9b3c3934/chrome/test/data/web_app_default_apps/missing_launch_container/chrome_platform_status.json
[modify] https://crrev.com/db29a96e938ab285182c7da5c8b4bd4a9b3c3934/chrome/test/data/web_app_default_apps/mixed_json/malformed1.json
[modify] https://crrev.com/db29a96e938ab285182c7da5c8b4bd4a9b3c3934/chrome/test/data/web_app_default_apps/mixed_json/polytimer.json
[add] https://crrev.com/db29a96e938ab285182c7da5c8b4bd4a9b3c3934/chrome/test/data/web_app_default_apps/user_types/web_apps/app_all.json
[add] https://crrev.com/db29a96e938ab285182c7da5c8b4bd4a9b3c3934/chrome/test/data/web_app_default_apps/user_types/web_apps/app_child.json
[add] https://crrev.com/db29a96e938ab285182c7da5c8b4bd4a9b3c3934/chrome/test/data/web_app_default_apps/user_types/web_apps/app_guest.json
[add] https://crrev.com/db29a96e938ab285182c7da5c8b4bd4a9b3c3934/chrome/test/data/web_app_default_apps/user_types/web_apps/app_managed.json
[add] https://crrev.com/db29a96e938ab285182c7da5c8b4bd4a9b3c3934/chrome/test/data/web_app_default_apps/user_types/web_apps/app_supervised.json
[modify] https://crrev.com/db29a96e938ab285182c7da5c8b4bd4a9b3c3934/chrome/test/data/web_app_default_apps/user_types/web_apps/app_unmanaged.json
[delete] https://crrev.com/caad2b29698e833626ff7e97dc11a1f31709b94c/chrome/test/data/web_app_default_apps/user_types/web_apps/child_users/app_child.json
[delete] https://crrev.com/caad2b29698e833626ff7e97dc11a1f31709b94c/chrome/test/data/web_app_default_apps/user_types/web_apps/managed_users/app_managed.json
[add] https://crrev.com/db29a96e938ab285182c7da5c8b4bd4a9b3c3934/chrome/test/data/web_app_default_apps/wrong_user_type/wrong_user_type.json

Comment 14 by khmel@chromium.org, Jan 9

Labels: Merge-Request-72
Requesting merge chain of CLs in Chrome and nocturne private overlay. Overall risk is quite low, biggest part comes to test.

Comment 15 by khmel@chromium.org, Jan 9

Labels: ReleaseBlock-Stable
Based on email conversations and other related bugs this should be release blocker.

Comment 16 by djmm@google.com, Jan 9

Labels: -Merge-Request-72 Merge-Approved-72
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 9

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57732b92925807b06f6745115af419ba21ffad24

commit 57732b92925807b06f6745115af419ba21ffad24
Author: khmel@chromium.org <khmel@chromium.org>
Date: Wed Jan 09 23:31:19 2019

[Merge M72] Add default app separation based on user type.

This allows making default app customization based on user type. For
example make Youtube TV as default app on nocturne users only for
unmanaged apps.

This is implemeted similar to crrev.com/c/851338 that introduced the
same concept for crx default apps.

TEST=Locally (together with crrev.com/i/755690) + unit tests
BUG= 902978 

Change-Id: I78d5e3da4150d6d0e1f374261113d9cdfb80260a
Reviewed-on: https://chromium-review.googlesource.com/c/1391870
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#619575}(cherry picked from commit bb20c705394752beaa11cbe5d83a4ea1b761f8c6)
Reviewed-on: https://chromium-review.googlesource.com/c/1404414
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#625}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/57732b92925807b06f6745115af419ba21ffad24/chrome/browser/web_applications/bookmark_apps/external_web_apps_unittest.cc
[modify] https://crrev.com/57732b92925807b06f6745115af419ba21ffad24/chrome/browser/web_applications/external_web_apps.cc
[modify] https://crrev.com/57732b92925807b06f6745115af419ba21ffad24/chrome/browser/web_applications/external_web_apps.h
[add] https://crrev.com/57732b92925807b06f6745115af419ba21ffad24/chrome/test/data/web_app_default_apps/user_types/web_apps/app_unmanaged.json
[add] https://crrev.com/57732b92925807b06f6745115af419ba21ffad24/chrome/test/data/web_app_default_apps/user_types/web_apps/child_users/app_child.json
[add] https://crrev.com/57732b92925807b06f6745115af419ba21ffad24/chrome/test/data/web_app_default_apps/user_types/web_apps/managed_users/app_managed.json
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e14f9bf0dd56897db0fd4f1c7d2fdbeed6ff8702

commit e14f9bf0dd56897db0fd4f1c7d2fdbeed6ff8702
Author: khmel@chromium.org <khmel@chromium.org>
Date: Wed Jan 09 23:33:11 2019

[Merge M72] Default web apps, fix confusion supervised vs managed users.

This is follow-up of crrev.com/c/1391870. Managed and supervised are
different type of users. For this task we need managed users separation,
not supervised.

TEST=Locally + unit tests
BUG= 902978 

Change-Id: I310f02703c7507f4a6e992ca9088194a7b144cbc
Reviewed-on: https://chromium-review.googlesource.com/c/1400056
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#620775}(cherry picked from commit 78ea7701ac7124543206708c6cf50f1eb4692ad4)
Reviewed-on: https://chromium-review.googlesource.com/c/1404415
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#626}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/e14f9bf0dd56897db0fd4f1c7d2fdbeed6ff8702/chrome/browser/web_applications/bookmark_apps/external_web_apps_unittest.cc
[modify] https://crrev.com/e14f9bf0dd56897db0fd4f1c7d2fdbeed6ff8702/chrome/browser/web_applications/external_web_apps.cc
Project Member

Comment 19 by cr-audit...@appspot.gserviceaccount.com, Jan 9

Labels: CommitLog-Audit-Violation Merge-Without-Approval
Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision 57732b92925807b06f6745115af419ba21ffad24 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required --
Project Member

Comment 20 by cr-audit...@appspot.gserviceaccount.com, Jan 9

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/57732b92925807b06f6745115af419ba21ffad24

Commit: 57732b92925807b06f6745115af419ba21ffad24
Author: khmel@chromium.org
Commiter: khmel@chromium.org
Date: 2019-01-09 23:31:19 +0000 UTC

[Merge M72] Add default app separation based on user type.

This allows making default app customization based on user type. For
example make Youtube TV as default app on nocturne users only for
unmanaged apps.

This is implemeted similar to crrev.com/c/851338 that introduced the
same concept for crx default apps.

TEST=Locally (together with crrev.com/i/755690) + unit tests
BUG= 902978 

Change-Id: I78d5e3da4150d6d0e1f374261113d9cdfb80260a
Reviewed-on: https://chromium-review.googlesource.com/c/1391870
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#619575}(cherry picked from commit bb20c705394752beaa11cbe5d83a4ea1b761f8c6)
Reviewed-on: https://chromium-review.googlesource.com/c/1404414
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#625}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
Project Member

Comment 21 by cr-audit...@appspot.gserviceaccount.com, Jan 9 

Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision e14f9bf0dd56897db0fd4f1c7d2fdbeed6ff8702 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required --
Project Member

Comment 22 by cr-audit...@appspot.gserviceaccount.com, Jan 9 

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/e14f9bf0dd56897db0fd4f1c7d2fdbeed6ff8702

Commit: e14f9bf0dd56897db0fd4f1c7d2fdbeed6ff8702
Author: khmel@chromium.org
Commiter: khmel@chromium.org
Date: 2019-01-09 23:33:11 +0000 UTC

[Merge M72] Default web apps, fix confusion supervised vs managed users.

This is follow-up of crrev.com/c/1391870. Managed and supervised are
different type of users. For this task we need managed users separation,
not supervised.

TEST=Locally + unit tests
BUG= 902978 

Change-Id: I310f02703c7507f4a6e992ca9088194a7b144cbc
Reviewed-on: https://chromium-review.googlesource.com/c/1400056
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#620775}(cherry picked from commit 78ea7701ac7124543206708c6cf50f1eb4692ad4)
Reviewed-on: https://chromium-review.googlesource.com/c/1404415
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#626}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
Project Member

Comment 23 by bugdroid1@chromium.org, Jan 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c33c79ba72956aacea756bf8c9b3f9e853e87584

commit c33c79ba72956aacea756bf8c9b3f9e853e87584
Author: khmel@chromium.org <khmel@chromium.org>
Date: Wed Jan 09 23:36:27 2019

[Merge M72] web_apps: Add json user type filter.

This is more robust solution than previous one, based one folder
separation. DD: https://goto.google.com/web_app_default.

TEST=Unit test + nocturne build and various user types.
BUG= 902978 

Change-Id: I2f7e17a22b724254400eec7deae75a9cc606e3f7
Reviewed-on: https://chromium-review.googlesource.com/c/1401508
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#621223}(cherry picked from commit db29a96e938ab285182c7da5c8b4bd4a9b3c3934)
Reviewed-on: https://chromium-review.googlesource.com/c/1404381
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#627}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/c33c79ba72956aacea756bf8c9b3f9e853e87584/chrome/browser/web_applications/bookmark_apps/external_web_apps_unittest.cc
[modify] https://crrev.com/c33c79ba72956aacea756bf8c9b3f9e853e87584/chrome/browser/web_applications/external_web_apps.cc
[modify] https://crrev.com/c33c79ba72956aacea756bf8c9b3f9e853e87584/chrome/test/data/web_app_default_apps/empty_app_url/chrome_platform_status.json
[modify] https://crrev.com/c33c79ba72956aacea756bf8c9b3f9e853e87584/chrome/test/data/web_app_default_apps/enabled_by_finch/chrome_platform_status.json
[modify] https://crrev.com/c33c79ba72956aacea756bf8c9b3f9e853e87584/chrome/test/data/web_app_default_apps/enabled_by_finch/google_search.json
[modify] https://crrev.com/c33c79ba72956aacea756bf8c9b3f9e853e87584/chrome/test/data/web_app_default_apps/good_json/chrome_platform_status.json
[modify] https://crrev.com/c33c79ba72956aacea756bf8c9b3f9e853e87584/chrome/test/data/web_app_default_apps/good_json/google_io_2016.json
[modify] https://crrev.com/c33c79ba72956aacea756bf8c9b3f9e853e87584/chrome/test/data/web_app_default_apps/invalid_launch_container/chrome_platform_status.json
[modify] https://crrev.com/c33c79ba72956aacea756bf8c9b3f9e853e87584/chrome/test/data/web_app_default_apps/missing_launch_container/chrome_platform_status.json
[modify] https://crrev.com/c33c79ba72956aacea756bf8c9b3f9e853e87584/chrome/test/data/web_app_default_apps/mixed_json/malformed1.json
[modify] https://crrev.com/c33c79ba72956aacea756bf8c9b3f9e853e87584/chrome/test/data/web_app_default_apps/mixed_json/polytimer.json
[add] https://crrev.com/c33c79ba72956aacea756bf8c9b3f9e853e87584/chrome/test/data/web_app_default_apps/user_types/web_apps/app_all.json
[add] https://crrev.com/c33c79ba72956aacea756bf8c9b3f9e853e87584/chrome/test/data/web_app_default_apps/user_types/web_apps/app_child.json
[add] https://crrev.com/c33c79ba72956aacea756bf8c9b3f9e853e87584/chrome/test/data/web_app_default_apps/user_types/web_apps/app_guest.json
[add] https://crrev.com/c33c79ba72956aacea756bf8c9b3f9e853e87584/chrome/test/data/web_app_default_apps/user_types/web_apps/app_managed.json
[add] https://crrev.com/c33c79ba72956aacea756bf8c9b3f9e853e87584/chrome/test/data/web_app_default_apps/user_types/web_apps/app_supervised.json
[modify] https://crrev.com/c33c79ba72956aacea756bf8c9b3f9e853e87584/chrome/test/data/web_app_default_apps/user_types/web_apps/app_unmanaged.json
[delete] https://crrev.com/e14f9bf0dd56897db0fd4f1c7d2fdbeed6ff8702/chrome/test/data/web_app_default_apps/user_types/web_apps/child_users/app_child.json
[delete] https://crrev.com/e14f9bf0dd56897db0fd4f1c7d2fdbeed6ff8702/chrome/test/data/web_app_default_apps/user_types/web_apps/managed_users/app_managed.json
[add] https://crrev.com/c33c79ba72956aacea756bf8c9b3f9e853e87584/chrome/test/data/web_app_default_apps/wrong_user_type/wrong_user_type.json
Project Member

Comment 24 by cr-audit...@appspot.gserviceaccount.com, Jan 9 

Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision c33c79ba72956aacea756bf8c9b3f9e853e87584 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required --
Project Member

Comment 25 by cr-audit...@appspot.gserviceaccount.com, Jan 9 

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/c33c79ba72956aacea756bf8c9b3f9e853e87584

Commit: c33c79ba72956aacea756bf8c9b3f9e853e87584
Author: khmel@chromium.org
Commiter: khmel@chromium.org
Date: 2019-01-09 23:36:27 +0000 UTC

[Merge M72] web_apps: Add json user type filter.

This is more robust solution than previous one, based one folder
separation. DD: https://goto.google.com/web_app_default.

TEST=Unit test + nocturne build and various user types.
BUG= 902978 

Change-Id: I2f7e17a22b724254400eec7deae75a9cc606e3f7
Reviewed-on: https://chromium-review.googlesource.com/c/1401508
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#621223}(cherry picked from commit db29a96e938ab285182c7da5c8b4bd4a9b3c3934)
Reviewed-on: https://chromium-review.googlesource.com/c/1404381
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#627}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
Project Member

Comment 26 by bugdroid1@chromium.org, Jan 9

Labels: merge-merged-release-R72-11316.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-nocturne-private/+/7288282ce8524f7cb008fb23d3fdf99d51a2648e

commit 7288282ce8524f7cb008fb23d3fdf99d51a2648e
Author: khmel@google.com <khmel@google.com>
Date: Wed Jan 09 23:50:49 2019

Comment 32 by khmel@chromium.org, Jan 14

Status: Fixed (was: Started)
Verified in R72-11316.78.0
►

Sign in to add a comment