Flaky test: LoadingPredictorBrowserTest.PrepareForPageLoadWithPrediction Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/75558 Test output log: https://chromium-swarm.appspot.com/task?id=4108e9495d181110 Culprit (70.0% confidence): r606088 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyzwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKYAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzIChkYmcpKDEpLzc1NTU4L25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1RHOWhaR2x1WjFCeVpXUnBZM1J2Y2tKeWIzZHpaWEpVWlhOMExsQnlaWEJoY21WR2IzSlFZV2RsVEc5aFpGZHBkR2hRY21Wa2FXTjBhVzl1DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20LoadingPredictorBrowserTest.PrepareForPageLoadWithPrediction&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyzwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKYAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzIChkYmcpKDEpLzc1NTU4L25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1RHOWhaR2x1WjFCeVpXUnBZM1J2Y2tKeWIzZHpaWEpVWlhOMExsQnlaWEJoY21WR2IzSlFZV2RsVEc5aFpGZHBkR2hRY21Wa2FXTjBhVzl1DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Assign to alexilin@ who is the author of CL[1] causing test failures. [1] http://crrev.com/c/c/1307445 predictors: Issue a dns request only after a proxy lookup is complete
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81b219a48be6ba2b20361f7b65c0a2d135fea479 commit 81b219a48be6ba2b20361f7b65c0a2d135fea479 Author: Alexandr Ilin <alexilin@chromium.org> Date: Thu Nov 08 12:23:01 2018 predictors: Pause navigations in LoadingPredictorBrowserTests This CL fixes flaky LoadingPredictorBrowserTest.PrepareForPageLoadWithPrediction test. If a navigation finishes earlier than the PreconnectManager completes all its preresolve jobs, remaining jobs will be cancelled and the test will fail by timeout. This CL uses TestNavigationManager that pauses navigations to avoid this race. Bug: 902963 Change-Id: I6aea05b3518627f7bbef0af18bb89bb1b1463f81 Reviewed-on: https://chromium-review.googlesource.com/c/1325984 Reviewed-by: Benoit L <lizeb@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#606419} [modify] https://crrev.com/81b219a48be6ba2b20361f7b65c0a2d135fea479/chrome/browser/predictors/loading_predictor_browsertest.cc
Comment 1 by yosin@chromium.org
, Nov 8Owner: alexilin@chromium.org
Status: Assigned (was: Untriaged)