neon-animation element has been deprecated (long time ago), see [1]. We are still depending on it in several places, including chrome://settings. We should gradually remove such dependencies and move towards alternatives, for example using our own cr-view-manager at [2] [1] https://github.com/PolymerElements/neon-animation [2] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_view_manager/cr_view_manager.js
CL in review for chrome://device-emulator at https://chromium-review.googlesource.com/c/chromium/src/+/1324993.
CL in review for chrome://md-user-manager https://chromium-review.googlesource.com/c/chromium/src/+/1327420.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ef63fa6a5aace63a57667e42194e5151e377013 commit 2ef63fa6a5aace63a57667e42194e5151e377013 Author: dpapad <dpapad@chromium.org> Date: Thu Nov 08 22:54:17 2018 WebUI cleanup: Remove neon-animation usage from device-emulator. This is in preparation of fully removing neon-animation from the repository (although there is a long way to get there). Bug: 902959 Change-Id: Ia1444651b96fba4316f69cfeb65bf92177acb389 Reviewed-on: https://chromium-review.googlesource.com/c/1324993 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#606634} [modify] https://crrev.com/2ef63fa6a5aace63a57667e42194e5151e377013/chrome/browser/resources/chromeos/emulator/audio_settings.html [modify] https://crrev.com/2ef63fa6a5aace63a57667e42194e5151e377013/chrome/browser/resources/chromeos/emulator/audio_settings.js [modify] https://crrev.com/2ef63fa6a5aace63a57667e42194e5151e377013/chrome/browser/resources/chromeos/emulator/battery_settings.html [modify] https://crrev.com/2ef63fa6a5aace63a57667e42194e5151e377013/chrome/browser/resources/chromeos/emulator/battery_settings.js [modify] https://crrev.com/2ef63fa6a5aace63a57667e42194e5151e377013/chrome/browser/resources/chromeos/emulator/bluetooth_settings.html [modify] https://crrev.com/2ef63fa6a5aace63a57667e42194e5151e377013/chrome/browser/resources/chromeos/emulator/bluetooth_settings.js [modify] https://crrev.com/2ef63fa6a5aace63a57667e42194e5151e377013/chrome/browser/resources/chromeos/emulator/device_emulator_pages.html [modify] https://crrev.com/2ef63fa6a5aace63a57667e42194e5151e377013/chrome/browser/resources/chromeos/emulator/device_emulator_pages.js [modify] https://crrev.com/2ef63fa6a5aace63a57667e42194e5151e377013/chrome/browser/resources/chromeos/emulator/input_device_settings.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec64bd65d8de88fbb5ac6ac29c36ab0d027c61ac commit ec64bd65d8de88fbb5ac6ac29c36ab0d027c61ac Author: dpapad <dpapad@chromium.org> Date: Thu Nov 08 23:02:59 2018 ChromeOS OOBE: Remove an unnecessary dependency to neon-animated-pages. Bug: 902959 Change-Id: I6a5bfde6b6b81f16b34d0ae6b728a0aa26f869a3 Reviewed-on: https://chromium-review.googlesource.com/c/1327566 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#606638} [modify] https://crrev.com/ec64bd65d8de88fbb5ac6ac29c36ab0d027c61ac/chrome/browser/resources/chromeos/login/offline_gaia.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40239723af8afaa3e7ed317759df1a2872008ebf commit 40239723af8afaa3e7ed317759df1a2872008ebf Author: dpapad <dpapad@chromium.org> Date: Fri Nov 09 01:18:06 2018 WebUI user-manager: Replace neon-animated-pages with cr-view-manager. Also ensure that JS type checking runs on non-ChromeOS. It was erroneously running on ChromeOS only. Bug: 902959 Change-Id: Ibd67a276325ac1e4461509341f6a198e27e9dabe Reviewed-on: https://chromium-review.googlesource.com/c/1327420 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606688} [modify] https://crrev.com/40239723af8afaa3e7ed317759df1a2872008ebf/chrome/browser/resources/BUILD.gn [modify] https://crrev.com/40239723af8afaa3e7ed317759df1a2872008ebf/chrome/browser/resources/md_user_manager/BUILD.gn [modify] https://crrev.com/40239723af8afaa3e7ed317759df1a2872008ebf/chrome/browser/resources/md_user_manager/user_manager_pages.html [modify] https://crrev.com/40239723af8afaa3e7ed317759df1a2872008ebf/chrome/browser/resources/md_user_manager/user_manager_pages.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be04191110d5c7574eada28277bd8cced364d10c commit be04191110d5c7574eada28277bd8cced364d10c Author: dpapad <dpapad@chromium.org> Date: Fri Nov 09 21:39:21 2018 WebUI user-manager: Remove supervised users related dead code. This code should have been removed as part of https://chromium-review.googlesource.com/c/chromium/src/+/1029952/ Bug: 902959, 828890 Change-Id: Ib7e00a646c864bea6b741924d6c592197ff2863d Reviewed-on: https://chromium-review.googlesource.com/c/1327227 Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#606972} [modify] https://crrev.com/be04191110d5c7574eada28277bd8cced364d10c/chrome/browser/resources/md_user_manager/user_manager_pages.html [modify] https://crrev.com/be04191110d5c7574eada28277bd8cced364d10c/chrome/browser/resources/md_user_manager/user_manager_pages.js [modify] https://crrev.com/be04191110d5c7574eada28277bd8cced364d10c/chrome/test/data/webui/md_user_manager/user_manager_pages_tests.js
FYI, Settings CL in progress at https://chromium-review.googlesource.com/c/chromium/src/+/1324915.
Status update regarding the Settings removal of neon-animation: - CL #1) Remove animations + rewrite main_page_behavior.js. WIP CL at https://chromium-review.googlesource.com/c/chromium/src/+/1324915. Functionality works. Still fixing failing tests. - CL #2) Remove neon-animatable https://chromium-review.googlesource.com/c/chromium/src/+/1343657. - CL #3) Add back some very subtle fade-in transitions (not uploaded yet).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dea41b507af4b77b2d8653b6fd3121de22c1ead7 commit dea41b507af4b77b2d8653b6fd3121de22c1ead7 Author: dpapad <dpapad@chromium.org> Date: Tue Dec 11 23:25:29 2018 Settings cleanup: Swap neon-animatable elements with plain div. Usage of neon-animatable is unnecessary now that neon-animation-pages has been removed. Bug: 902959 Change-Id: I7cbad2e8a2ba1f56234cc77ed9a40b4ef9aea314 Reviewed-on: https://chromium-review.googlesource.com/c/1343657 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#615719} [modify] https://crrev.com/dea41b507af4b77b2d8653b6fd3121de22c1ead7/chrome/browser/resources/settings/a11y_page/a11y_page.html [modify] https://crrev.com/dea41b507af4b77b2d8653b6fd3121de22c1ead7/chrome/browser/resources/settings/about_page/about_page.html [modify] https://crrev.com/dea41b507af4b77b2d8653b6fd3121de22c1ead7/chrome/browser/resources/settings/android_apps_page/android_apps_page.html [modify] https://crrev.com/dea41b507af4b77b2d8653b6fd3121de22c1ead7/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/dea41b507af4b77b2d8653b6fd3121de22c1ead7/chrome/browser/resources/settings/autofill_page/autofill_page.html [modify] https://crrev.com/dea41b507af4b77b2d8653b6fd3121de22c1ead7/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html [modify] https://crrev.com/dea41b507af4b77b2d8653b6fd3121de22c1ead7/chrome/browser/resources/settings/crostini_page/crostini_page.html [modify] https://crrev.com/dea41b507af4b77b2d8653b6fd3121de22c1ead7/chrome/browser/resources/settings/date_time_page/date_time_page.html [modify] https://crrev.com/dea41b507af4b77b2d8653b6fd3121de22c1ead7/chrome/browser/resources/settings/device_page/device_page.html [modify] https://crrev.com/dea41b507af4b77b2d8653b6fd3121de22c1ead7/chrome/browser/resources/settings/downloads_page/downloads_page.html [modify] https://crrev.com/dea41b507af4b77b2d8653b6fd3121de22c1ead7/chrome/browser/resources/settings/internet_page/internet_page.html [modify] https://crrev.com/dea41b507af4b77b2d8653b6fd3121de22c1ead7/chrome/browser/resources/settings/languages_page/languages_page.html [modify] https://crrev.com/dea41b507af4b77b2d8653b6fd3121de22c1ead7/chrome/browser/resources/settings/multidevice_page/multidevice_page.html [modify] https://crrev.com/dea41b507af4b77b2d8653b6fd3121de22c1ead7/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/dea41b507af4b77b2d8653b6fd3121de22c1ead7/chrome/browser/resources/settings/printing_page/printing_page.html [modify] https://crrev.com/dea41b507af4b77b2d8653b6fd3121de22c1ead7/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/dea41b507af4b77b2d8653b6fd3121de22c1ead7/chrome/browser/resources/settings/reset_page/reset_page.html [modify] https://crrev.com/dea41b507af4b77b2d8653b6fd3121de22c1ead7/chrome/browser/resources/settings/search_page/search_page.html [modify] https://crrev.com/dea41b507af4b77b2d8653b6fd3121de22c1ead7/chrome/browser/resources/settings/settings_page/settings_animated_pages.js [modify] https://crrev.com/dea41b507af4b77b2d8653b6fd3121de22c1ead7/chrome/test/data/webui/settings/settings_animated_pages_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2fb59d296498d8b049bae8dee3ebace00d9e2cb commit f2fb59d296498d8b049bae8dee3ebace00d9e2cb Author: dpapad <dpapad@chromium.org> Date: Thu Dec 13 01:27:13 2018 WebUI cleanup: Remove neon-animation and friends from non-CrOS builds. In order to do so, also limit iron-dropdown and cr-searchable-drop-down to ChromeOS builds (not used anywhere else). Bug: 907333 ,902959 Change-Id: I71be4291aa8ba8e69b25dbba114593b52da08504 Reviewed-on: https://chromium-review.googlesource.com/c/1372054 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#616148} [modify] https://crrev.com/f2fb59d296498d8b049bae8dee3ebace00d9e2cb/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js [modify] https://crrev.com/f2fb59d296498d8b049bae8dee3ebace00d9e2cb/ui/webui/resources/cr_elements_resources.grdp [modify] https://crrev.com/f2fb59d296498d8b049bae8dee3ebace00d9e2cb/ui/webui/resources/polymer_resources.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cad7c04adabff2a838167f4e3a1c79d585db007e commit cad7c04adabff2a838167f4e3a1c79d585db007e Author: dpapad <dpapad@chromium.org> Date: Fri Dec 14 05:55:17 2018 WebUI cleanup: Remove subset of neon-animation/ deps that are not used. Bug: 902959 Change-Id: Ie32d26c532adef89fe33d082815003f6b6e61dc0 Reviewed-on: https://chromium-review.googlesource.com/c/1377871 Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#616592} [modify] https://crrev.com/cad7c04adabff2a838167f4e3a1c79d585db007e/chrome/browser/resources/chromeos/login/controller-pairing-screen.html [modify] https://crrev.com/cad7c04adabff2a838167f4e3a1c79d585db007e/third_party/polymer/v1_0/components-chromium/neon-animation/animations/BUILD.gn [delete] https://crrev.com/d53bd9343be0d64551e8cd14496393e3190876d3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/cascaded-animation-extracted.js [delete] https://crrev.com/d53bd9343be0d64551e8cd14496393e3190876d3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/hero-animation-extracted.js [delete] https://crrev.com/d53bd9343be0d64551e8cd14496393e3190876d3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/opaque-animation-extracted.js [delete] https://crrev.com/d53bd9343be0d64551e8cd14496393e3190876d3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/reverse-ripple-animation-extracted.js [delete] https://crrev.com/d53bd9343be0d64551e8cd14496393e3190876d3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/ripple-animation-extracted.js [delete] https://crrev.com/d53bd9343be0d64551e8cd14496393e3190876d3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/scale-down-animation-extracted.js [delete] https://crrev.com/d53bd9343be0d64551e8cd14496393e3190876d3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/scale-up-animation-extracted.js [delete] https://crrev.com/d53bd9343be0d64551e8cd14496393e3190876d3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-down-animation-extracted.js [delete] https://crrev.com/d53bd9343be0d64551e8cd14496393e3190876d3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-from-bottom-animation-extracted.js [delete] https://crrev.com/d53bd9343be0d64551e8cd14496393e3190876d3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-from-left-animation-extracted.js [delete] https://crrev.com/d53bd9343be0d64551e8cd14496393e3190876d3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-from-right-animation-extracted.js [delete] https://crrev.com/d53bd9343be0d64551e8cd14496393e3190876d3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-from-top-animation-extracted.js [delete] https://crrev.com/d53bd9343be0d64551e8cd14496393e3190876d3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-left-animation-extracted.js [delete] https://crrev.com/d53bd9343be0d64551e8cd14496393e3190876d3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-right-animation-extracted.js [delete] https://crrev.com/d53bd9343be0d64551e8cd14496393e3190876d3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-up-animation-extracted.js [delete] https://crrev.com/d53bd9343be0d64551e8cd14496393e3190876d3/third_party/polymer/v1_0/components-chromium/neon-animation/animations/transform-animation-extracted.js [modify] https://crrev.com/cad7c04adabff2a838167f4e3a1c79d585db007e/third_party/polymer/v1_0/rsync_exclude.txt [modify] https://crrev.com/cad7c04adabff2a838167f4e3a1c79d585db007e/ui/webui/resources/polymer_resources.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45b2cdcec167cfd2645c71a26a2e4dd47022ec20 commit 45b2cdcec167cfd2645c71a26a2e4dd47022ec20 Author: dpapad <dpapad@chromium.org> Date: Sat Dec 15 00:00:41 2018 WebUI: Remove web-animations polyfil dependency, where not needed. After updating paper-tooltip to its latest version at r616028, a few places that were previously importing the Web animations polyfil, no longer need it. Bug: 902959 Change-Id: I63d9a09ff3300d2e0c693fc7a24d2750c6b53c94 Reviewed-on: https://chromium-review.googlesource.com/c/1378813 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#616883} [modify] https://crrev.com/45b2cdcec167cfd2645c71a26a2e4dd47022ec20/chrome/browser/resources/md_extensions/item.html [modify] https://crrev.com/45b2cdcec167cfd2645c71a26a2e4dd47022ec20/chrome/browser/resources/settings/site_settings/site_list.html [modify] https://crrev.com/45b2cdcec167cfd2645c71a26a2e4dd47022ec20/chrome/browser/resources/settings/site_settings/site_list_entry.html [modify] https://crrev.com/45b2cdcec167cfd2645c71a26a2e4dd47022ec20/ui/webui/resources/cr_elements/policy/cr_tooltip_icon.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e61e5cf916bede2f08eabc7eb4c962247616e39 commit 4e61e5cf916bede2f08eabc7eb4c962247616e39 Author: Scott Chen <scottchen@chromium.org> Date: Mon Dec 17 23:29:40 2018 WebUI: make polymer's reproduce.sh clean up excluded files. Files that were in rsync_exclude.txt were just ignored and left in the codebase. This CL makes the reproduce script clean up the excluded files. Bug: 843350, 902959 Change-Id: I99d2147cb0f73d51dd9fe4443b5ce677e4d37d37 Reviewed-on: https://chromium-review.googlesource.com/c/1380938 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#617284} [delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/cascaded-animation.html [delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/hero-animation.html [delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/opaque-animation.html [delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/reverse-ripple-animation.html [delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/ripple-animation.html [delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/scale-down-animation.html [delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/scale-up-animation.html [delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-down-animation.html [delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-from-bottom-animation.html [delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-from-left-animation.html [delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-from-right-animation.html [delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-from-top-animation.html [delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-left-animation.html [delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-right-animation.html [delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-up-animation.html [delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/animations/transform-animation.html [delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation.html [delete] https://crrev.com/ba65a0814c33ddbe5c569a0c72445e4a50f6a2ce/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animations.html [modify] https://crrev.com/4e61e5cf916bede2f08eabc7eb4c962247616e39/third_party/polymer/v1_0/reproduce.sh
Comment 1 by dpa...@chromium.org
, Nov 7