New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 902937 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Add test for check_webapp_display_manifest being false

Project Member Reported by benwells@google.com, Nov 7

Issue description

This new option was introduced but no new tests were added. Some tests should be added.
 
Cc: -dominickn@google.com dominickn@chromium.org
Components: UI>Browser>WebAppInstalls
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/871f84f2cb44770afc01a6567e26ea93a0cdcf2f

commit 871f84f2cb44770afc01a6567e26ea93a0cdcf2f
Author: Ben Wells <benwells@chromium.org>
Date: Wed Nov 21 05:59:06 2018

Add test for check_webapp_display_manifest being false.

This option was added recently without any tests. This change adds a
simple test for this.

Bug:  902937 
Change-Id: If35b91e8c43db434921a0a6b01beb708957aecb3
Reviewed-on: https://chromium-review.googlesource.com/c/1343813
Commit-Queue: Ben Wells <benwells@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609925}
[modify] https://crrev.com/871f84f2cb44770afc01a6567e26ea93a0cdcf2f/chrome/browser/installable/installable_manager_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment