smbprovider: Split mapping of UNKNOWN_FAILURE to more buckets for metrics |
||||
Issue descriptionCurrently about 8-10 different error codes map to UNKNOWN_FAILURE. Separate the DBUS error to it's own error. Separate the various "resource exausted" type errors to another bucket Separate the various IO errors to another bucket Currently we don't report a metric for invalid URL. Make sure that is reported too. This also requires possible adding additional error strings.
,
Nov 8
,
Nov 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bdd8b4f0a00f01a18ab18e9946bf13783f5d83d4 commit bdd8b4f0a00f01a18ab18e9946bf13783f5d83d4 Author: Bailey Berro <baileyberro@chromium.org> Date: Sat Nov 17 00:58:33 2018 Ensure metrics for Invalid Url report on failed mount Fixes a bug where metrics were not recorded correctly for failed mounts due to invalid urls. Bug: chromium:902923 Change-Id: Iba8164d4869818a44faa10ee18503cdd1e24d424 Reviewed-on: https://chromium-review.googlesource.com/c/1340971 Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#609052} [modify] https://crrev.com/bdd8b4f0a00f01a18ab18e9946bf13783f5d83d4/chrome/browser/chromeos/smb_client/smb_service.cc
,
Nov 20
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/857bec7975a5ae8a1d9dbb9e14e20e5333fc007f commit 857bec7975a5ae8a1d9dbb9e14e20e5333fc007f Author: Bailey Berro <baileyberro@chromium.org> Date: Tue Nov 27 22:18:50 2018 Break out values of UNKNOWN_FAILURE metrics bucket This change breaks up the UNKNOWN_FAILURE bucket into more detailed values so that we can better determine where errors are happening. Bug: chromium:902923 Change-Id: I814466b081ce5ad0371fff7cd843ed8dd9e9c2e5 Reviewed-on: https://chromium-review.googlesource.com/c/1340976 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#611369} [modify] https://crrev.com/857bec7975a5ae8a1d9dbb9e14e20e5333fc007f/chrome/browser/chromeos/smb_client/smb_errors.cc [modify] https://crrev.com/857bec7975a5ae8a1d9dbb9e14e20e5333fc007f/chrome/browser/chromeos/smb_client/smb_errors.h [modify] https://crrev.com/857bec7975a5ae8a1d9dbb9e14e20e5333fc007f/chrome/browser/chromeos/smb_client/smb_errors_unittest.cc [modify] https://crrev.com/857bec7975a5ae8a1d9dbb9e14e20e5333fc007f/tools/metrics/histograms/enums.xml [modify] https://crrev.com/857bec7975a5ae8a1d9dbb9e14e20e5333fc007f/ui/webui/resources/cr_components/chromeos/smb_shares/smb_browser_proxy.js
,
Dec 19
,
Dec 27
Hi Bailey/Zentaro, does this bug require manual verification? If yes, could you please provide some steps? Thanks! |
||||
►
Sign in to add a comment |
||||
Comment 1 by weifangsun@chromium.org
, Nov 8