New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment
link

Issue 902897: fling down at the end of tab-dragging doesn't minimize the window

Reported by mukai@chromium.org, Nov 7 Project Member

Issue description

Chrome Version: ToT
OS: ChromeOS

What steps will reproduce the problem?
(1) open a browser window
(2) drag a tab with touch, detach it to a separate window
(3) fling down the dragged tab

What is the expected result?
- the tab is minimized

What happens instead?
- minimized animation starts, but minimization gets canceled soon

Note that dragging a window (dragging from a window frame) causes minimization as expected.


Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
 

Comment 1 by mukai@chromium.org, Nov 9

Cc: est...@chromium.org x...@chromium.org sky@chromium.org mukai@chromium.org
 Issue 903916  has been merged into this issue.

Comment 2 by mukai@chromium.org, Dec 13

Status: Started (was: Assigned)

Comment 3 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9b555828b2f49b9b9d223384d98e7a1f43ec5d9

commit d9b555828b2f49b9b9d223384d98e7a1f43ec5d9
Author: Jun Mukai <mukai@chromium.org>
Date: Fri Dec 14 22:34:47 2018

Prevent restoring focus when the EndDrag minimizes the window

Some gesture may minimize the window along with ending the drag,
but TabDragController::RestoreFocus in EndDragImpl() cancels
the minimization.

Bug:  902897 
Test: the new test case
Change-Id: I3b19ef228d69b141eee5f18fbf130cccb4745d6b
Reviewed-on: https://chromium-review.googlesource.com/c/1377490
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616856}
[modify] https://crrev.com/d9b555828b2f49b9b9d223384d98e7a1f43ec5d9/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/d9b555828b2f49b9b9d223384d98e7a1f43ec5d9/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

Comment 4 by mukai@chromium.org, Dec 14

Status: Fixed (was: Started)

Comment 5 by bugdroid1@chromium.org, Dec 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49ad623a52986bae99234d9672fb4c2766c4df59

commit 49ad623a52986bae99234d9672fb4c2766c4df59
Author: Jun Mukai <mukai@chromium.org>
Date: Sat Dec 15 00:04:44 2018

Revert "Prevent restoring focus when the EndDrag minimizes the window"

This reverts commit d9b555828b2f49b9b9d223384d98e7a1f43ec5d9.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Prevent restoring focus when the EndDrag minimizes the window
> 
> Some gesture may minimize the window along with ending the drag,
> but TabDragController::RestoreFocus in EndDragImpl() cancels
> the minimization.
> 
> Bug:  902897 
> Test: the new test case
> Change-Id: I3b19ef228d69b141eee5f18fbf130cccb4745d6b
> Reviewed-on: https://chromium-review.googlesource.com/c/1377490
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Jun Mukai <mukai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#616856}

TBR=mukai@chromium.org,sky@chromium.org

Change-Id: Ic047835d96904b59c6be0c47ce357af2a07e2856
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  902897 
Reviewed-on: https://chromium-review.googlesource.com/c/1379168
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616884}
[modify] https://crrev.com/49ad623a52986bae99234d9672fb4c2766c4df59/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/49ad623a52986bae99234d9672fb4c2766c4df59/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

Comment 6 by mukai@chromium.org, Dec 15

Status: Started (was: Fixed)

Comment 7 by bugdroid1@chromium.org, Dec 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/097d3786cce78ebd5ebd732af2a18d6485ebe93b

commit 097d3786cce78ebd5ebd732af2a18d6485ebe93b
Author: Jun Mukai <mukai@chromium.org>
Date: Sat Dec 15 02:35:02 2018

Reland "Prevent restoring focus when the EndDrag minimizes the window""

Some gesture may minimize the window along with ending the drag,
but TabDragController::RestoreFocus in EndDragImpl() cancels
the minimization.

Previous CL was reverted due to test failures on release bot,
because sequence of touch events may not generate fling gesture
if it moves too fast. This CL introduces SimpleTestTickClock to
generate the fling gesture reliably.

TBR=sky@chromium.org

Bug:  902897 
Test: the new test case
Change-Id: I37cf7ce83a25d3fafbc9628515bae4c4185dabd6
Reviewed-on: https://chromium-review.googlesource.com/c/1379191
Reviewed-by: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616922}
[modify] https://crrev.com/097d3786cce78ebd5ebd732af2a18d6485ebe93b/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/097d3786cce78ebd5ebd732af2a18d6485ebe93b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/097d3786cce78ebd5ebd732af2a18d6485ebe93b/ui/aura/test/ui_controls_factory_ozone.cc

Comment 8 by mukai@chromium.org, Dec 17

Status: Fixed (was: Started)

Sign in to add a comment