New issue
Advanced search Search tips

Issue 902869 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[Merge Request] Update the title text of migration bubble

Project Member Reported by siyua@chromium.org, Nov 7

Issue description

Requesting to merge CL updating the migration bubble title. The previous title has translation issues in some languages.

https://chromium-review.googlesource.com/c/chromium/src/+/1316835

Have tested successfully in Canary 72.0.3604.0 and verified everything is okay.

 
Screen Shot 2018-11-07 at 11.39.26 AM.png
670 KB View Download
Project Member

Comment 1 by sheriffbot@chromium.org, Nov 7

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-71 Merge-Approved-71
Approving merge to M71 branch 3578 based on comment #0 and per internal mail thread. Pls merge ASAP. Thank you.
Status: Fixed (was: Assigned)
Merged to M71 via CL 1324371; marking as Fixed.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 7

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2145ecf91ec3fdafba04a04263f218bf46aa5d19

commit 2145ecf91ec3fdafba04a04263f218bf46aa5d19
Author: siyua <siyua@chromium.org>
Date: Wed Nov 07 21:06:18 2018

Update the title text of migration bubble

The previous title has translation issue.

Bug:  902869 
Change-Id: I59471c13de7c099bd8b7755d09c67d83e517f6b4
Reviewed-on: https://chromium-review.googlesource.com/c/1316835
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#605583}(cherry picked from commit d99669519c84d272f088dd911eaa38bb5bec2749)
Reviewed-on: https://chromium-review.googlesource.com/c/1324371
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/branch-heads/3578@{#570}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/2145ecf91ec3fdafba04a04263f218bf46aa5d19/chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.h
[modify] https://crrev.com/2145ecf91ec3fdafba04a04263f218bf46aa5d19/chrome/browser/ui/views/autofill/local_card_migration_bubble_views.cc
[modify] https://crrev.com/2145ecf91ec3fdafba04a04263f218bf46aa5d19/chrome/browser/ui/views/autofill/local_card_migration_bubble_views.h
[modify] https://crrev.com/2145ecf91ec3fdafba04a04263f218bf46aa5d19/components/autofill_strings.grdp

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/2145ecf91ec3fdafba04a04263f218bf46aa5d19

Commit: 2145ecf91ec3fdafba04a04263f218bf46aa5d19
Author: siyua@chromium.org
Commiter: jsaul@google.com
Date: 2018-11-07 21:06:18 +0000 UTC

Update the title text of migration bubble

The previous title has translation issue.

Bug:  902869 
Change-Id: I59471c13de7c099bd8b7755d09c67d83e517f6b4
Reviewed-on: https://chromium-review.googlesource.com/c/1316835
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#605583}(cherry picked from commit d99669519c84d272f088dd911eaa38bb5bec2749)
Reviewed-on: https://chromium-review.googlesource.com/c/1324371
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/branch-heads/3578@{#570}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment