[Merge Request] Update the title text of migration bubble |
|||||
Issue descriptionRequesting to merge CL updating the migration bubble title. The previous title has translation issues in some languages. https://chromium-review.googlesource.com/c/chromium/src/+/1316835 Have tested successfully in Canary 72.0.3604.0 and verified everything is okay.
,
Nov 7
Approving merge to M71 branch 3578 based on comment #0 and per internal mail thread. Pls merge ASAP. Thank you.
,
Nov 7
Merged to M71 via CL 1324371; marking as Fixed.
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2145ecf91ec3fdafba04a04263f218bf46aa5d19 commit 2145ecf91ec3fdafba04a04263f218bf46aa5d19 Author: siyua <siyua@chromium.org> Date: Wed Nov 07 21:06:18 2018 Update the title text of migration bubble The previous title has translation issue. Bug: 902869 Change-Id: I59471c13de7c099bd8b7755d09c67d83e517f6b4 Reviewed-on: https://chromium-review.googlesource.com/c/1316835 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#605583}(cherry picked from commit d99669519c84d272f088dd911eaa38bb5bec2749) Reviewed-on: https://chromium-review.googlesource.com/c/1324371 Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/branch-heads/3578@{#570} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/2145ecf91ec3fdafba04a04263f218bf46aa5d19/chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.h [modify] https://crrev.com/2145ecf91ec3fdafba04a04263f218bf46aa5d19/chrome/browser/ui/views/autofill/local_card_migration_bubble_views.cc [modify] https://crrev.com/2145ecf91ec3fdafba04a04263f218bf46aa5d19/chrome/browser/ui/views/autofill/local_card_migration_bubble_views.h [modify] https://crrev.com/2145ecf91ec3fdafba04a04263f218bf46aa5d19/components/autofill_strings.grdp
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2145ecf91ec3fdafba04a04263f218bf46aa5d19 Commit: 2145ecf91ec3fdafba04a04263f218bf46aa5d19 Author: siyua@chromium.org Commiter: jsaul@google.com Date: 2018-11-07 21:06:18 +0000 UTC Update the title text of migration bubble The previous title has translation issue. Bug: 902869 Change-Id: I59471c13de7c099bd8b7755d09c67d83e517f6b4 Reviewed-on: https://chromium-review.googlesource.com/c/1316835 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#605583}(cherry picked from commit d99669519c84d272f088dd911eaa38bb5bec2749) Reviewed-on: https://chromium-review.googlesource.com/c/1324371 Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/branch-heads/3578@{#570} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sheriffbot@chromium.org
, Nov 7