New issue
Advanced search Search tips

Issue 902860 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Direct-leak in mz_stream_pkcrypt_create

Project Member Reported by ClusterFuzz, Nov 7

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5754594451521536

Fuzzer: libFuzzer_minizip_uncompress_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  mz_stream_pkcrypt_create
  mz_zip_entry_open_int
  mz_zip_entry_read_open
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=605984:605985

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5754594451521536

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 7

Cc: yawano@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 2 by ClusterFuzz, Nov 7

Cc: nat...@solidstatenetworks.com
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Attempt to correct for invalid central dir offsets. #340 by nathan@solidstatenetworks.com - https://chromium.googlesource.com/external/github.com/nmoinvaz/minizip/+/aacf87304ed93449e7a8b31a60a759fb97dbc184

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Owner: amistry@chromium.org
Cc: -nat...@solidstatenetworks.com nathan.m...@gmail.com
Labels: -OS-Linux OS-Chrome
Status: Assigned (was: Untriaged)
Project Member

Comment 5 by ClusterFuzz, Nov 8

Labels: OS-Linux
Components: Platform>Apps>FileManager
Attaching reproducer here to make it easier for nathan.moinvaziri@ to access.
clusterfuzz-testcase-minimized-minizip_uncompress_fuzzer-5754594451521536
50 bytes View Download
I believe this has been fixed in dev branch.
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e30b832144017c0bf82e983145dd560f82e53101

commit e30b832144017c0bf82e983145dd560f82e53101
Author: Anand K. Mistry <amistry@chromium.org>
Date: Wed Nov 14 20:56:23 2018

Uprev minizip to rev 4d4c9db5b019e71b4a40fb41ab21fb47de12ae69

This revision is 2.7.5 plus a few build fixes.

BUG=904655,903690, 902860 

Change-Id: Ie71481e1e7c423c0bc292ec108fb1a0e3fc12caa
Reviewed-on: https://chromium-review.googlesource.com/c/1335052
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608120}
[modify] https://crrev.com/e30b832144017c0bf82e983145dd560f82e53101/DEPS
[modify] https://crrev.com/e30b832144017c0bf82e983145dd560f82e53101/third_party/minizip/README.chromium

Project Member

Comment 10 by ClusterFuzz, Nov 14

ClusterFuzz has detected this issue as fixed in range 608119:608120.

Detailed report: https://clusterfuzz.com/testcase?key=5754594451521536

Fuzzer: libFuzzer_minizip_uncompress_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  mz_stream_pkcrypt_create
  mz_zip_entry_open_int
  mz_zip_entry_read_open
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=605984:605985
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=608119:608120

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5754594451521536

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by ClusterFuzz, Nov 14

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5754594451521536 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment