New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 902852 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Change "Set wallpaper" to "Set as wallpaper"

Reported by norb...@rittel.de, Nov 7

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 11210.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3593.0 Safari/537.36
Platform: 11210.0.0 (Official Build) dev-channel panther

Steps to reproduce the problem:
1. Select some image file in the Files app.
2. Open the overflow menu in the upper right.

Alternatively right-click an image file.

What is the expected behavior?
Because the selected file is the one to be used immediately via this command the menu item should be

"Set as wallpaper"

What went wrong?
The menu item is just "Set wallpaper", which is identical to the menu item in the contextual menu for the desktop or the shelf.

The latter opens the wallpaper picker first and the user then selects the file. So the user interaction is different and thus the wording should not be identical.

In addition the menu item for the desktop or shelf should end with an ellipsis

"Set wallpaper…"

indicating that it opens a dialog for the actual user interaction.

Did this work before? No 

Chrome version: 72.0.3593.0  Channel: dev
OS Version: 11210.0.0
Flash Version: 

Perhaps the difference in wording isn't that obvious in English, but in other languages - like German for me - it becomes very pronounced:

"Als Hintergrund festlegen"  <- Direct action

vs.

"Hintergrund festlegen …"    <- Opens picker
 
Screenshot 2018-11-02 at 11.47.59.png
30.8 KB View Download
Components: -UI Platform>Apps>FileManager
Cc: slangley@chromium.org
Labels: CrOSFilesCategory-UI
Owner: mcirimele@chromium.org
Status: Assigned (was: Unconfirmed)
Looks reasonable.

Maria - WDYT?
Yeah, looks good to me. Let's do it!
Cc: mcirimele@chromium.org
Labels: Files-Fixit-2018
Owner: ----
Status: Available (was: Assigned)
Owner: joelhockey@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63b65d0cdc035236be9c0327e7064189cc0d48a5

commit 63b65d0cdc035236be9c0327e7064189cc0d48a5
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Nov 19 00:39:37 2018

FilesApp: context menu Set-as-wallpaper

Use label 'Set as wallpaper' rather than 'Set wallpaper'.

Bug:  902852 
Change-Id: Idcd9e6a669c9de13d9866d2fe0ed59157a8d2155
Reviewed-on: https://chromium-review.googlesource.com/c/1341281
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609159}
[modify] https://crrev.com/63b65d0cdc035236be9c0327e7064189cc0d48a5/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/63b65d0cdc035236be9c0327e7064189cc0d48a5/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SET_WALLPAPER_BUTTON_LABEL.png.sha1

Status: Fixed (was: Started)

Sign in to add a comment