Figure out a simpler way to enable serial in firmware |
||||
Issue descriptionAt present we build two entirely separate firmware images, one with serial enabled and one without. It would be nice if we could just have a flag for this, like we did in the old days. How about an 'enable_serial' file in the RO CBFS to enable this? Then, at worst, we could make the serial version from the non-serial version with a trivial change. We could read this in coreboot, and then pass it on in the sysinfo?
,
Nov 7
There is a GBB flag allocated for this, but as Julius notes it ran into some issues and we had to revert..
,
Nov 7
I've reallocated the flag a while ago, actually, it's used to skip the BROKEN screen now: https://chromium-review.googlesource.com/976660
,
Nov 7
Oops I remember that now, guess I should have said there _was_ a flag.
,
Nov 7
OK, so we cannot put it in a separate file in CBFS because ARM systems need to start their SF driver before they can decide if serial is available? So is it OK to add a GBB flag? Or do we need to add a simple run-time config option to coreboot so we can build the serial value into it?
,
Nov 7
GBB is stored in flash too so it has the same issue.
,
Nov 7
,
Nov 8
OK, so maybe I need to try to get some run-time config in coreboot. It was rejected some years ago.
,
Nov 8
> maybe I need to try to get some run-time config in coreboot Not really sure what you mean by this. I don't think there's a way to solve this the way you want, it's a fundamental problem. Some platforms just don't have any persistent storage other than SPI flash available where you could store something like this. Decisions that need to be made before SPI flash is accessible need to be made at build time, I think there's just no real way around that. (I also don't think it's a big enough problem that it would require bending over backwards to fix tbh.)
,
Nov 19
The idea is to store the config actually in coreboot - e.g. at minimum a simple binary flag to indicate serial or not. Would that be acceptable?
,
Nov 19
,
Nov 19
> The idea is to store the config actually in coreboot - e.g. at minimum a simple binary flag to indicate serial or not. Would that be acceptable? Sorry, I still don't understand what you're trying to achieve. Storing a flag on flash will not work for the reasons mentioned above. We want to have the console available before the point where we can access the flash. Compiling the decision into the code is really the only way to achieve that.
,
Jan 11
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this. |
||||
►
Sign in to add a comment |
||||
Comment 1 by jwer...@chromium.org
, Nov 7