New issue
Advanced search Search tips

Issue 902836 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 867471



Sign in to add a comment

Ensure feature-policy generates violations for all features

Project Member Reported by ekaramad@chromium.org, Nov 7

Issue description

Some features such as 'layout-animations' and 'vertical-scroll' currently do enforce the policy but do not generate violation reports. This is a tracking bug for the implementation of violation reports.
 
Blocking: 867471
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb09b04474e2b2d14ac58e59914117ba6f30a661

commit cb09b04474e2b2d14ac58e59914117ba6f30a661
Author: Ehsan Karamad <ekaramad@chromium.org>
Date: Fri Nov 16 22:19:36 2018

Violation reports for 'layout-animations'

This CL adds support for generating violation reports for 'layout-animations'
feature policy. The new implementation triggers a report when:
  1- CSS Parser finds usage of @keyframes for one of the banned styles.
  2- element.animate() changes a banned style.

Bug: 902836,867471
Change-Id: I79900603eb0166514d7986dc189ec914bd95f899
Reviewed-on: https://chromium-review.googlesource.com/c/1324138
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608984}
[add] https://crrev.com/cb09b04474e2b2d14ac58e59914117ba6f30a661/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/layout-animations-disabled-violation-report-js-tentative.html
[add] https://crrev.com/cb09b04474e2b2d14ac58e59914117ba6f30a661/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/layout-animations-disabled-violation-report-js-tentative.html.headers
[add] https://crrev.com/cb09b04474e2b2d14ac58e59914117ba6f30a661/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/layout-animations-disabled-violation-report-keyframes-tentative.html
[add] https://crrev.com/cb09b04474e2b2d14ac58e59914117ba6f30a661/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/layout-animations-disabled-violation-report-keyframes-tentative.html.headers
[add] https://crrev.com/cb09b04474e2b2d14ac58e59914117ba6f30a661/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/resources/animation-property-height.js
[modify] https://crrev.com/cb09b04474e2b2d14ac58e59914117ba6f30a661/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/resources/common.js
[modify] https://crrev.com/cb09b04474e2b2d14ac58e59914117ba6f30a661/third_party/blink/renderer/core/animation/css_interpolation_types_map.cc
[modify] https://crrev.com/cb09b04474e2b2d14ac58e59914117ba6f30a661/third_party/blink/renderer/core/animation/element_animation.cc
[modify] https://crrev.com/cb09b04474e2b2d14ac58e59914117ba6f30a661/third_party/blink/renderer/core/css/parser/css_parser_context.cc
[modify] https://crrev.com/cb09b04474e2b2d14ac58e59914117ba6f30a661/third_party/blink/renderer/core/css/parser/css_parser_context.h
[modify] https://crrev.com/cb09b04474e2b2d14ac58e59914117ba6f30a661/third_party/blink/renderer/core/css/parser/css_parser_impl.cc
[modify] https://crrev.com/cb09b04474e2b2d14ac58e59914117ba6f30a661/third_party/blink/renderer/core/feature_policy/BUILD.gn
[add] https://crrev.com/cb09b04474e2b2d14ac58e59914117ba6f30a661/third_party/blink/renderer/core/feature_policy/layout_animations_policy.cc
[add] https://crrev.com/cb09b04474e2b2d14ac58e59914117ba6f30a661/third_party/blink/renderer/core/feature_policy/layout_animations_policy.h

Sign in to add a comment