New issue
Advanced search Search tips

Issue 902834 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 902806



Sign in to add a comment

Chrome crashes on chromeos-amd64-generic-rel bot due to SEGFAULTs in resource_coordinator::PageSignalReceiver::AddObserver

Project Member Reported by bpastene@chromium.org, Nov 7

Issue description

See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-amd64-generic-rel/22248

Looks like the browser smoke tests are failing due to browser crashes. See the stack trace in the logs:
https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=5cddda2e83863fd01aa9dfc9ac51b40309acd33c&as=ui.20181107-091926

eg:
Received signal 11 SEGV_MAPERR 000000000008
#0 0x55b67a7cc78f base::debug::StackTrace::StackTrace()
#1 0x55b67a7cc301 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7cf6c692b2e0 <unknown>
#3 0x55b67a61c3d7 resource_coordinator::PageSignalReceiver::AddObserver()
#4 0x55b67a6fd9a5 resource_coordinator::ResourceCoordinatorTabHelper::ResourceCoordinatorTabHelper()
#5 0x55b67cc68a4f TabHelpers::AttachTabHelpers()
#6 0x55b67cc9f7b3 Navigate()
#7 0x55b67ccb6a3c StartupBrowserCreatorImpl::OpenTabsInBrowser()
#8 0x55b67ccb75d5 StartupBrowserCreatorImpl::RestoreOrCreateBrowser()
#9 0x55b67ccb6651 StartupBrowserCreatorImpl::DetermineURLsAndLaunch()
#10 0x55b67ccb60af StartupBrowserCreatorImpl::Launch()
#11 0x55b67ccb3b35 StartupBrowserCreator::LaunchBrowser()
#12 0x55b67ccb390a StartupBrowserCreator::ProcessCmdLineImpl()
#13 0x55b67ccb2e5d StartupBrowserCreator::Start()
#14 0x55b67a3ab1c0 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#15 0x55b67a3aa0d9 ChromeBrowserMainParts::PreMainMessageLoopRun()
#16 0x55b6794fdca4 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#17 0x55b678a90927 content::BrowserMainLoop::PreMainMessageLoopRun()
#18 0x55b678e72e37 content::StartupTaskRunner::RunAllTasksNow()
#19 0x55b678a8f463 content::BrowserMainLoop::CreateStartupTasks()
#20 0x55b678a92edd content::BrowserMainRunnerImpl::Initialize()
#21 0x55b678a8d3a1 content::BrowserMain()
#22 0x55b67a39e238 content::ContentMainRunnerImpl::Run()
#23 0x55b67a3a48cd service_manager::Main()
#24 0x55b67a39c461 content::ContentMain()
#25 0x55b677d32bdf ChromeMain
#26 0x7cf6c5d0d736 __libc_start_main
#27 0x55b677d32a09 _start


https://chromium-review.googlesource.com/c/1290775 shows up in the blamelist for that build with a lot of relevant file changes. sebmarchand@, can you take a look?
 
Blocking: 902806
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06085ed0d44992ac4f5f4b1423aab3a09982760a

commit 06085ed0d44992ac4f5f4b1423aab3a09982760a
Author: Sébastien Marchand <sebmarchand@chromium.org>
Date: Wed Nov 07 19:02:08 2018

Revert "RC: Encapsulate most of the singletons into ResourceCoordinatorParts"

This reverts commit 14754da5c731fc8af079e5195209840492540e4d.

Reason for revert: causing some crashes on Cross

Bug:  902834 

Original change's description:
> RC: Encapsulate most of the singletons into ResourceCoordinatorParts
> 
> There's several singletons / global instances in c/b/rc that are leaked
> at shutdown, this is causing some issues in runs of unit_tests because
> we end up re-using them between different test runs that should be
> independent. This is currently preventing some feature to be enabled.
> 
> This CL add a new ResourceCoordinatorParts class that encapsulate all
> these objects that should be created only once, an instance of this
> class is owned by the browser process.
> 
> Change-Id: Ia64618b6f47052815d861ff6820d994f8a65cc64
> Reviewed-on: https://chromium-review.googlesource.com/c/1290775
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606061}

TBR=sky@chromium.org,chrisha@chromium.org,fdoray@chromium.org,sebmarchand@chromium.org

Change-Id: I37bbcac05cceac6291874ad94d517cbdd4eeab2c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1323623
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606094}
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/BUILD.gn
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/browser_process.h
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/extensions/extension_service_test_base.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/chrome_browser_main_extra_parts_resource_coordinator.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/page_signal_receiver.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/page_signal_receiver.h
[delete] https://crrev.com/3b04594ac61c1731192e56b6a97575150c17ae2e/chrome/browser/resource_coordinator/resource_coordinator_parts.cc
[delete] https://crrev.com/3b04594ac61c1731192e56b6a97575150c17ae2e/chrome/browser/resource_coordinator/resource_coordinator_parts.h
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/tab_activity_watcher_browsertest.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/tab_helper.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/tab_lifecycle_unit_external.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/tab_lifecycle_unit_source.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/tab_lifecycle_unit_source.h
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/tab_lifecycle_unit_source_unittest.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/tab_load_tracker.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/tab_load_tracker.h
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/tab_manager.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/tab_manager.h
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/tab_manager_browsertest.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/tab_manager_resource_coordinator_signal_observer.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/tab_manager_resource_coordinator_signal_observer.h
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/tab_manager_unittest.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.h
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/utils.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/resource_coordinator/utils.h
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/ui/bloated_renderer/bloated_renderer_tab_helper.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/browser/ui/bloated_renderer/bloated_renderer_tab_helper_browsertest.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/test/base/testing_browser_process.cc
[modify] https://crrev.com/06085ed0d44992ac4f5f4b1423aab3a09982760a/chrome/test/base/testing_browser_process.h

Status: Fixed (was: Assigned)
The waterfall bot rolled green:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-amd64-generic-rel

Thanks for the swift revert!

Sign in to add a comment