Can we submit coreboot CLs on the pre-cq? |
|||
Issue descriptionAt present coreboot CLs from upstream are submitted in the normal CQ. But since no firmware testing is done in the CQ, this is effectively just a build test. In fact coreboot ignores HWTest and VMTest failures: https://cs.corp.google.com/chromeos_public/src/third_party/coreboot/COMMIT-QUEUE.ini?type=cs&q=f:%5C.ini+f:commit+f:coreboot&g=0&l=1 Can we change coreboot to submit on the pre-CQ? This might speed up submission of upstream patches (e.g. at present wilco firmware builder progress is blocked by the CQ being broken for some days). Basically the change would be to add this line to the above file: submit-in-pre-cq: yes Things to consider: - How does it handle CQ-DEPEND (e.g. with another repo like vboot_reference). Does that force the change to be skipped in the pre-CQ and submitted in the full CQ? Or just it just break? - Should we instead do a build test of all the coreboot changes on all Chrome OS boards, then 'git push' them to the repo?
,
Nov 7
I think the pre-cq doesn't build for _all_ boards? At least I think I had a couple of commits in the past that passed pre-cq and failed the CQ for legit reasons on boards that the pre-cq never bothered to try.
,
Nov 8
Current showcase: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1302754 passed pre-cq, but correctly (even if well-hidden in lots of garbage messaging) failed on octopus-paladin which is part of the CQ. While I'd rather have firmware fail like that in the pre-cq already, I understand that this might take too many resources. But given the current pre-cq setup, the CQ remains necessary.
,
Nov 8
,
Nov 8
Patrick, do you have a way to run trybots on a patch series?
,
Nov 8
Simon, I use:
$ cros tryjob -g CL1 -g CL2 -g CL3 ... {oak,eve,samus,nocturne}-compile-only-pre-cq
My main issue with that is knowing which pre-cq builders to use (1302754 passed pre-cq because neither I nor the official pre-cq tested octopus, for example). Drew Davenport reported that infra might provide something better for that next year, but so far there isn't.
,
Nov 19
OK, it sounds like we can't do much about that yet. I'll close this and we can revisit when the infra is improved. |
|||
►
Sign in to add a comment |
|||
Comment 1 by adurbin@chromium.org
, Nov 7