Flaky test: PasswordGenerationInteractiveTest.GenerationTriggeredInIFrame Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/6453 Test output log: https://chromium-swarm.appspot.com/task?id=41081a457b62e910 Culprit (87.3% confidence): r606041 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKfAWNocm9taXVtLm1hYy9NYWMxMC4xMyBUZXN0cy82NDUzL2ludGVyYWN0aXZlX3VpX3Rlc3RzIG9uIChub25lKSBHUFUgb24gTWFjL1VHRnpjM2R2Y21SSFpXNWxjbUYwYVc5dVNXNTBaWEpoWTNScGRtVlVaWE4wTGtkbGJtVnlZWFJwYjI1VWNtbG5aMlZ5WldSSmJrbEdjbUZ0WlE9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20PasswordGenerationInteractiveTest.GenerationTriggeredInIFrame&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKfAWNocm9taXVtLm1hYy9NYWMxMC4xMyBUZXN0cy82NDUzL2ludGVyYWN0aXZlX3VpX3Rlc3RzIG9uIChub25lKSBHUFUgb24gTWFjL1VHRnpjM2R2Y21SSFpXNWxjbUYwYVc5dVNXNTBaWEpoWTNScGRtVlVaWE4wTGtkbGJtVnlZWFJwYjI1VWNtbG5aMlZ5WldSSmJrbEdjbUZ0WlE9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Assign to dvadym@ who is the author of the CL[1] causing failure. [1] http://crrev.com/c/1317893 Fix dynamically changed forms in NewPasswordFormManager
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b874f30df5bdd328cd3cf5d52c1c623b11f45fec commit b874f30df5bdd328cd3cf5d52c1c623b11f45fec Author: Vadym Doroshenko <dvadym@chromium.org> Date: Thu Nov 08 13:07:26 2018 Fix dynamically changed forms in NewPasswordFormManager. Sometimes sites change forms after adding them. For example removing/ adding fields. This CL makes NewPasswordFormManager process this situation, by updating |observed_form|, parsing it again and sending new data to the renderer. This first time this CL was uploaded on https://chromium-review.googlesource.com/c/chromium/src/+/1326010 (Patch 1) but it was reverted because of failures in password_generation_interactive_uitest.cc. The reason of failures is that no non-blacklisted confirmation because NewPasswordFormManager waits for server response. This CL fixes that by turning off waiting of server predictions. TBR=isherman@chromium.org Bug: 895411, 831123, 895788 , 902805 Change-Id: I99174a73134c582a3975b1f06d797e61ec117855 Reviewed-on: https://chromium-review.googlesource.com/c/1326010 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#606435} [modify] https://crrev.com/b874f30df5bdd328cd3cf5d52c1c623b11f45fec/chrome/browser/password_manager/password_generation_interactive_uitest.cc [modify] https://crrev.com/b874f30df5bdd328cd3cf5d52c1c623b11f45fec/chrome/browser/password_manager/password_manager_browsertest.cc [modify] https://crrev.com/b874f30df5bdd328cd3cf5d52c1c623b11f45fec/components/password_manager/core/browser/new_password_form_manager.cc [modify] https://crrev.com/b874f30df5bdd328cd3cf5d52c1c623b11f45fec/components/password_manager/core/browser/new_password_form_manager.h [modify] https://crrev.com/b874f30df5bdd328cd3cf5d52c1c623b11f45fec/components/password_manager/core/browser/new_password_form_manager_unittest.cc [modify] https://crrev.com/b874f30df5bdd328cd3cf5d52c1c623b11f45fec/components/password_manager/core/browser/password_form_metrics_recorder.cc [modify] https://crrev.com/b874f30df5bdd328cd3cf5d52c1c623b11f45fec/components/password_manager/core/browser/password_form_metrics_recorder.h [modify] https://crrev.com/b874f30df5bdd328cd3cf5d52c1c623b11f45fec/components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc [modify] https://crrev.com/b874f30df5bdd328cd3cf5d52c1c623b11f45fec/components/password_manager/core/browser/password_manager.cc [modify] https://crrev.com/b874f30df5bdd328cd3cf5d52c1c623b11f45fec/tools/metrics/histograms/histograms.xml
Comment 1 by gangwu@chromium.org
, Nov 7