New issue
Advanced search Search tips

Issue 902803 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Missing source in manual translation

Project Member Reported by frechette@chromium.org, Nov 7

Issue description

Chrome Version: 72.0.3603.2
OS: Android

What steps will reproduce the problem?
(1) Enable manual translation (chrome://flags #translate-android-manual-trigger).
(2) Go to a page where translation could be triggered (e.g. www.nhk.or.jp for a device in English).
(3) Decline the automatic translation that appears.
(4) Reload the page.
(5) Very quickly click on apps menu (three-dots) then `Translate...`.

What is the expected result?
The regular translation prompt appears.

What happens instead?
The translation prompt appears but the source language is missing.



 
Screenshot_20181107-132752.png
58.1 KB View Download
Cc: chelamcherla@chromium.org
Labels: Needs-triage-Mobile Triaged-Mobile Needs-Feedback
Status: Assigned (was: Untriaged)
Tested the issue on android and unable to reproduce this issue

Steps to reproduce:
--------------------------
1. Launched chrome and enabled (chrome://flags #translate-android-manual-trigger).
2. Navigated to www.nhk.or.jp, Clicked "x" icon
3. Reloaded page, Clicked 3 dot menu, selected translate -- Source language is seen

Chrome version:
72.0.3605.3

OS:
Android 9.0 

Android device:
Pixel 2  XL

@frechette: Please check the above steps and let us know if we miss anything. Is this issue consistently reproducible? Any information on reproducing the issue would help in better triaging.

NOTE: Changing status to Assigned as Owner is already available. Please remove if this is not the case.

Thanks!
20181109_130258.mp4
13.9 MB View Download
When reloading the page, you have to be really quick and click on manual translate right away (or have the page load really slowly). The bug happens when we trigger translate before having computed the source language.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/923926a4097c9ca3e72641c28ea4ba5d5760baeb

commit 923926a4097c9ca3e72641c28ea4ba5d5760baeb
Author: Alexandre Frechette <frechette@chromium.org>
Date: Thu Nov 15 14:05:56 2018

[Translate Manual Trigger] Manual translation implementation that waits for source language.

The translate UI should not appear before the necessary information (i.e. source language) has been computed.
This changes manual translations to block before the state is correct.

Bug:  902803 
Change-Id: I0d0549b5093774ae5b60dd0e18fd72fe7349f895
Reviewed-on: https://chromium-review.googlesource.com/c/1331688
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608352}
[modify] https://crrev.com/923926a4097c9ca3e72641c28ea4ba5d5760baeb/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/923926a4097c9ca3e72641c28ea4ba5d5760baeb/chrome/android/java/src/org/chromium/chrome/browser/translate/TranslateBridge.java
[modify] https://crrev.com/923926a4097c9ca3e72641c28ea4ba5d5760baeb/chrome/browser/translate/android/translate_bridge.cc
[modify] https://crrev.com/923926a4097c9ca3e72641c28ea4ba5d5760baeb/chrome/browser/translate/chrome_translate_client.cc
[modify] https://crrev.com/923926a4097c9ca3e72641c28ea4ba5d5760baeb/chrome/browser/translate/chrome_translate_client.h
[add] https://crrev.com/923926a4097c9ca3e72641c28ea4ba5d5760baeb/chrome/browser/translate/translate_fake_page.cc
[add] https://crrev.com/923926a4097c9ca3e72641c28ea4ba5d5760baeb/chrome/browser/translate/translate_fake_page.h
[add] https://crrev.com/923926a4097c9ca3e72641c28ea4ba5d5760baeb/chrome/browser/translate/translate_manager_render_view_host_android_unittest.cc
[modify] https://crrev.com/923926a4097c9ca3e72641c28ea4ba5d5760baeb/chrome/browser/translate/translate_manager_render_view_host_unittest.cc
[modify] https://crrev.com/923926a4097c9ca3e72641c28ea4ba5d5760baeb/chrome/test/BUILD.gn

Status: Fixed (was: Assigned)
Tested manually with crow emulator. Will test manually on Canary tomorrow.
Issue 905557 has been merged into this issue.
Status: Verified (was: Fixed)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/622c02f9a7e9fe8d55bab94de43b3dab30b8b9b8

commit 622c02f9a7e9fe8d55bab94de43b3dab30b8b9b8
Author: Alexandre Frechette <frechette@chromium.org>
Date: Tue Nov 20 20:22:43 2018

Check source language to determine if page can be manually translated.

Bug:  907134 ,  902803 
Change-Id: Ifb63346572e90a191918bcfe30d24f4362c10b45
Reviewed-on: https://chromium-review.googlesource.com/c/1344256
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609789}
[modify] https://crrev.com/622c02f9a7e9fe8d55bab94de43b3dab30b8b9b8/components/translate/core/browser/translate_manager.cc
[modify] https://crrev.com/622c02f9a7e9fe8d55bab94de43b3dab30b8b9b8/components/translate/core/browser/translate_manager_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 21

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef1acbee763ddb43765fecfa1e68f08832335a79

commit ef1acbee763ddb43765fecfa1e68f08832335a79
Author: Alexandre Frechette <frechette@chromium.org>
Date: Wed Nov 21 16:45:38 2018

Check source language to determine if page can be manually translated.

Bug:  907134 ,  902803 
Change-Id: Ifb63346572e90a191918bcfe30d24f4362c10b45
Reviewed-on: https://chromium-review.googlesource.com/c/1344256
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#609789}(cherry picked from commit 622c02f9a7e9fe8d55bab94de43b3dab30b8b9b8)
Reviewed-on: https://chromium-review.googlesource.com/c/1346969
Cr-Commit-Position: refs/branch-heads/3578@{#788}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/ef1acbee763ddb43765fecfa1e68f08832335a79/components/translate/core/browser/translate_manager.cc
[modify] https://crrev.com/ef1acbee763ddb43765fecfa1e68f08832335a79/components/translate/core/browser/translate_manager_unittest.cc

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/ef1acbee763ddb43765fecfa1e68f08832335a79

Commit: ef1acbee763ddb43765fecfa1e68f08832335a79
Author: frechette@chromium.org
Commiter: anthonyvd@chromium.org
Date: 2018-11-21 16:45:38 +0000 UTC

Check source language to determine if page can be manually translated.

Bug:  907134 ,  902803 
Change-Id: Ifb63346572e90a191918bcfe30d24f4362c10b45
Reviewed-on: https://chromium-review.googlesource.com/c/1344256
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#609789}(cherry picked from commit 622c02f9a7e9fe8d55bab94de43b3dab30b8b9b8)
Reviewed-on: https://chromium-review.googlesource.com/c/1346969
Cr-Commit-Position: refs/branch-heads/3578@{#788}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Works as per expected behavior, Issue verified on 71.0.3578.75 and 72.0.3624.0 

Sign in to add a comment