New issue
Advanced search Search tips

Issue 902781 link

Starred by 1 user
Status: Assigned
Owner:
gambard@chromium.org
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task



Sign in to add a comment

Update BVC command handling

Project Member Reported by gambard@chromium.org, Nov 7 
The BVC command handling should be done in a better way:
- Only UI changes should go through the dispatcher.
- Some commands should be removed.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70f678d0e83196c6061b5f007a17d2eb8800fc2a

commit 70f678d0e83196c6061b5f007a17d2eb8800fc2a
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Nov 08 08:51:20 2018

[iOS] Remove unused command

This CL removes the -closeAllIncognitoTabs command as it is not used.

Bug: 902781
Change-Id: I583e53095fcddf03c899d6b44779b38daced32a3
Reviewed-on: https://chromium-review.googlesource.com/c/1323670
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606387}
[modify] https://crrev.com/70f678d0e83196c6061b5f007a17d2eb8800fc2a/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/70f678d0e83196c6061b5f007a17d2eb8800fc2a/ios/chrome/browser/ui/commands/browser_commands.h
►

Sign in to add a comment