New issue
Advanced search Search tips

Issue 902775 link

Starred by 1 user
Status: Fixed
Owner:
jam@chromium.org
Closed: Nov 7
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: Bug



Sign in to add a comment

Add a browser test to ensure that if a URLLoaderThrottle modifies the URL, it's the one that's requested

Project Member Reported by jam@chromium.org, Nov 7 
This is from the fallout of bug 899268. While the fix, https://chromium-review.googlesource.com/c/chromium/src/+/1317865, Tests this in PolicyTest. ForceGoogleSafeSearch correctly now, we should have a separate test at the URLLoaderInterceptor layer.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c32804f7844772e4819bb800e8010624fe5ca902

commit c32804f7844772e4819bb800e8010624fe5ca902
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Nov 07 19:10:37 2018

Add an integration test for a URLLoaderThrottle changing a URL and ensuring that it's requested correctly.

This is tested as part of PolicyTest.ForceGoogleSafeSearch after the fix in r605518, but we should have a test at the content-layer for URLLoaderThrottle's behavior.

Bug:  902775 
Change-Id: I9f9f4de201d55389709a4a7336c6bf581bb4bab3
Reviewed-on: https://chromium-review.googlesource.com/c/1323896
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606101}
[modify] https://crrev.com/c32804f7844772e4819bb800e8010624fe5ca902/content/browser/loader/loader_browsertest.cc

Comment 2 by jam@chromium.org, Nov 7

Status: Fixed (was: Started)
►

Sign in to add a comment