New issue
Advanced search Search tips

Issue 902770 link

Starred by 0 users
Status: Fixed
Owner:
johnchen@chromium.org
Closed: Nov 7
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Merge request for ChromeDriver send keys command W3C compliance fix

Project Member Reported by johnchen@chromium.org, Nov 7 
Requesting merge of https://chromium-review.googlesource.com/1320208 to m71 branch. This CL fixes a ChromeDriver bug in processing send keys command in W3C mode, and affects anyone that uses ChromeDriver with a spec-compliant client. This fix was originally done under  issue chromedriver:2649 .

Note that these changes are in ChromeDriver directory (src/chrome/test/chromedriver), and Chrome does not depend on that at all, so these will have no impact on Chrome binary that is shipping. See go/chromedriver-versioning and go/chops-proj-rev-27 for background.
Project Member

Comment 1 by sheriffbot@chromium.org, Nov 7

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by gov...@chromium.org, Nov 7

Labels: -Merge-Review-71 Merge-Approved-71
Approving merge to M71 branch 3578 based on comment #0. Pls merge ASAP. Thank you.
Project Member

Comment 3 by cr-audit...@appspot.gserviceaccount.com, Nov 7

Labels: -Merge-Approved-71 Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/20880e5f7d93bae1d925d8e44e1e63e2ab545a5e

Commit: 20880e5f7d93bae1d925d8e44e1e63e2ab545a5e
Author: johnchen@chromium.org
Commiter: johnchen@chromium.org
Date: 2018-11-07 17:53:52 +0000 UTC

[ChromeDriver] Fix W3C Element Send Keys

In W3C mode, Element Send Keys command should get keys from string
property "text", instead of list property "value".

Bug:  chromium:902770 ,  chromedriver:2649 
Change-Id: I68b915ad572c289364d797aa34496b2278cb3997
Reviewed-on: https://chromium-review.googlesource.com/c/1320208
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#605848}(cherry picked from commit 23ce277b6d5ce7e87ab9660fc3564b96908440b4)
Reviewed-on: https://chromium-review.googlesource.com/c/1323970
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#566}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 7

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20880e5f7d93bae1d925d8e44e1e63e2ab545a5e

commit 20880e5f7d93bae1d925d8e44e1e63e2ab545a5e
Author: John Chen <johnchen@chromium.org>
Date: Wed Nov 07 17:53:52 2018

[ChromeDriver] Fix W3C Element Send Keys

In W3C mode, Element Send Keys command should get keys from string
property "text", instead of list property "value".

Bug:  chromium:902770 ,  chromedriver:2649 
Change-Id: I68b915ad572c289364d797aa34496b2278cb3997
Reviewed-on: https://chromium-review.googlesource.com/c/1320208
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#605848}(cherry picked from commit 23ce277b6d5ce7e87ab9660fc3564b96908440b4)
Reviewed-on: https://chromium-review.googlesource.com/c/1323970
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#566}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/20880e5f7d93bae1d925d8e44e1e63e2ab545a5e/chrome/test/chromedriver/client/chromedriver.py
[modify] https://crrev.com/20880e5f7d93bae1d925d8e44e1e63e2ab545a5e/chrome/test/chromedriver/client/webelement.py
[modify] https://crrev.com/20880e5f7d93bae1d925d8e44e1e63e2ab545a5e/chrome/test/chromedriver/element_commands.cc
[modify] https://crrev.com/20880e5f7d93bae1d925d8e44e1e63e2ab545a5e/chrome/test/chromedriver/test/run_py_tests.py

Comment 5 by johnchen@chromium.org, Nov 7

Status: Fixed (was: Assigned)
►

Sign in to add a comment