New issue
Advanced search Search tips

Issue 902767 link

Starred by 0 users
Status: Fixed
Owner:
johnchen@chromium.org
Closed: Nov 7
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Merge request for ChromeDriver get window handle bug fix

Project Member Reported by johnchen@chromium.org, Nov 7 
Requesting merge of two CLs that fix a bug in ChromeDriver's "get window handle" command to m71 branch:

* https://chromium-review.googlesource.com/1289069, which reverts a previous incorrect fix (the incorrect fix was made before m71 branch, but the revert happened after m71 branch).

* https://chromium-review.googlesource.com/1289690, which is the corrected bug fix.

Note that these changes are in ChromeDriver directory (src/chrome/test/chromedriver), and Chrome does not depend on that at all, so these will have no impact on Chrome binary that is shipping. See go/chromedriver-versioning and go/chops-proj-rev-27 for background.
Project Member

Comment 1 by sheriffbot@chromium.org, Nov 7

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by gov...@chromium.org, Nov 7

Labels: -Merge-Review-71 Merge-Approved-71
Approving merge to M71 branch 3578 based on comment #0. Pls merge ASAP. Thank you.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 7

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/300e69108c39e8222457083050bbc2f03402c2be

commit 300e69108c39e8222457083050bbc2f03402c2be
Author: Tatiana Buldina <buldina@chromium.org>
Date: Wed Nov 07 17:58:39 2018

Revert "[ChromeDriver] Do not return stale window handle"

This reverts commit 6a308947a77ac209440d2a124ef8e64d0aa9de32.

Reason for revert: Caused  https://crbug.com/chromedriver/2615 

Original change's description:
> [ChromeDriver] Do not return stale window handle
>
> Move ExecuteGetCurrentWindowHandle() from session_commands.cc
> to window_commands.cc, to make use of automatic window state
> validation done for window commands.
>
> Bug:  chromedriver:1404 
> Change-Id: Id5ac4c7cea5323f12612b2dfb4dff2b819ce22ff
> Reviewed-on: https://chromium-review.googlesource.com/1257362
> Reviewed-by: John Chen <johnchen@chromium.org>
> Commit-Queue: Tatiana Buldina <buldina@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#595938}

Bug:  chromium:902767   chromedriver:1404   chromedriver:2615 
Change-Id: I7b8605d8f83536e0ebcdae4fe8f628fe1de80d1b
Reviewed-on: https://chromium-review.googlesource.com/c/1289069
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600857}(cherry picked from commit 29a5178ccd487c77b5682b6f45d05be7ba494fdf)
Reviewed-on: https://chromium-review.googlesource.com/c/1323898
Cr-Commit-Position: refs/branch-heads/3578@{#568}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/300e69108c39e8222457083050bbc2f03402c2be/chrome/test/chromedriver/session_commands.cc
[modify] https://crrev.com/300e69108c39e8222457083050bbc2f03402c2be/chrome/test/chromedriver/session_commands.h
[modify] https://crrev.com/300e69108c39e8222457083050bbc2f03402c2be/chrome/test/chromedriver/window_commands.cc
[modify] https://crrev.com/300e69108c39e8222457083050bbc2f03402c2be/chrome/test/chromedriver/window_commands.h
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e67a883968755feb3bc31b2aa6c8b8fe596b6d99

commit e67a883968755feb3bc31b2aa6c8b8fe596b6d99
Author: Tatiana Buldina <buldina@chromium.org>
Date: Wed Nov 07 18:00:42 2018

[ChromeDriver] Do not return stale window handle

Bug:  chromium:902767   chromedriver:1404 
Change-Id: Ic4c23921a253584f9b3b29deb7a02398f43f574e
Reviewed-on: https://chromium-review.googlesource.com/c/1289690
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600982}(cherry picked from commit 6b696ca27382ebc1476c912cb1739e0ee9266512)
Reviewed-on: https://chromium-review.googlesource.com/c/1323899
Cr-Commit-Position: refs/branch-heads/3578@{#569}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/e67a883968755feb3bc31b2aa6c8b8fe596b6d99/chrome/test/chromedriver/session_commands.cc

Comment 5 by johnchen@chromium.org, Nov 7

Status: Fixed (was: Assigned)
►

Sign in to add a comment