New issue
Advanced search Search tips

Issue 902759 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

FF Meta font broken

Project Member Reported by bunge...@chromium.org, Nov 7

Issue description

Chrome Version: 71
OS: Linux

What steps will reproduce the problem?
(1) https://www.axis-praxis.org/specimens/ff-meta

What is the expected result?
Italic should have spaces.

What happens instead?
Italic has no spaces.



Please use labels and text to provide additional information.

Bisected to FreeType roll at b8cda65cc66bf6220a1a1b2c149804a9a4a1ea50 .
 
Opened https://savannah.nongnu.org/bugs/?54973

fixed with

https://chromium.googlesource.com/chromium/src/third_party/freetype2/+/fb0d66d04c4dd8d7f9604af1a6001b2737cb5098

will need to roll FreeType to pick up the change, and will need to cherry-pick this fix to m71, which should be the only branch currently affected.
Labels: M-71
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52a4a2068a647b298491501dfcb8634e6cd63a26

commit 52a4a2068a647b298491501dfcb8634e6cd63a26
Author: Ben Wagner <bungeman@chromium.org>
Date: Thu Nov 08 10:00:09 2018

Roll src/third_party/freetype/src/ f56830ed4..fb0d66d04 (20 commits)

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/f56830ed406f..fb0d66d04c4d

$ git log f56830ed4..fb0d66d04 --date=short --no-merges --format='%ad %ae %s'
2018-11-07 bungeman [truetype] Fix VF check from 2018-09-12 (#54973).
2018-11-06 wl [pshinter] Fix numeric overflow.
2018-11-06 wl [psaux] Fix timeout in old CFF engine.
2018-11-04 apodtele Minor.
2018-11-04 apodtele * src/truetype/ttgxvar.c: Use enum definitions.
2018-11-03 apodtele * src/truetype/ttgxvar.c (ft_var_apply_tuple): Adjust condition.
2018-11-03 apodtele * src/truetype/ttgxvar.c (ft_var_apply_tuple): Tracing tweaks.
2018-11-03 apodtele Revert due to specs: [truetype] Speed up variation IUP.
2018-11-03 apodtele Revert "[truetype] Speed up variation IUP."
2018-11-02 apodtele * src/truetype/ttgxvar.c (ft_var_get_item_delta): Fixed logic.
2018-11-02 shailesh.mistry [autofit] Prevent SEGV.
2018-10-31 apodtele [truetype] Speed up variation IUP.
2018-10-31 apodtele * src/type1/t1load.c (t1_set_mm_blend): Optimized.
2018-10-31 apodtele * src/truetype/ttgxvar.c (ft_var_get_item_delta): Optimized.
2018-10-29 wl [base] Fix numeric overflow.
2018-10-29 wl [cff] Fix numeric overflow.
2018-10-28 apodtele Comment on timestamp storage.
2018-10-26 apodtele [sfnt] Make `head' timestamps unsigned.
2018-10-26 apodtele Revert "Align FreeType with standard C memory management."
2018-10-27 wl [psaux] Fix numeric overflow.

Created with:
  roll-dep src/third_party/freetype/src
R=bungeman@chromium.org,drott@chromium.org

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng

PDFium-Issue:  pdfium:1191 
Bug:  chromium:902759 
Change-Id: I9cecc7b01263a068b81e7692962cd92ec60fccc6
Reviewed-on: https://chromium-review.googlesource.com/c/1323793
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606399}
[modify] https://crrev.com/52a4a2068a647b298491501dfcb8634e6cd63a26/DEPS
[modify] https://crrev.com/52a4a2068a647b298491501dfcb8634e6cd63a26/third_party/freetype/README.chromium

Labels: -Pri-3 Merge-Request-71 OS-Android OS-Chrome OS-Linux Pri-2
Requesting merge of https://chromium.googlesource.com/chromium/src/third_party/freetype2/+/fb0d66d04c4dd8d7f9604af1a6001b2737cb5098 (along with a few small security fixes) to M71, which would mean landing this roll of FreeType https://chromium-review.googlesource.com/c/chromium/src/+/1327228 to branch 3578.

These changes are in 72.0.3606.0 and have been observed to fix the issue.

The effect of the issue being fixed here is that certain variable fonts will have random glyphs not draw (as if the glyph data were corrupted). This was discovered on axis-praxis, which is a fairly high profile font design site, so we would like to not ship M71 to stable with this issue.


Project Member

Comment 6 by sheriffbot@chromium.org, Nov 9

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-71 Merge-Approved-71
Approving merge to M71 branch 3578 based on comment #5. Please merge ASAP.
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 9

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98c4299f0cc0aa31c1b3d277e0d150d735d32b69

commit 98c4299f0cc0aa31c1b3d277e0d150d735d32b69
Author: Ben Wagner <bungeman@chromium.org>
Date: Fri Nov 09 19:24:18 2018

Roll src/third_party/freetype/src/ abd997aa7..df0548839 (13 commits)

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/abd997aa7cf2..df05488392ff

$ git log abd997aa7..df0548839 --date=short --no-merges --format='%ad %ae %s'
2018-11-08 apodtele [ftstroke] Fix unpredictable failures (#54976).
2018-11-07 bungeman [truetype] Fix VF check from 2018-09-12 (#54973).
2018-11-06 wl [pshinter] Fix numeric overflow.
2018-11-06 wl [psaux] Fix timeout in old CFF engine.
2018-10-29 wl [base] Fix numeric overflow.
2018-10-29 wl [cff] Fix numeric overflow.
2018-10-27 wl [psaux] Fix numeric overflow.
2018-10-07 wl A missing Unicode cmap is not a fatal error.
2018-10-07 wl Fix handling of FT_CONFIG_OPTION_ADOBE_GLYPH_LIST (#54794).
2018-10-02 wl [psaux] Fix segfault.
2018-10-02 wl [psaux] Fix numeric overflow.
2018-10-02 wl [pshinter] Handle numeric overflow.
2018-09-25 wl Fix handing of `FT_Bool'.

Created with:
  roll-dep src/third_party/freetype/src
R=bungeman@chromium.org,drott@chromium.org

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng

PDFium-Issue: pdfium:
Bug:  chromium:902759 
Approval: https://bugs.chromium.org/p/chromium/issues/detail?id=902759#c7
Change-Id: I796df494574cbb6809dbb5dd891d8dea8168aa4d
Reviewed-on: https://chromium-review.googlesource.com/c/1327228
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#616}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/98c4299f0cc0aa31c1b3d277e0d150d735d32b69/DEPS
[modify] https://crrev.com/98c4299f0cc0aa31c1b3d277e0d150d735d32b69/third_party/freetype/README.chromium

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/98c4299f0cc0aa31c1b3d277e0d150d735d32b69

Commit: 98c4299f0cc0aa31c1b3d277e0d150d735d32b69
Author: bungeman@chromium.org
Commiter: bungeman@chromium.org
Date: 2018-11-09 19:24:18 +0000 UTC

Roll src/third_party/freetype/src/ abd997aa7..df0548839 (13 commits)

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/abd997aa7cf2..df05488392ff

$ git log abd997aa7..df0548839 --date=short --no-merges --format='%ad %ae %s'
2018-11-08 apodtele [ftstroke] Fix unpredictable failures (#54976).
2018-11-07 bungeman [truetype] Fix VF check from 2018-09-12 (#54973).
2018-11-06 wl [pshinter] Fix numeric overflow.
2018-11-06 wl [psaux] Fix timeout in old CFF engine.
2018-10-29 wl [base] Fix numeric overflow.
2018-10-29 wl [cff] Fix numeric overflow.
2018-10-27 wl [psaux] Fix numeric overflow.
2018-10-07 wl A missing Unicode cmap is not a fatal error.
2018-10-07 wl Fix handling of FT_CONFIG_OPTION_ADOBE_GLYPH_LIST (#54794).
2018-10-02 wl [psaux] Fix segfault.
2018-10-02 wl [psaux] Fix numeric overflow.
2018-10-02 wl [pshinter] Handle numeric overflow.
2018-09-25 wl Fix handing of `FT_Bool'.

Created with:
  roll-dep src/third_party/freetype/src
R=bungeman@chromium.org,drott@chromium.org

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng

PDFium-Issue: pdfium:
Bug:  chromium:902759 
Approval: https://bugs.chromium.org/p/chromium/issues/detail?id=902759#c7
Change-Id: I796df494574cbb6809dbb5dd891d8dea8168aa4d
Reviewed-on: https://chromium-review.googlesource.com/c/1327228
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#616}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Status: Fixed (was: Started)
Observed fixed behavior in 71.0.3578.50.
Cc: viswa.karala@chromium.org
Labels: TE-Verified-M71 TE-Verified-71.0.3578.53
Able to reproduce the issue on chrome version# 71.0.3571.0
Verified the fix on Ubuntu 14.04 on Chrome version #71.0.3578.53 as per the comment#0
Attaching screen cast for reference.
Observed "Spacing between Italic words"
Hence, the fix is working as expected.
Adding the verified label.

Thanks!


902759.ogv
1.7 MB View Download

Sign in to add a comment