New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 902718 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Nov 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

33.5% regression in rendering.desktop/tasks_per_frame_total_all at 605676:605722

Project Member Reported by xidac...@chromium.org, Nov 7

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=902718

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=ee66a668f7af1ae3f16706fdc7b82e57480c8d549bb650f0f1615ca230e7aeee


Bot(s) for this bug's original alert(s):

linux-perf

rendering.desktop - Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Cc: chiniforooshan@chromium.org
Owner: chiniforooshan@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1718eae9e40000

Telemetry: finally move rendering to TBMv2 by chiniforooshan@chromium.org
https://chromium.googlesource.com/chromium/src/+/05af02c8afe6a0fdc3d5e32ff88632fa15f5c567
tasks_per_frame_total_all: 144.1 → 193.2 (+49.17)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Status: WontFix (was: Assigned)
This is expected: we changed the meaning of frame, in tasks_per_frame metrics from renderer compositor frames to display compositor frames.

So, we expect a change of roughly frame_times / mean_frame_time_renderer_compositor in tasks_per_frame metrics which is exactly what is happening here:

https://chromeperf.appspot.com/report?sid=c3f545764891fc9aa77d21655f3d83e2671dd0719ad7c50c1adf4a3df288d9d3&start_rev=603707&end_rev=606023

The last value of frame_times / mean_frame_time_renderer_compositor was 17.3638 / 13.4521 = 1.2908

The change in tasks_per_frame is 188.981 / 146.153 = 1.2930, which is very close to the expected change.
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/16f8f7d1e40000

Telemetry: finally move rendering to TBMv2 by chiniforooshan@chromium.org
https://chromium.googlesource.com/chromium/src/+/05af02c8afe6a0fdc3d5e32ff88632fa15f5c567
tasks_per_frame_total_all: 144.7 → 191.9 (+47.24)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Cc: alexclarke@chromium.org
 Issue 903755  has been merged into this issue.

Sign in to add a comment