New issue
Advanced search Search tips

Issue 902717 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

DCHECK failure in HammardClientImpl::OnPairChallengeSucceeded

Project Member Reported by osh...@chromium.org, Nov 7

Issue description

I encountered this when I tried to run debug build on Slate.

chrome: ToT {#605939}
platform: 11231.0.0

[23225:23225:1107/070438.304603:FATAL:hammerd_client.cc(118)] Check failed: signal->GetMember() == hammerd::kBaseFirmwareNeedUpdateSignal (PairChallengeSucceeded vs. BaseFirmwareNeedUpdate)
#0 0x7e7fb8c81e38 base::debug::StackTrace::StackTrace()
#1 0x7e7fb894cbdc base::debug::StackTrace::StackTrace()
#2 0x7e7fb89be89a logging::LogMessage::~LogMessage()
#3 0x7e7fa5731109 chromeos::(anonymous namespace)::HammerdClientImpl::OnPairChallengeSucceeded()
#4 0x7e7fa5731c92 _ZN4base8internal13FunctorTraitsIMN8chromeos12_GLOBAL__N_117HammerdClientImplEFvPN4dbus6SignalEEvE6InvokeIS9_RKNS_7WeakPtrIS4_EEJS7_EEEvT_OT0_DpOT1_
#5 0x7e7fa5731b95 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN8chromeos12_GLOBAL__N_117HammerdClientImplEFvPN4dbus6SignalEERKNS_7WeakPtrIS6_EEJS9_EEEvOT_OT0_DpOT1_
#6 0x7e7fa5731b10 _ZN4base8internal7InvokerINS0_9BindStateIMN8chromeos12_GLOBAL__N_117HammerdClientImplEFvPN4dbus6SignalEEJNS_7WeakPtrIS5_EEEEEFvS8_EE7RunImplIRKSA_RKNSt3__15tupleIJSC_EEEJLm0EEEEvOT_OT0_NSJ_16integer_sequenceImJXspT1_EEEEOS8_
#7 0x7e7fa5731a2b _ZN4base8internal7InvokerINS0_9BindStateIMN8chromeos12_GLOBAL__N_117HammerdClientImplEFvPN4dbus6SignalEEJNS_7WeakPtrIS5_EEEEEFvS8_EE3RunEPNS0_13BindStateBaseES8_
#8 0x7e7fa5308e0a _ZNKR4base17RepeatingCallbackIFvPN4dbus6SignalEEE3RunES3_
#9 0x7e7fa5307319 dbus::ObjectProxy::RunMethod()
#10 0x7e7fa53107a0 _ZN4base8internal13FunctorTraitsIMN4dbus11ObjectProxyEFvNS_9TimeTicksENSt3__16vectorINS_17RepeatingCallbackIFvPNS2_6SignalEEEENS5_9allocatorISB_EEEES9_EvE6InvokeISG_RK13scoped_refptrIS3_EJRKS4_RKSE_RKS9_EEEvT_OT0_DpOT1_
#11 0x7e7fa531068a _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN4dbus11ObjectProxyEFvNS_9TimeTicksENSt3__16vectorINS_17RepeatingCallbackIFvPNS4_6SignalEEEENS7_9allocatorISD_EEEESB_EJRK13scoped_refptrIS5_ERKS6_RKSG_RKSB_EEEvOT_DpOT0_
#12 0x7e7fa53105f2 _ZN4base8internal7InvokerINS0_9BindStateIMN4dbus11ObjectProxyEFvNS_9TimeTicksENSt3__16vectorINS_17RepeatingCallbackIFvPNS3_6SignalEEEENS6_9allocatorISC_EEEESA_EJ13scoped_refptrIS4_ES5_SF_SA_EEEFvvEE7RunImplIRKSH_RKNS6_5tupleIJSJ_S5_SF_SA_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NS6_16integer_sequenceImJXspT1_EEEE
#13 0x7e7fa531043c _ZN4base8internal7InvokerINS0_9BindStateIMN4dbus11ObjectProxyEFvNS_9TimeTicksENSt3__16vectorINS_17RepeatingCallbackIFvPNS3_6SignalEEEENS6_9allocatorISC_EEEESA_EJ13scoped_refptrIS4_ES5_SF_SA_EEEFvvEE3RunEPNS0_13BindStateBaseE
#14 0x7e7fb88f7bbc _ZNO4base12OnceCallbackIFvvEE3RunEv
#15 0x7e7fb894e358 base::debug::TaskAnnotator::RunTask()
#16 0x7e7fb89ea816 base::MessageLoopImpl::RunTask()
#17 0x7e7fb89eabbe base::MessageLoopImpl::DeferOrRunPendingTask()
#18 0x7e7fb89eb389 base::MessageLoopImpl::DoWork()
#19 0x7e7fb8cda315 base::MessagePumpLibevent::Run()
#20 0x7e7fb89e9f0b base::MessageLoopImpl::Run()
#21 0x7e7fb8a9da7d base::RunLoop::Run()
#22 0x5bf33e43d9b3 ChromeBrowserMainParts::MainMessageLoopRun()
#23 0x7e7fb218e691 content::BrowserMainLoop::RunMainMessageLoopParts()
#24 0x7e7fb2197aa0 content::BrowserMainRunnerImpl::Run()
#25 0x7e7fb218102b content::BrowserMain()
#26 0x7e7fb478b877 content::RunBrowserProcessMain()
#27 0x7e7fb478ef33 content::ContentMainRunnerImpl::RunServiceManager()
#28 0x7e7fb478daaf content::ContentMainRunnerImpl::Run()
#29 0x7e7fb4782d1c content::ContentServiceManagerMainDelegate::RunEmbedderProcess()
#30 0x7e7f84049f5a service_manager::Main()
#31 0x7e7fb4789213 content::ContentMain()
#32 0x5bf33a1b8858 ChromeMain
#33 0x5bf33a1b8742 main
#34 0x7e7f8615f736 __libc_start_main
#35 0x5bf33a1b85e9 _start

 
Also ran into this, looks like in
https://cs.chromium.org/chromium/src/chromeos/dbus/hammerd_client.cc
the DCHECKs in callbacks does not correspond to connected signals.
Owner: shaochuan@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/330ebc0b5730376a591e6c022a853645988f52c4

commit 330ebc0b5730376a591e6c022a853645988f52c4
Author: Shao-Chuan Lee <shaochuan@chromium.org>
Date: Tue Nov 13 09:27:44 2018

Fix DCHECKs in HammerdClient D-Bus callbacks

DCHECKs in callbacks did not match corresponding signals.

Bug:  902717 
Change-Id: I1fb9385ce0360445593c1c1b095706dfcd4821dc
Reviewed-on: https://chromium-review.googlesource.com/c/1331092
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607531}
[modify] https://crrev.com/330ebc0b5730376a591e6c022a853645988f52c4/chromeos/dbus/hammerd_client.cc

Status: Started (was: Untriaged)
oshima@: Could you verify if it's fixed?
yes, looks like it's fixed. thank you!
Status: Fixed (was: Started)

Sign in to add a comment