New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 902716 link

Starred by 1 user
Status: Fixed
Owner:
fhorschig@chromium.org
Closed: Nov 8
Cc:
█ nepper@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 853794



Sign in to add a comment

Keyboard accessory keeps deleted password even after simple reload

Project Member Reported by fhorschig@chromium.org, Nov 7 
What steps will reproduce the problem?
(1) Navigate to any site with saved credentials
(2) Focus a password field, open the sheet, navigate to "Manage passwords..."
(3) Delete a password
(4) Reload the page
(5) Focus the password field and open the sheet

What is the expected result?
The deleted password is gone.

What happens instead?
The deleted password persists, even after reload.
Should be gone after (3) and at the very latest after (5).

Comment 1 by fhorschig@chromium.org, Nov 7 

Debugging progress:
 - Only the last password survives a reload.
 - The UI-code behaves exactly as intended. 

There seems to be an update missing after the password was deleted (i.e. a new call to ChromePasswordManagerClient::PasswordWasAutofilled).

Comment 2 by fhorschig@chromium.org, Nov 7 

It makes sense that there is no call: Why would the client report autofill data if no data is available [anymore]?
The solution could be to figure out a good point to reset clear all suggestions --> this could also resolve issue 888933.

Comment 3 by gov...@chromium.org, Nov 7 

Pls apply appropriate OSs label.

Comment 4 by fhorschig@chromium.org, Nov 7

Labels: -Pri-3 OS-Android Pri-1
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50e04ea75fbeaa365f45a817a93480e264a66506

commit 50e04ea75fbeaa365f45a817a93480e264a66506
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Thu Nov 08 15:49:13 2018

Clear keyboard accessory suggestions on reload

Before this CL, the accessory would only clear the accessory suggestions
when the origin changes during a navigation or when new suggestions
overwrite the existing ones.
With this CL, the accessory also clears the suggestions when a reload
was the reason for a page navigation.

Bug:  902716 
Change-Id: I897dd774a31676adb4aede8fc4016446f058ffa0
Reviewed-on: https://chromium-review.googlesource.com/c/1323712
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606476}
[modify] https://crrev.com/50e04ea75fbeaa365f45a817a93480e264a66506/chrome/browser/password_manager/password_accessory_controller.cc

Comment 6 by fhorschig@chromium.org, Nov 8

Labels: Merge-Request-71
Status: Fixed (was: Started)
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 8

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by benmason@chromium.org, Nov 8

Labels: -Hotlist-Merge-Review -Merge-Review-71 Merge-Approved-71
Approved for merge to 71, branch 3578.
Project Member

Comment 9 by cr-audit...@appspot.gserviceaccount.com, Nov 9

Labels: -Merge-Approved-71 Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/a0cb7ea86e413f5e250f2e4bc9fda930a64c81e2

Commit: a0cb7ea86e413f5e250f2e4bc9fda930a64c81e2
Author: fhorschig@chromium.org
Commiter: fhorschig@chromium.org
Date: 2018-11-09 09:23:38 +0000 UTC

Clear keyboard accessory suggestions on reload

Before this CL, the accessory would only clear the accessory suggestions
when the origin changes during a navigation or when new suggestions
overwrite the existing ones.
With this CL, the accessory also clears the suggestions when a reload
was the reason for a page navigation.

Bug:  902716 
Change-Id: I897dd774a31676adb4aede8fc4016446f058ffa0
Reviewed-on: https://chromium-review.googlesource.com/c/1323712
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#606476}(cherry picked from commit 50e04ea75fbeaa365f45a817a93480e264a66506)
Reviewed-on: https://chromium-review.googlesource.com/c/1328822
Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#606}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 9

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0cb7ea86e413f5e250f2e4bc9fda930a64c81e2

commit a0cb7ea86e413f5e250f2e4bc9fda930a64c81e2
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Fri Nov 09 09:23:38 2018

Clear keyboard accessory suggestions on reload

Before this CL, the accessory would only clear the accessory suggestions
when the origin changes during a navigation or when new suggestions
overwrite the existing ones.
With this CL, the accessory also clears the suggestions when a reload
was the reason for a page navigation.

Bug:  902716 
Change-Id: I897dd774a31676adb4aede8fc4016446f058ffa0
Reviewed-on: https://chromium-review.googlesource.com/c/1323712
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#606476}(cherry picked from commit 50e04ea75fbeaa365f45a817a93480e264a66506)
Reviewed-on: https://chromium-review.googlesource.com/c/1328822
Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#606}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/a0cb7ea86e413f5e250f2e4bc9fda930a64c81e2/chrome/browser/password_manager/password_accessory_controller.cc
►

Sign in to add a comment