New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 902713 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug

Blocking:
issue 906293



Sign in to add a comment

NOTREACHED in GetStringFromOncDictionary

Project Member Reported by osh...@chromium.org, Nov 7

Issue description

I hit this DCHECK when I run debug build on slate. (I had to disable two other DCHECKs to reach this tho)

[14837:14837:1107/064455.768752:FATAL:arc_net_host_impl.cc(68)] Check failed: false. Required parameter Type was not found.
#0 0x7f5cddbe7e38 base::debug::StackTrace::StackTrace()
#1 0x7f5cdd8b2bdc base::debug::StackTrace::StackTrace()
#2 0x7f5cdd92489a logging::LogMessage::~LogMessage()
#3 0x5c592f634303 (anonymous namespace)::GetStringFromOncDictionary()
#4 0x5c592f63556c (anonymous namespace)::TranslateONCIPConfig()
#5 0x5c592f63453a (anonymous namespace)::TranslateONCIPConfigs()
#6 0x5c592f62a99c (anonymous namespace)::TranslateONCConfiguration()
#7 0x5c592f62e6ad (anonymous namespace)::GetDefaultNetworkSuccessCallback()
#8 0x5c5928194b9a _ZN4base8internal13FunctorTraitsIPFvNS_12OnceCallbackIFvN10extensions23declarative_net_request26IndexAndPersistRulesResultEEEERKNSt3__112basic_stringIcNS8_11char_traitsIcEENS8_9allocatorIcEEEESG_EvE6InvokeIRKSI_JRKNS_17RepeatingCallbackIS6_EESG_SG_EEEvOT_DpOT0_
#9 0x5c592f642add _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKPFvNS_12OnceCallbackIFvN4mojo9StructPtrIN3arc5mojom20NetworkConfigurationEEESA_EEERKNSt3__112basic_stringIcNSD_11char_traitsIcEENSD_9allocatorIcEEEERKNS_15DictionaryValueEEJRKNS_17RepeatingCallbackISB_EESL_SO_EEEvOT_DpOT0_
#10 0x5c592f642a80 _ZN4base8internal7InvokerINS0_9BindStateIPFvNS_12OnceCallbackIFvN4mojo9StructPtrIN3arc5mojom20NetworkConfigurationEEES9_EEERKNSt3__112basic_stringIcNSC_11char_traitsIcEENSC_9allocatorIcEEEERKNS_15DictionaryValueEEJNS_17RepeatingCallbackISA_EEEEEFvSK_SN_EE7RunImplIRKSP_RKNSC_5tupleIJSR_EEEJLm0EEEEvOT_OT0_NSC_16integer_sequenceImJXspT1_EEEESK_SN_
#11 0x5c592f6429a4 _ZN4base8internal7InvokerINS0_9BindStateIPFvNS_12OnceCallbackIFvN4mojo9StructPtrIN3arc5mojom20NetworkConfigurationEEES9_EEERKNSt3__112basic_stringIcNSC_11char_traitsIcEENSC_9allocatorIcEEEERKNS_15DictionaryValueEEJNS_17RepeatingCallbackISA_EEEEEFvSK_SN_EE3RunEPNS0_13BindStateBaseESK_SN_
#12 0x7f5cca668110 _ZNKR4base17RepeatingCallbackIFvRKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEES9_EE3RunES9_S9_
#13 0x7f5cca7b285a chromeos::ManagedNetworkConfigurationHandlerImpl::SendProperties()
#14 0x7f5cca7c1108 _ZN4base8internal13FunctorTraitsIMN8chromeos38ManagedNetworkConfigurationHandlerImplEFvRKNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEERKNS_17RepeatingCallbackIFvSC_RKNS_15DictionaryValueEEEERKNSD_IFvSC_NS4_10unique_ptrISE_NS4_14default_deleteISE_EEEEEEESC_SO_EvE6InvokeISU_RKNS_7WeakPtrIS3_EEJSC_SK_SS_SC_SO_EEEvT_OT0_DpOT1_
#15 0x7f5cca7c0e8c _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN8chromeos38ManagedNetworkConfigurationHandlerImplEFvRKNSt3__112basic_stringIcNS6_11char_traitsIcEENS6_9allocatorIcEEEERKNS_17RepeatingCallbackIFvSE_RKNS_15DictionaryValueEEEERKNSF_IFvSE_NS6_10unique_ptrISG_NS6_14default_deleteISG_EEEEEEESE_SQ_ERKNS_7WeakPtrIS5_EEJSE_SM_SU_SE_SQ_EEEvOT_OT0_DpOT1_
#16 0x7f5cca7c0d98 _ZN4base8internal7InvokerINS0_9BindStateIMN8chromeos38ManagedNetworkConfigurationHandlerImplEFvRKNSt3__112basic_stringIcNS5_11char_traitsIcEENS5_9allocatorIcEEEERKNS_17RepeatingCallbackIFvSD_RKNS_15DictionaryValueEEEERKNSE_IFvSD_NS5_10unique_ptrISF_NS5_14default_deleteISF_EEEEEEESD_SP_EJNS_7WeakPtrIS4_EESB_SJ_SR_EEESQ_E7RunImplIRKSV_RKNS5_5tupleIJSX_SB_SJ_SR_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NS5_16integer_sequenceImJXspT1_EEEESD_OSP_
#17 0x7f5cca7c0b94 _ZN4base8internal7InvokerINS0_9BindStateIMN8chromeos38ManagedNetworkConfigurationHandlerImplEFvRKNSt3__112basic_stringIcNS5_11char_traitsIcEENS5_9allocatorIcEEEERKNS_17RepeatingCallbackIFvSD_RKNS_15DictionaryValueEEEERKNSE_IFvSD_NS5_10unique_ptrISF_NS5_14default_deleteISF_EEEEEEESD_SP_EJNS_7WeakPtrIS4_EESB_SJ_SR_EEESQ_E3RunEPNS0_13BindStateBaseESD_OSP_
#18 0x7f5cca7bffdd _ZNKR4base17RepeatingCallbackIFvRKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEENS1_10unique_ptrINS_15DictionaryValueENS1_14default_deleteISB_EEEEEE3RunES9_SE_
#19 0x7f5cca7b0ca6 chromeos::ManagedNetworkConfigurationHandlerImpl::GetPropertiesCallback()
#20 0x7f5cca7c1d07 _ZN4base8internal13FunctorTraitsIMN8chromeos38ManagedNetworkConfigurationHandlerImplEFvNS_17RepeatingCallbackIFvRKNSt3__112basic_stringIcNS5_11char_traitsIcEENS5_9allocatorIcEEEENS5_10unique_ptrINS_15DictionaryValueENS5_14default_deleteISF_EEEEEEESD_RKSF_EvE6InvokeISO_RKNS_7WeakPtrIS3_EEJRKSK_SD_SM_EEEvT_OT0_DpOT1_
#21 0x7f5cca7c1c15 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN8chromeos38ManagedNetworkConfigurationHandlerImplEFvNS_17RepeatingCallbackIFvRKNSt3__112basic_stringIcNS7_11char_traitsIcEENS7_9allocatorIcEEEENS7_10unique_ptrINS_15DictionaryValueENS7_14default_deleteISH_EEEEEEESF_RKSH_ERKNS_7WeakPtrIS5_EEJRKSM_SF_SO_EEEvOT_OT0_DpOT1_
#22 0x7f5cca7c1b70 _ZN4base8internal7InvokerINS0_9BindStateIMN8chromeos38ManagedNetworkConfigurationHandlerImplEFvNS_17RepeatingCallbackIFvRKNSt3__112basic_stringIcNS6_11char_traitsIcEENS6_9allocatorIcEEEENS6_10unique_ptrINS_15DictionaryValueENS6_14default_deleteISG_EEEEEEESE_RKSG_EJNS_7WeakPtrIS4_EESL_EEEFvSE_SN_EE7RunImplIRKSP_RKNS6_5tupleIJSR_SL_EEEJLm0ELm1EEEEvOT_OT0_NS6_16integer_sequenceImJXspT1_EEEESE_SN_
#23 0x7f5cca7c1a54 _ZN4base8internal7InvokerINS0_9BindStateIMN8chromeos38ManagedNetworkConfigurationHandlerImplEFvNS_17RepeatingCallbackIFvRKNSt3__112basic_stringIcNS6_11char_traitsIcEENS6_9allocatorIcEEEENS6_10unique_ptrINS_15DictionaryValueENS6_14default_deleteISG_EEEEEEESE_RKSG_EJNS_7WeakPtrIS4_EESL_EEEFvSE_SN_EE3RunEPNS0_13BindStateBaseESE_SN_
#24 0x7f5cca668110 _ZNKR4base17RepeatingCallbackIFvRKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEES9_EE3RunES9_S9_
#25 0x7f5cca7ee9ca chromeos::NetworkConfigurationHandler::GetPropertiesCallback()
#26 0x7f5cca7f9f8f _ZN4base8internal13FunctorTraitsIMN8chromeos27NetworkConfigurationHandlerEFvRKNS_17RepeatingCallbackIFvRKNSt3__112basic_stringIcNS5_11char_traitsIcEENS5_9allocatorIcEEEERKNS_15DictionaryValueEEEERKNS4_IFvSD_NS5_10unique_ptrISE_NS5_14default_deleteISE_EEEEEEESD_NS2_20DBusMethodCallStatusESG_EvE6InvokeISV_RKNS_7WeakPtrIS3_EEJSK_SS_SD_ST_SG_EEEvT_OT0_DpOT1_
#27 0x7f5cca7f9e8c _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN8chromeos27NetworkConfigurationHandlerEFvRKNS_17RepeatingCallbackIFvRKNSt3__112basic_stringIcNS7_11char_traitsIcEENS7_9allocatorIcEEEERKNS_15DictionaryValueEEEERKNS6_IFvSF_NS7_10unique_ptrISG_NS7_14default_deleteISG_EEEEEEESF_NS4_20DBusMethodCallStatusESI_ERKNS_7WeakPtrIS5_EEJSM_SU_SF_SV_SI_EEEvOT_OT0_DpOT1_
#28 0x7f5cca7f9d98 _ZN4base8internal7InvokerINS0_9BindStateIMN8chromeos27NetworkConfigurationHandlerEFvRKNS_17RepeatingCallbackIFvRKNSt3__112basic_stringIcNS6_11char_traitsIcEENS6_9allocatorIcEEEERKNS_15DictionaryValueEEEERKNS5_IFvSE_NS6_10unique_ptrISF_NS6_14default_deleteISF_EEEEEEESE_NS3_20DBusMethodCallStatusESH_EJNS_7WeakPtrIS4_EESJ_SR_SC_EEEFvSU_SH_EE7RunImplIRKSW_RKNS6_5tupleIJSY_SJ_SR_SC_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NS6_16integer_sequenceImJXspT1_EEEEOSU_SH_
#29 0x7f5cca7f9b72 _ZN4base8internal7InvokerINS0_9BindStateIMN8chromeos27NetworkConfigurationHandlerEFvRKNS_17RepeatingCallbackIFvRKNSt3__112basic_stringIcNS6_11char_traitsIcEENS6_9allocatorIcEEEERKNS_15DictionaryValueEEEERKNS5_IFvSE_NS6_10unique_ptrISF_NS6_14default_deleteISF_EEEEEEESE_NS3_20DBusMethodCallStatusESH_EJNS_7WeakPtrIS4_EESJ_SR_SC_EEEFvSU_SH_EE3RunEPNS0_13BindStateBaseESU_SH_
#30 0x7f5cca3acfa8 _ZNKR4base17RepeatingCallbackIFvN8chromeos11attestation17AttestationStatusERKNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEEEE3RunES3_SC_
#31 0x7f5cca701682 _ZN4base8internal13FunctorTraitsINS_17RepeatingCallbackIFvN8chromeos20DBusMethodCallStatusERKNS_15DictionaryValueEEEEvE6InvokeIRKS9_JRKS4_S7_EEEvOT_DpOT0_
#32 0x7f5cca70156d _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKNS_17RepeatingCallbackIFvN8chromeos20DBusMethodCallStatusERKNS_15DictionaryValueEEEEJRKS6_S9_EEEvOT_DpOT0_
#33 0x7f5cca701520 _ZN4base8internal7InvokerINS0_9BindStateINS_17RepeatingCallbackIFvN8chromeos20DBusMethodCallStatusERKNS_15DictionaryValueEEEEJS5_EEEFvS8_EE7RunImplIRKSA_RKNSt3__15tupleIJS5_EEEJLm0EEEEvOT_OT0_NSH_16integer_sequenceImJXspT1_EEEES8_
#34 0x7f5cca701454 _ZN4base8internal7InvokerINS0_9BindStateINS_17RepeatingCallbackIFvN8chromeos20DBusMethodCallStatusERKNS_15DictionaryValueEEEEJS5_EEEFvS8_EE3RunEPNS0_13BindStateBaseES8_
#35 0x7f5cca3a2b0d _ZNKR4base17RepeatingCallbackIFvRKNS0_IFvvEEEEE3RunES4_
#36 0x7f5cca6ead05 chromeos::(anonymous namespace)::OnDictionaryValueMethodWithErrorCallback()
#37 0x7f5cca6ef6bf _ZN4base8internal13FunctorTraitsIPFvPN8chromeos17ShillClientHelper9RefHolderERKNS_17RepeatingCallbackIFvRKN4dbus10ObjectPathEEEERKNS6_IFvRKNSt3__112basic_stringIcNSF_11char_traitsIcEENSF_9allocatorIcEEEESN_EEEPNS7_8ResponseEEvE6InvokeISV_JS5_SC_SP_ST_EEEvOT_DpOT0_
#38 0x7f5cca6ef63d _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIPFvPN8chromeos17ShillClientHelper9RefHolderERKNS_17RepeatingCallbackIFvRKN4dbus10ObjectPathEEEERKNS8_IFvRKNSt3__112basic_stringIcNSH_11char_traitsIcEENSH_9allocatorIcEEEESP_EEEPNS9_8ResponseEEJS7_SE_SR_SV_EEEvOT_DpOT0_
#39 0x7f5cca6f167c _ZN4base8internal7InvokerINS0_9BindStateIPFvPN8chromeos17ShillClientHelper9RefHolderERKNS_17RepeatingCallbackIFvRKNS_15DictionaryValueEEEERKNS7_IFvRKNSt3__112basic_stringIcNSF_11char_traitsIcEENSF_9allocatorIcEEEESN_EEEPN4dbus8ResponseEEJNS0_12OwnedWrapperIS5_EESC_SP_EEEFvSU_EE7RunImplISW_NSF_5tupleIJSY_SC_SP_EEEJLm0ELm1ELm2EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEEOSU_
#40 0x7f5cca6f14e6 _ZN4base8internal7InvokerINS0_9BindStateIPFvPN8chromeos17ShillClientHelper9RefHolderERKNS_17RepeatingCallbackIFvRKNS_15DictionaryValueEEEERKNS7_IFvRKNSt3__112basic_stringIcNSF_11char_traitsIcEENSF_9allocatorIcEEEESN_EEEPN4dbus8ResponseEEJNS0_12OwnedWrapperIS5_EESC_SP_EEEFvSU_EE7RunOnceEPNS0_13BindStateBaseESU_
#41 0x7f5cca26ee9f _ZNO4base12OnceCallbackIFvP15DBusPendingCallEE3RunES2_
#42 0x7f5cca26d96c dbus::ObjectProxy::CallMethodWithErrorCallback()::$_0::operator()()
#43 0x7f5cca26d8f3 _ZN4base8internal13FunctorTraitsIZN4dbus11ObjectProxy27CallMethodWithErrorCallbackEPNS2_10MethodCallEiNS_12OnceCallbackIFvPNS2_8ResponseEEEENS6_IFvPNS2_13ErrorResponseEEEEE3$_0vE6InvokeISF_JSA_SE_S8_SC_EEEvOT_DpOT0_
#44 0x7f5cca26d83d _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIZN4dbus11ObjectProxy27CallMethodWithErrorCallbackEPNS4_10MethodCallEiNS_12OnceCallbackIFvPNS4_8ResponseEEEENS8_IFvPNS4_13ErrorResponseEEEEE3$_0JSC_SG_SA_SE_EEEvOT_DpOT0_
#45 0x7f5cca26d7d0 _ZN4base8internal7InvokerINS0_9BindStateIZN4dbus11ObjectProxy27CallMethodWithErrorCallbackEPNS3_10MethodCallEiNS_12OnceCallbackIFvPNS3_8ResponseEEEENS7_IFvPNS3_13ErrorResponseEEEEE3$_0JSB_SF_EEEFvS9_SD_EE7RunImplISG_NSt3__15tupleIJSB_SF_EEEJLm0ELm1EEEEvOT_OT0_NSL_16integer_sequenceImJXspT1_EEEEOS9_OSD_
#46 0x7f5cca26d696 _ZN4base8internal7InvokerINS0_9BindStateIZN4dbus11ObjectProxy27CallMethodWithErrorCallbackEPNS3_10MethodCallEiNS_12OnceCallbackIFvPNS3_8ResponseEEEENS7_IFvPNS3_13ErrorResponseEEEEE3$_0JSB_SF_EEEFvS9_SD_EE7RunOnceEPNS0_13BindStateBaseES9_SD_
#47 0x7f5cca26ea82 _ZNO4base12OnceCallbackIFvPN4dbus8ResponseEPNS1_13ErrorResponseEEE3RunES3_S5_
#48 0x7f5cca265d36 dbus::ObjectProxy::RunResponseOrErrorCallback()
#49 0x7f5cca2753ea _ZN4base8internal13FunctorTraitsIMN4dbus11ObjectProxyEFvNS3_19ReplyCallbackHolderENS_9TimeTicksEPNS2_8ResponseEPNS2_13ErrorResponseEEvE6InvokeISB_13scoped_refptrIS3_EJS4_S5_S7_S9_EEEvT_OT0_DpOT1_
#50 0x7f5cca2752b1 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN4dbus11ObjectProxyEFvNS5_19ReplyCallbackHolderENS_9TimeTicksEPNS4_8ResponseEPNS4_13ErrorResponseEEJ13scoped_refptrIS5_ES6_S7_S9_SB_EEEvOT_DpOT0_
#51 0x7f5cca2751fd _ZN4base8internal7InvokerINS0_9BindStateIMN4dbus11ObjectProxyEFvNS4_19ReplyCallbackHolderENS_9TimeTicksEPNS3_8ResponseEPNS3_13ErrorResponseEEJ13scoped_refptrIS4_ES5_S6_S8_SA_EEEFvvEE7RunImplISC_NSt3__15tupleIJSE_S5_S6_S8_SA_EEEJLm0ELm1ELm2ELm3ELm4EEEEvOT_OT0_NSJ_16integer_sequenceImJXspT1_EEEE
#52 0x7f5cca274fe9 _ZN4base8internal7InvokerINS0_9BindStateIMN4dbus11ObjectProxyEFvNS4_19ReplyCallbackHolderENS_9TimeTicksEPNS3_8ResponseEPNS3_13ErrorResponseEEJ13scoped_refptrIS4_ES5_S6_S8_SA_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#53 0x7f5cdd85dbbc _ZNO4base12OnceCallbackIFvvEE3RunEv
#54 0x7f5cddb0f421 base::(anonymous namespace)::PostTaskAndReplyRelay::RunTaskAndPostReply()
#55 0x7f5cddb10033 _ZN4base8internal13FunctorTraitsIPFvNS_12_GLOBAL__N_121PostTaskAndReplyRelayEEvE6InvokeIS5_JS3_EEEvOT_DpOT0_
#56 0x7f5cddb0ff9d _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIPFvNS_12_GLOBAL__N_121PostTaskAndReplyRelayEEJS5_EEEvOT_DpOT0_
#57 0x7f5cddb0ff60 _ZN4base8internal7InvokerINS0_9BindStateIPFvNS_12_GLOBAL__N_121PostTaskAndReplyRelayEEJS4_EEEFvvEE7RunImplIS6_NSt3__15tupleIJS4_EEEJLm0EEEEvOT_OT0_NSB_16integer_sequenceImJXspT1_EEEE
#58 0x7f5cddb0fea9 _ZN4base8internal7InvokerINS0_9BindStateIPFvNS_12_GLOBAL__N_121PostTaskAndReplyRelayEEJS4_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#59 0x7f5cdd85dbbc _ZNO4base12OnceCallbackIFvvEE3RunEv
#60 0x7f5cdd8b4358 base::debug::TaskAnnotator::RunTask()
#61 0x7f5cdd950816 base::MessageLoopImpl::RunTask()
#62 0x7f5cdd950bbe base::MessageLoopImpl::DeferOrRunPendingTask()
#63 0x7f5cdd951389 base::MessageLoopImpl::DoWork()
#64 0x7f5cddc40315 base::MessagePumpLibevent::Run()
#65 0x7f5cdd94ff0b base::MessageLoopImpl::Run()
#66 0x7f5cdda03a7d base::RunLoop::Run()
#67 0x5c592b4989b3 ChromeBrowserMainParts::MainMessageLoopRun()
#68 0x7f5cd70f4691 content::BrowserMainLoop::RunMainMessageLoopParts()
#69 0x7f5cd70fdaa0 content::BrowserMainRunnerImpl::Run()
#70 0x7f5cd70e702b content::BrowserMain()
#71 0x7f5cd96f1877 content::RunBrowserProcessMain()
#72 0x7f5cd96f4f33 content::ContentMainRunnerImpl::RunServiceManager()
#73 0x7f5cd96f3aaf content::ContentMainRunnerImpl::Run()
#74 0x7f5cd96e8d1c content::ContentServiceManagerMainDelegate::RunEmbedderProcess()
#75 0x7f5ca8faff5a service_manager::Main()
#76 0x7f5cd96ef213 content::ContentMain()
#77 0x5c5927213858 ChromeMain
#78 0x5c5927213742 main
#79 0x7f5cab0c5736 __libc_start_main
#80 0x5c59272135e9 _start

 
Blocking: 906293
Cc: -khmel@chromium.org
Labels: -Pri-3 Pri-0
Owner: khmel@chromium.org
We're planning to enable dcheck on simple chrome workflow. khmel@, can you find  someone in ARC team who can look into this?
We're planning to enable dcheck on simple chrome workflow. khmel@, can you find  someone in ARC team who can look into this?
Owner: abhishekbh@chromium.org
+ abhishekbh@
Project Member

Comment 5 by sheriffbot@chromium.org, Dec 3

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Will take a look today.
Cc: cernekee@chromium.org
 Issue 712179  has been merged into this issue.
Cc: abhishekbh@chromium.org
Owner: steve...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a38ea44347fbb87a26c177412c38ce9f765f1ad

commit 2a38ea44347fbb87a26c177412c38ce9f765f1ad
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Dec 20 23:56:00 2018

ArcNetHostImpl: Fix DCHECK and modernize Value code

Previously the translation code assumed that onc::ipconfig::kIPAddress
would never be empty, however that is not enforced in ONC. If the
address is empty it should be treated as if it is not present.

With this change the code will fall back to a Saved or Static IP
Address if the value is missing or if it is empty. If none are
available the IP Address will not be set.

Bug:  902713 
Change-Id: I2f9880966661a85a8aace04e56bdac8516e5b3e4
Reviewed-on: https://chromium-review.googlesource.com/c/1379207
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618388}
[modify] https://crrev.com/2a38ea44347fbb87a26c177412c38ce9f765f1ad/components/arc/net/arc_net_host_impl.cc

Status: Fixed (was: Started)

Sign in to add a comment