New issue
Advanced search Search tips

Issue 902711 link

Starred by 1 user
Status: Fixed
Owner:
derat@chromium.org
Closed: Nov 7
Cc:
akes...@chromium.org
dgarr...@chromium.org
jclinton@chromium.org
hidehiko@chromium.org
nya@chromium.org
chromeos-continuous-integration-fire-hose@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

betty-pre-cq should run Tast tests

Project Member Reported by derat@chromium.org, Nov 7 
We run VMTest on betty-pre-cq. We should presumably be running TastVMTest too to catch changes that would break tests before they hit the CQ -- see e.g. https://chromiumos-build-annotator.googleplex.com/build_annotations/edit_annotations/master-paladin/3110121/ , which I think possibly could've been blocked earlier.

The TastVMTest stage takes less than five minutes to run on amd64-generic-paladin and betty-paladin (which run the same tests, except betty-paladin also runs arc.Boot).

I'm looking into how to configure this.  Issue 887094  seems related.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/fd5e90efc65addfa254cc027931e0d7f5067efc8

commit fd5e90efc65addfa254cc027931e0d7f5067efc8
Author: Daniel Erat <derat@chromium.org>
Date: Wed Nov 07 20:09:29 2018

chromeos_config: Run Tast VM tests on betty-pre-cq.

Make the betty-pre-cq builder include the TastVMTest stage
to run the same Tast tests that are run on paladin builders.
This makes it more likely that we'll catch broken changes
before they hit the CQ. We already do the same thing with
the VMTest stage.

BUG= chromium:902711 
TEST=viewed updated config_dump.json

Change-Id: Ib80a46e400d2710f83829e954d5bae82efdd3f1e
Reviewed-on: https://chromium-review.googlesource.com/1323389
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/fd5e90efc65addfa254cc027931e0d7f5067efc8/config/chromeos_config.py
[modify] https://crrev.com/fd5e90efc65addfa254cc027931e0d7f5067efc8/config/config_dump.json
[modify] https://crrev.com/fd5e90efc65addfa254cc027931e0d7f5067efc8/config/chromeos_config_test.py

Comment 2 by derat@chromium.org, Nov 7

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/015095e181ea1b256d518c44948c737e07055aed

commit 015095e181ea1b256d518c44948c737e07055aed
Author: Daniel Erat <derat@chromium.org>
Date: Fri Nov 09 00:54:41 2018
►

Sign in to add a comment